mrafieir/m31_spitzer-irac

Spitzer-IRAC observations of M31 (Rafiei Ravandi et al. 2016)

m31_spitzer-irac's Issues

General repo organization

In general the organization looks fine. A few things to consider:

It's good to have a README file or some way to indicate what each of the directories are for.

For directories where you would typically execute scripts in a set order, it's good to document what that order is, and what the input/output files for each step are.

It's fine that the big FITS files are not included here, but it would be good to have them (& the other data files) somewhere accessible.

rings directory

looks like halo.pro needs "ringprof" function? Is this somewhere else?
[or irrelevant since not used anyway..]

cmpltnss directory

in cmpltnss/cmp_area.pro -- I'm not quite clear on what you're using the catalogs for. Why do you need both catalog and images?

in m_cmp.pro, I see what you're doing; suggest making the comments a little more descriptive, ie "fitting a line to the number counts d(log N)/dm"

wedge directory

archplt.pro could use a few more comments, esp the first few lines
bootstrap_median.pro, resample.pro, type.pro: make note of where you got this code from (URL)
dconv.pro, flxconv.pro, rmsdev.pro - need 1-line descriptions
flxmeasure.pro, sfplt.pro: need comments
sfp.pro - looks good

fgbr directory

• directory name could be a bit more descriptive
• irac2wise, trilgen, tril need one-line descriptions of what they do

masterfgr is nicely commented!

isochrones directory

in isoc.pro, please check the apparent/absolute mag conversion. I think there might be a pc/kpc error?

pdm directory

expdisk.pro, i2mu.pro, mu2i.pro, powhalo.pro, serbulge.pro - need 1-line explanations
galmodel.pro - needs comments

starcount directory

radarea.pro could use a few more comments: what is 'refmap' ?
scount.pro: don't want to use angular diameter distance here.

fit directory

fitcript.pro: starts off with good comments & then you got tired? :) What does the commented-out area do?

medcript.pro, smt.pro: look good.

Wasn't quite clear what the order of steps here is: maybe a README file?