mrasterisco/combopicker

A SwiftUI implementation of a picker that also allows direct input.

combopicker's Issues

Support more complicated value formatters

Overview

Currently, the only way to format values displayed in the picker is by overriding the label property of the ComboPickerModel implementation. This doesn't allow further customization, such as using additional context when formatting.

Proposed Solution

Add a new property that allows clients to inject a value formatter. This formatter is a generic protocol that must accept values of the ComboPickerModel implementation and return strings.

This won't be applied to macOS, where the LosslessStringConvertible must be used instead.

Allow customizing font for picker

Overview

On iOS and iPadOS, it should be possible to customize the font of items displayed in the picker. The same font should also be applied to the manual input field, for consistency.

Proposed Solution

We could make use of this delegate method, instead of the limited one we're using in NativePicker.Coordinator right now.

Manual Input doesn't add values on tvOS and macOS

Overview

When inserting a new value via manual input, it should be added to the list of existing values. This isn't working properly on macOS and tvOS.

Multiple ComboPicker in the same view conflict with each other

Overview

Because of a limitation on how the Picker works in SwiftUI, when displaying two (or more) ComboPicker in the same view, only one of them will work correctly. The last added will intercept all tap and scroll events and will prevent the other pickers from being used.

This is only a problem on iOS and iPadOS.

Proposed Solution

This could be fixed by rolling-out our own picker implementation, instead of relying on the system one. This would also have the benefit of allowing custom sizes (instead of forcing the picker to be as wide as its container).

Layout issues in List

Overview

There are some layout issues when embedding the picker in a list, possibly because of the additional space that the picker would like to take.

Proposed Solution

Investigate how to override the intrinsicContentSize of the NativePicker, so that AutoLayout knows what size the picker should have.