Comments (3)
Mugen87
commented on June 23, 2024
I'm afraid it is not clear what you are suggesting. Please do never use screenshots to explain code changes. It's better to implement them in a branch and then share the commit. In this way, we can easier see the diff.
from three.js.
kristiker
commented on June 23, 2024
Sure, I might get to it soon. Edit: There you go @Mugen87 5fae13b
from three.js.
Mugen87
commented on June 23, 2024
TBH, I don't see how this commit is an improvement. It makes the code actually harder to read since the AO-related logic now leaks into a chunk where it does not belong.
Sorry, but you need to find a solution for this on app level.
from three.js.
Related Issues (20)
- WebGPU: WebGPURenderer throws a DOMException error on a non-WebGPU browser HOT 2
- Docs: Please updates "WebGL compatibility check" page
- USDZLoader: TypeError: target is undefined HOT 2
- Improve GPUComputationRenderer performance by using fullscreen triangle HOT 3
- WebGPURenderer: Weird DirectionalLight Behavior Between WebGLRenderer and WebGPU Renderer HOT 3
- NodeMaterial: Alpha channel behaves wrong on non-transparent materials HOT 1
- `GLTFExporter` <> `GLTFLoader` round trip `TypeError: Cannot set properties of undefined (setting 'isBone')` HOT 2
- WebGLRenderTarget Texture breaks glTF export HOT 2
- games_fps Example: Collision detection anomaly HOT 4
- Bug Collision detection anomaly HOT 1
- Why functions like Box3.getSize() need a vector3 parameter ? HOT 2
- GLTFLoader.loadAsync unclear error should clearly state file not found HOT 4
- 161 -> 162 DragControls breaks for multiple groups HOT 1
- USDZLoader: loading a binary file does not throw error
- packDepthToRG seems broken HOT 11
- USDZLoader doesn't support all .usdz(usda) files. The only showcase example file works. HOT 3
- games_fps Example clash detection anomaly
- Shader unit test framework
- Regression introduced in r144, re: WebXRManager.updateCamera HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from three.js.