Recorder thread fails to join

[mre]

Recorder thread fails to join

[mre]

That's weird. It works for me. I thought that by calling _set_stop(), which sets the flag to stop the recording thread after the next iteration, it would terminate recording. Maybe there's an edge case that is not covered? Anyway, I'd be happy to merge a PR that fixes that if you want to give it a shot.
Thanks for the report.

[cmangla]

I tried very hard to figure out if there is some weird race condition in there. When _set.stop() is called, it seems to do its job. The loop in run() does indeed terminate. So I cannot figure out why Thread.join() then hangs. I even tried using a timeout in Thread.join, but that makes no difference: it hangs and does not time out.

The only clean solution I've found is to run Recorder in a different process. PR #24 does so.

[cmangla]

Thanks for merging PR #24 @mre.