mrk21/firebrew

Firefox add-ons manager for CUI.

firebrew's Issues

The unit test failed on the Windows.

The error messages are shown below:

  1) Firebrew::Firefox::Profile Manager #all() should construct records
     Failure/Error: expect(subject[2].path).to eq('/path/to/abs_profile')

       expected: "/path/to/abs_profile"
            got: "Z:/path/to/abs_profile"

       (compared using ==)
     # ./spec/firebrew/firefox/profile_spec.rb:36:in `block (4 levels) in <module:Firefox>'

  2) Firebrew::Runner Instance #install(params) should not raise Exception
     Failure/Error: it { expect{subject}.to_not raise_error }
       expected no Exception, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:160:in `block (4 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:164:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:164:in `block (4 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:164:in `block (4 levels) in <module:Firebrew>'

  3) Firebrew::Runner Instance #install(params) when the `params[:term]` existed should raise Firebrew::OperationAlreadyCompletedError
     Failure/Error: it { expect{subject}.to raise_error(Firebrew::OperationAlreadyCompletedError) }
       expected Firebrew::OperationAlreadyCompletedError, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:169:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:173:in `block (6 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:173:in `block (5 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:173:in `block (5 levels) in <module:Firebrew>'

  4) Firebrew::Runner Instance #uninstall(params) should not raise Exception
     Failure/Error: it { expect{subject}.to_not raise_error }
       expected no Exception, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:180:in `block (4 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:184:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:184:in `block (4 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:184:in `block (4 levels) in <module:Firebrew>'

  5) Firebrew::Runner Instance #uninstall(params) when the `params[:term]` not existed should raise Firebrew::OperationAlreadyCompletedError
     Failure/Error: it { expect{subject}.to raise_error(Firebrew::OperationAlreadyCompletedError) }
       expected Firebrew::OperationAlreadyCompletedError, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:190:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:194:in `block (6 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:194:in `block (5 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:194:in `block (5 levels) in <module:Firebrew>'

Finished in 6.07 seconds (files took 18.39 seconds to load)
72 examples, 5 failures

Failed examples:

rspec ./spec/firebrew/firefox/profile_spec.rb:26 # Firebrew::Firefox::Profile Manager #all() should construct records
rspec ./spec/firebrew/runner_spec.rb:164 # Firebrew::Runner Instance #install(params) should not raise Exception
rspec ./spec/firebrew/runner_spec.rb:173 # Firebrew::Runner Instance #install(params) when the `params[:term]` existed should raise Firebrew::OperationAlreadyCompletedError
rspec ./spec/firebrew/runner_spec.rb:184 # Firebrew::Runner Instance #uninstall(params) should not raise Exception
rspec ./spec/firebrew/runner_spec.rb:194 # Firebrew::Runner Instance #uninstall(params) when the `params[:term]` not existed should raise Firebrew::OperationAlreadyCompletedError

Make it possible to designate an extension type.

Make the help message in detail.

Changes listed below:

• The command return value
• A message of the help command and version command
• A message of the commands

Set the `Firebrew::VERSION` to 0.1.0.

Add the some attributes to the `BasicExtension`.

Will add the attributes listed below:

• description
• min_app_version
• max_app_version
• target_platform

The unit test failed on the Windows(#10): The 2 to 5 errors.

The error messages in the issue #10:

  2) Firebrew::Runner Instance #install(params) should not raise Exception
     Failure/Error: it { expect{subject}.to_not raise_error }
       expected no Exception, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:160:in `block (4 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:164:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:164:in `block (4 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:164:in `block (4 levels) in <module:Firebrew>'

  3) Firebrew::Runner Instance #install(params) when the `params[:term]` existed should raise Firebrew::OperationAlreadyCompletedError
     Failure/Error: it { expect{subject}.to raise_error(Firebrew::OperationAlreadyCompletedError) }
       expected Firebrew::OperationAlreadyCompletedError, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:169:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:173:in `block (6 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:173:in `block (5 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:173:in `block (5 levels) in <module:Firebrew>'

  4) Firebrew::Runner Instance #uninstall(params) should not raise Exception
     Failure/Error: it { expect{subject}.to_not raise_error }
       expected no Exception, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:180:in `block (4 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:184:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:184:in `block (4 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:184:in `block (4 levels) in <module:Firebrew>'

  5) Firebrew::Runner Instance #uninstall(params) when the `params[:term]` not existed should raise Firebrew::OperationAlreadyCompletedError
     Failure/Error: it { expect{subject}.to raise_error(Firebrew::OperationAlreadyCompletedError) }
       expected Firebrew::OperationAlreadyCompletedError, got #<Firebrew::FirefoxCommandError: Firebrew::FirefoxCommandError> with backtrace:
         # ./lib/firebrew/firefox/command.rb:17:in `rescue in initialize'
         # ./lib/firebrew/firefox/command.rb:12:in `initialize'
         # ./lib/firebrew/runner.rb:42:in `new'
         # ./lib/firebrew/runner.rb:42:in `initialize'
         # ./spec/firebrew/runner_spec.rb:135:in `new'
         # ./spec/firebrew/runner_spec.rb:135:in `block (3 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:190:in `block (5 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:194:in `block (6 levels) in <module:Firebrew>'
         # ./spec/firebrew/runner_spec.rb:194:in `block (5 levels) in <module:Firebrew>'
     # ./spec/firebrew/runner_spec.rb:194:in `block (5 levels) in <module:Firebrew>'

The reason it occurs the above errors is that the Firefox command path contains spaces. Therefore, will wrap that by double quotations shown below:

before:

result = @executer.exec('%{firefox} --version' % @config)

after:

result = @executer.exec('"%{firefox}" --version' % @config)

Stop depending on `ActiveSupport`.

Stop depending on `ActiveModel`.

Fix the README.

Will fix the points listed below:

• To execution is required the OpenSSL.
• The default values of the configs for the Windows.

Add the subcommand help.

Make it possible to display a download progress of the extension.

Designate the current platform to the `os` parameter when use the `Amo::Search`.

Will newly create the Platform class which return the current platform, and will pass the value obtained from that class to the Amo::Search.

When the profile not existed, to enable to create the profile.

The unit test failed on the Windows(#10): The first error.

The error message in the issue #10:

  1) Firebrew::Firefox::Profile Manager #all() should construct records
     Failure/Error: expect(subject[2].path).to eq('/path/to/abs_profile')

       expected: "/path/to/abs_profile"
            got: "Z:/path/to/abs_profile"

       (compared using ==)
     # ./spec/firebrew/firefox/profile_spec.rb:36:in `block (4 levels) in <module:Firefox>'

It should be changed as shown below:

before:

expect(subject[2].path).to eq('/path/to/abs_profile')

after:

expect(subject[2].path).to eq(File.expand_path('/path/to/abs_profile'))

When the `em:unpack` value of the install manifests was true, is unable to normally installing.

If in order to resolve this issue, the em:unpack value of the install manifests was true, it shall denominate to the value of GUID after unzip the XPI package.

Make it possible to designate the language for when using the `Amo::Search`.

The default value will be used LANG environment variable.

Set the Firebrew::VERSION to 0.1.1.

Stop depending on `ActiveResource`.

Will be use Faraday instead of ActiveResource.

Add the command of getting the profile information.

The profile information which are got are listed below.:

• The profile name
• The profile path
• Whether the profile is default

The handling of when the network errors of the 404 Not Found HTTP error, etc occurs on the Amo::Search.

it must throw the Firebrew::NetworkError exception. Also, it must display the message of this exception, and return the corresponding value for it.

Change the command return value.

Will be changed as listed below:

• Normal completion: 0
• Error: 1
• No operation: 2

When the `OptionParser::InvalidOption` was thrown, catch the exception and throw the `Firebrew::CommandLineError`.

The `OptionParser` exceptions has not been handled enough.

The error shown below:

$ bundle exec ./bin/firebrew -f
#<OptionParser::MissingArgument: -f>
firebrew/lib/firebrew/command_line.rb:120:in `opt_operation'
firebrew/lib/firebrew/command_line.rb:63:in `initialize'
firebrew/lib/firebrew/command_line.rb:13:in `new'
firebrew/lib/firebrew/command_line.rb:13:in `execute'
./bin/firebrew:5:in `<main>'
#

In the current implementation. has been handle only the OptionParser::InvalidOption exception, so will handle the all OptionParser exceptions.

The typo of the `Runner::default_options` for the Windows.

The base_dir value:

Wrong: ~/AppData/Roming/Mozilla/Firefox
Right: ~/AppData/Roaming/Mozilla/Firefox

Is not able to install on the profile creation immediate aftermath.

The reason is to not exist the extension.json on the profile creation immediate aftermath.

For the currently implementation, throw the exception when the extension.json not found, so throw the exception rather than create that.

Implement the `os` gem.

The gem is a simple platform selector.
Site: rdp/os

Throw an exception when entered the invalid command.

Throw the Firebrew::CommandLineError as shown below:

$ firebrew invalid-command
...(Firebrew::CommandLineError)
   from: path/to/error
   ...

When occurred an error, display a message of the error and return the corresponding value for the error to the system.

Add the upgrade command.

Add a function which sets an enabled/disabled of each search engine.

In the case of the Windows, occurs the OpenSSL errors when installed an extension.

The error messages:

#<OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed>

Change to 0 a return value of the help command and version command.

Write the README.

The contents of the README is listed below:

• Command usage
• Environment variables

Add the detailed error messages.

Not working on Debian Jessie (Iceweasel)

Hello,

I'm trying to use firebrew on Debian Jessie, which is shipped with Iceweasel. I thought that firebrew would work since Iceweasel seems to be a modified Firefox however it doesn't work. The error is:

# Error
[afu:~]$ firebrew info
(process:25628): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
Command is not Firefox: /usr/bin/firefox

# Trying with the profile
[afu:~]$ firebrew -d ~/.mozilla/firefox info
(process:25923): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
Command is not Firefox: /usr/bin/firefox

# Trying especifying the binary
[afu:~]$ firebrew -f /usr/bin/firefox info  
(process:25951): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
Command is not Firefox: /usr/bin/firefox

# Trying especifying the iceweasel binary
[afu:~]$ firebrew -f /usr/bin/iceweasel info 
(process:26087): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed
Command is not Firefox: /usr/bin/iceweasel

# Firefox alias available at /usr/bin/firefox
[afu:~]$ which firefox
/usr/bin/firefox

Any idea?

Thank you very much.

If the `install` element of the extension which was got by the generic AMO API was equal or greater than two, then occurs errors.

The occurred errors listed below:

$ firebrew install 'Hatena Bookmark'
#<TypeError: no implicit conversion of Array into String>
lib/ruby/2.1.0/open-uri.rb:36:in `open'
lib/ruby/2.1.0/open-uri.rb:36:in `open'
lib/ruby/gems/2.1.0/gems/firebrew-0.1.1/lib/firebrew/firefox/extension.rb:45:in `install'
lib/ruby/gems/2.1.0/gems/firebrew-0.1.1/lib/firebrew/runner.rb:55:in `install'
lib/ruby/gems/2.1.0/gems/firebrew-0.1.1/lib/firebrew/command_line.rb:112:in `execute'
lib/ruby/gems/2.1.0/gems/firebrew-0.1.1/lib/firebrew/command_line.rb:12:in `execute'
lib/ruby/gems/2.1.0/gems/firebrew-0.1.1/bin/firebrew:5:in `<top (required)>'
bin/firebrew:23:in `load'
bin/firebrew:23:in `<main>'

In the current implementation, it has not assuming a case of when the install element was equal or greater than two, so it will change as choosing a first element in the install elements.

Improve the help message.

The currently help message is inadequacy, so it change as shown below:

$ firebrew --help
Usage: firebrew [options] command
commands:
    install:
        firebrew install extension-name

    uninstall:
        firebrew uninstall extension-name

    info:
        firebrew info extension-name

    search:
        firebrew search term

    list:
        firebrew list

options:
    -d, --base-dir=path              Firefox profiles.ini directory
    -p, --profile=name               Firefox profile name
    -f, --firefox=path               Firefox command path

Has not been throw the `SystemCall` exception when executed the command which is not existed.

The reason is that in the command execution part, the command is enclosed in double quotation marks. In this case, in spite of executing the command which is not existed, not throw the SystemCall exception. In order to resolve this issue, will stop enclosing the command in double quotation marks and escape it.

When executed the command of the `install` or `uninstall`, throw an exception if it has already done the operation.

Throw the Firebrew::OperationAlreadyCompletedError as shown below:

$ firebrew install installed-extension
...(Firebrew::OperationAlreadyCompletedError)
    from: path/to/error
    ...