ms5984/clansbanks

An official Clans[Free] addon which adds simple banking features

clansbanks's Issues

German translation

What kind of interest is there in a German translation? If you'd like to help, reach out!

ConcurrentModificationException

Not sure if this is affecting the main release, might be resolved in branch before re-merge.

Expected: Depositing works fine, balance is updated.

Issue: Depositing causes ConcurrentModificationException AND as a result does not save the bank state. This causes the balance update to fail without undoing the Vault transaction and erroneously reports SUCCESS.

[07:24:28 INFO]: [Clans[Banks]] Transaction [SUCCESS]: The_Regurgitator deposited 100 with clan Test
[07:24:28 WARN]: [Clans[Banks]] Task #2645 for ClansBanks v1.2.0-SNAPSHOT generated an exception
java.util.ConcurrentModificationException: null
        at java.util.HashMap.computeIfAbsent(HashMap.java:1134) ~[?:?]
        at com.github.ms5984.clans.clansbanks.model.BankMeta.get(BankMeta.java:193) ~[?:?]
        at com.github.ms5984.clans.clansbanks.model.BankEventsListener$2.run(BankEventsListener.java:87) ~[?:?]
        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:99) ~[patched_1.16.5.jar:git-Paper-475]
        at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:468) ~[patched_1.16.5.jar:git-Paper-475]
        at net.minecraft.server.v1_16_R3.MinecraftServer.b(MinecraftServer.java:1294) ~[patched_1.16.5.jar:git-Paper-475]
        at net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:377) ~[patched_1.16.5.jar:git-Paper-475]
        at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1209) ~[patched_1.16.5.jar:git-Paper-475]
        at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:997) ~[patched_1.16.5.jar:git-Paper-475]
        at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:174) ~[patched_1.16.5.jar:git-Paper-475]
        at java.lang.Thread.run(Thread.java:834) [?:?]
[07:24:45 INFO]: The_Regurgitator issued server command: /clan bank withdraw 1000
[07:24:45 INFO]: [Clans[Banks]] >>PRE-Cancelled [DENIED]: The_Regurgitator to withdraw 1000 from clan Test
[07:24:48 INFO]: The_Regurgitator issued server command: /clan bank withdraw 100
[07:24:48 INFO]: [Clans[Banks]] >>PRE-Cancelled [DENIED]: The_Regurgitator to withdraw 100 from clan Test

BankLog loaded from Bank String

Resolving before 1.2.0 release

Unit testing

Unit testing focuses on writing code to test small segments of code--units--independently and reliably. To this end I am writing tests such that one test method = one class method, one test class = one class.

PlaceholderAPI integration

%clansbanks_balance% - Retrieve the balance of a player's clan.