Giter Site home page Giter Site logo

mschae23 / grind-enchantments Goto Github PK

View Code? Open in Web Editor NEW
12.0 1.0 13.0 429 KB

Put enchantments back on a book using a grindstone.

Home Page: https://legacy.curseforge.com/minecraft/mc-mods/grind-enchantments

License: GNU Lesser General Public License v3.0

Java 100.00%
minecraft minecraft-mod fabricmc grindstone enchantments disenchant grind-enchantments enchantment enchant

grind-enchantments's Issues

Enchanted book is there but I can't take it

image
Whenever I click the book, it instantly puts it back.
I'm using 1.20.2 on a fabric server.
The mod is installed on the server and not my client, the reason for this is I want mods that my friends don't have to download.

Server hangs up on restart

Unless this is somehow an old crash report, I'm not sure why it would hang up in this situation.
It's worked flawlessly since last update, but when I install DiscordConnect and try to do a server shut down or restart it saves world data and then hangs up. Without DiscordConnect it works as expected and as before.
I submitted the bug report to DiscordConnect and was sent your way over the hang up and crash. Logs are all posted here AMereBagatelle/DiscordConnect#1

Cost calculations not making sense with config entries.

I don't know if it is a lack of documentation, a problem in the logic, or the config file is being ignored, but I'm seeing extremely high costs for moving an enchantment from a tool/weapon to a book.

For instance, level 3 efficiency with a cost of 12 levels. I was expecting 0 or 1 level for the cost.

This is my config file:

{
  "allow_removing_curses": true,
  "dedicated_server_options": {
    "alternative_cost_display_enabled": false
  },
  "client_options": {
    "show_enchantment_cost": true
  },
  "disenchant_to_book": {
    "enabled": true,
    "consume_enchanted_item": false,
    "cost_config": {
      "count_mode": {
        "type": "grindenchantments:count_levels"
      },
      "cost_factor": 0.25,
      "cost_offset": 0.0
    }
  },
  "move_enchantments": {
    "enabled": true,
    "cost_config": {
      "count_mode": {
        "delegate": {
          "normal_factor": 0.25,
          "treasure_factor": 0.25,
          "type": "grindenchantments:count_levels"
        },
        "type": "grindenchantments:first_enchantment"
      },
      "cost_factor": 0.25,
      "cost_offset": 0.0
    }
  }
}

Cost is not showing in Grindstone?

Hi, I'm using this mod on a server of mine, and I really enjoy it. The only issue I've encountered is that the grindstone does not show the player how much the disenchantment costs. In the image on the Modrinth page, the cost is shown, so I wasn't sure if that was supposed to happen or not.

[Bug] 1.19.2 Pollen API Incompatibility

I'm playing with the following versions installed:

I wanted to install Tolerable Creepers to shut down creeper griefing.
After that Grind Enchantments stopped working.
After experimenting with disabling the most recent installed mods, it turns out Grind Enchantments seems to be incompatible with the Pollen API, that Tolerable Creepers requires.
The last Minecraft version that both Pollen and Tolerable Creepers support is 1.19.2.

Request in a form of plugin

Hello. I would love to see this fabric mod in form of a plugin for paper/bukkit/spigot, if possible, it would really help me and players on my server. If it is possible, please do it if you can, if it isnt, well, then i will find something similiar maybe, but i wasnt able to, so i requested it here.

Compatibility with limitless

#4
Similar thing but with limitless, could you instead make a config file that maybe makes use of the different mods out there that might be doing the same thing and you could just spcify which mod it is and it'll simply work with it normally?

I just wasted all the xp haha cause I didn't look at it.

Client Side Required 1.20.5

Just updated my server and installed the latest version of the mod for 1.20.5, however I am unable to connect as its being stated there is a mod mismatch. In 1.20.4, only the server required the mod

deny disenchant by item - enhancement

could you add an option to deny disenchanting particular items?
thinking about balance and compat with enchant giver

alternatively deny or accept particular enchants? or both items and enchants

crash when rendering screen?

for some reason grind enchantments is starting to crash the game when i try to put a book and an enchanted book/item in the grindstone (what youre supposed to do if you want to disenchant an item), and says its a rendering screen error in the crash log, not sure whats causing this but it was working before i updated to the mods latest version (the 1.16.3 version of the mod)
crash log: https://hastebin.com/usiwaxowad.yaml

Charm interferes with the mod

Hey man, did some testing (going through and adding every single mod one by one until your mod stopped working). Just wanted to let you know that the problem is Charm. I made a modpack with just your mod and Charm, and it doesn't let you put a book in the bottom slot. Delete Charm, and your mod works.

Deny interaction with cursed items

Hihi,

I actually don't know how to present it to you, but I can deperate an enchantment and a curse even though "allow_removing_curses" is false.

Kinda a weird situation ngl

3.0b1 produces 'random enchantment book'

Versions

1.19.3/3.0b1

Problem description

When a non-enchanted item is put in the grinder with a stack of books, the following 2 defects are observed

  1. The produce slot proposes to create a "random enchantment book", and such book can be obtained.
  2. A full stack of books is consumed when producing the "random enchantment book" if such a stack was put in the grinder.

Expected

  1. When a non-enchanted item is in the grinder, adding a book should have no produce
  2. a single book should always be consumed

v2.0

This bug is not present in v2 of the mod.

not working 1.18.2

hey, i have the mod installed but it doesnt work. is there any known conflictions?

Tax Free Levels support

In the 3.0.0 release, the mod lost support for Tax Free Levels.

This is due to Tax Free Levels using Architectury now – simply adding it as a compile-time dependency didn't seem to work anymore.

Enchantment costs

I have been through issues trying to find answers but no success.

Pre 1.6 this was my config

{
  "allow_removing_curses": true,
  "show_enchantment_cost": true,
  "dedicated_server_options": {
    "alternative_cost_display_enabled": false
  },
  "disenchant_to_book": {
    "enabled": true,
    "consume_enchanted_item": false,
    "cost_config": {
      "count_mode": "count_levels",
      "cost_factor": 0.5,
      "cost_offset": 0.0
    }
  },
  "move_enchantments": {
    "enabled": true,
    "cost_config": {
      "count_mode": "count_enchantments",
      "cost_factor": 0.5,
      "cost_offset": 0.5
    }
  }
}

this is now my current config, with the lack of documentation i couldnt tell if i moved the settings correctly

{
  "allow_removing_curses": true,
  "dedicated_server_options": {
    "alternative_cost_display_enabled": true
  },
  "client_options": {
    "show_enchantment_cost": true
  },
  "disenchant_to_book": {
    "enabled": true,
    "consume_enchanted_item": false,
    "cost_function": {
      "function": {
        "type": "grindenchantments:count_min_power"
      },
      "factor": 0.5,
      "offset": 0.0,
      "type": "grindenchantments:transform"
    }
  },
  "move_enchantments": {
    "enabled": true,
    "cost_function": {
      "function": {
        "function": {
          "normal_factor": 0.5,
          "treasure_factor": 0.5,
          "type": "grindenchantments:count_levels"
        },
        "type": "grindenchantments:first_enchantment"
      },
      "factor": 0.5,
      "offset": 0.5,
      "type": "grindenchantments:transform"
    }
  },
  "version": 2
}

2 things seem to be wrong (For the example i am disenchanting diamond boots with prot 4 and unbreaking 3 to a blank book)

  1. The enchantment cost displayed by the client side mod and the alternative display for vanilla say different values, mod says 25 and vanilla says 28.

  2. With my changed options in the config i wouldnt expect the cost to be so high but again without any documentation on what the numbers actually do i am really just guessing.

Some help with this matter would be greatly appretiated, i am using minecraft 1.20.1, Fabric loader version 0.14.21 and installer version 0.11.2. With grind enchantments version 3.1.2+1.20

Changing Config doesn't seem to do anything.

I read one of the older issues that says that you need to edit both the client config and the server one but still it doesn't seem to do anything. Even when going singleplayer and changing the config, the number of levels required always stays the same.
I even tried to change the function type. I tested with the same item every time but the amount always stayed at 17 levels.

An easier way to make everything cheaper would be great, or at least some documentation on how to do so.

Here is my current config.

{
"allow_removing_curses": false,
"dedicated_server_options": {
"alternative_cost_display_enabled": false
},
"client_options": {
"show_enchantment_cost": true
},
"disenchant_to_book": {
"enabled": true,
"consume_enchanted_item": false,
"cost_function": {
"function": {
"type": "grindenchantments:count_levels"
},
"factor": 1.0,
"offset": 0.0,
"type": "grindenchantments:transform"
}
},
"move_enchantments": {
"enabled": true,
"cost_function": {
"function": {
"function": {
"normal_factor": 1.0,
"treasure_factor": 2.0,
"type": "grindenchantments:count_levels"
},
"type": "grindenchantments:first_enchantment"
},
"factor": 0.5,
"offset": 0.5,
"type": "grindenchantments:transform"
}
},
"version": 2
}

partially compatible with 1.19.4

Seems grind-enchantments-3.0.0-beta.1+1.19.3.jar is already compatible with 1.19.4.
Could you please mark it as compatible in Modrinth?

Thanks

This does not seem to work

Hello, I installed this mod without issues. When placing the enchanted item and the book on the grindstone, it showed an enchanted book in the output. However, I simply received the un-enchanted item without and enchanted book.

I am playing multiplayer, 1.16.4 Fabric. I have not tried singleplayer yet.

Thank you

Config error missing consume_enchanted_item

Console error:
[11:11:13] [Render thread/ERROR]: [Grind Enchantments] Error decoding config: No key consume_enchanted_item in MapLike[{"enabled":true,"cost_config":{"count_mode":"count_levels","cost_factor":1.0,"cost_offset":0.0}}]

Stacks disappear

when shift-clicking a stack of books into the grindstone, and removing an enchantment, the entire stack disappears, and only one enchanted book remains

[Bug] MC Dungeons Enchanting Incompatibility

The mod is incompatible with weapons enchanted using MC Dungeons Enchanting's new enchanting system.

The enchantments are added to the book but not removed from the item resulting in a duplication bug. This behavior only applies to weapons enchanted through the new workstations, items enchanted with the enchant command extract as intended

Compatibility with Fair Enchanting

Would it be possible for the disenchantment cost of the grindstone to be affected by Fair Enchanting's cost logic if it is installed?

The mod makes enchanting and anvil recipes cost the same amount of flat experience points, rather than consuming more the higher level you are. It does make some low-level enchantment operations cheaper, but I no longer have to worry about wasting my experience because I like to accumulate levels.

Thank you for the wonderful mod!

Bug: grinding curses produces generic "enchanted books"

When grinding an item with only curses (binding or vanishing) and a book, it produces a generic "enchanted book".
The correct behavior is to not produce anything at all, as it is actually impossible to remove a curse from an item.

When the item has a mix of curses and enchants, it first produces a book with all valid enchants, and then goes back to the bug (since the object has now only curses). That may be the intended behavior in that case, or maybe the intended behavior is that it is impossible to create books form cursed objects at all, it's a balance choice.

1.19.3 - NoSuchMethodError on startup

When trying to load this mod in 1.19.3, the following error shows on startup:

java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'grindenchantments'!
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
	at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
	at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:52)
	at net.minecraft.class_310.<init>(class_310.java:465)
	at net.minecraft.client.main.Main.method_44604(Main.java:205)
	at net.minecraft.client.main.Main.main(Main.java:51)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.NoSuchMethodError: 'void net.minecraft.class_2370.<init>(net.minecraft.class_5321, com.mojang.serialization.Lifecycle, java.util.function.Function)'
	at de.martenschaefer.grindenchantments.util.FabricRegistryBuilderUtil.createSimple(FabricRegistryBuilderUtil.java:24)
	at de.martenschaefer.grindenchantments.registry.GrindEnchantmentsRegistries.<clinit>(GrindEnchantmentsRegistries.java:9)
	at de.martenschaefer.grindenchantments.cost.CostFunction.<clinit>(CostFunction.java:10)
	at de.martenschaefer.grindenchantments.config.DisenchantConfig.lambda$static$0(DisenchantConfig.java:12)
	at com.mojang.serialization.codecs.RecordCodecBuilder.create(RecordCodecBuilder.java:72)
	at de.martenschaefer.grindenchantments.config.DisenchantConfig.<clinit>(DisenchantConfig.java:10)
	at de.martenschaefer.grindenchantments.config.GrindEnchantmentsConfig.lambda$static$0(GrindEnchantmentsConfig.java:8)
	at com.mojang.serialization.codecs.RecordCodecBuilder.create(RecordCodecBuilder.java:72)
	at de.martenschaefer.grindenchantments.config.GrindEnchantmentsConfig.<clinit>(GrindEnchantmentsConfig.java:8)
	at de.martenschaefer.grindenchantments.GrindEnchantmentsMod.<clinit>(GrindEnchantmentsMod.java:45)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Class.java:467)
	at net.fabricmc.loader.impl.util.DefaultLanguageAdapter.create(DefaultLanguageAdapter.java:50)
	at net.fabricmc.loader.impl.entrypoint.EntrypointStorage$NewEntry.getOrCreate(EntrypointStorage.java:117)
	at net.fabricmc.loader.impl.entrypoint.EntrypointContainerImpl.getEntrypoint(EntrypointContainerImpl.java:53)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
	... 8 more

Suggestion: Other ways to see the cost

If people don't use this mod on the client side (i have a server which uses server-side mods only), currently it's impossible to see the cost. I have thought up a few ways this could be achieved:

  • Send a message in chat whenever the item is updated
  • Change the name of the grindstone GUI (if this is possible with fabric)
  • Add a lore line to the "result" item that'll be removed on completion (if this is possible with fabric)
  • Send an actionbar

Obviously, the current way is the best, so if the player has the mod, it'd use that and ignore these, otherwise there would be a config line to say which one to use, i.e no_mod_cost_display: "chatmessage|guiname|resultlore|actionbar" (can't think of a good key name).

Ideally, this text lines would be configurable as well.

Thanks for taking time to read this! :)

Unable to Place Book in Grindstone

Hi, just downloaded this mod for 1.17 and it only allows me to put an enchanted item in the top slot of the grindstone. When I try to put a book on the bottom slot, it doesn't let me. I can "hover" over it with the book, but not actually place it so I can remove the enchantment from the item and put it on the book.
Screenshot 2021-06-26 053854

Add a way to reset repair cost

I mentioned this to you in a comment on curse a while back. I just wondered if you had given it any further thought.

The suggestion is to be able to take a book that combined multiple enchants, like when combining 4 Protection II books to make a single Protection IV. It has an NBT 2 tag which makes it very expensive. The idea is to be able to put that NBT2 version of Prot IV and then grind the enchant and create a fresh NBT1 Prot IV that isn't as expensive to use.

Suggestion: consume item when transferring to book

To improve balance, it may be good to actually consume the origin item when grinding enchants to books. Player would then have to choose between:

  1. grinding without a book, get back the item and gain some xp
  2. grinding with a book, get back the enchant and cost some xp

This could be a configurable toggle with prior behavior as default.

Allow removing curses

It would be nice to have a config that let you remove curses onto books as well as enchantments. The default could be false to preserve the current behavior.

Regular use of grindstone is not working correctly

Hi, I have this mod on a server of mine, and I really enjoy using it, but I've noticed that when I try to use my grindstone normally – i.e., disenchant an item, and get experience back – it doesn't work like it's supposed to.

Instead, when I put an item in a grindstone with no book underneath, it does in fact disenchant the item, BUT, it also places an 'Enchanted Book' (sometimes empty, sometimes with enchantments) in top disenchantment slot. Not only that, but it CHARGES me experience for this enchanted book. Experience that is not returned even by disenchanting the book.

Giving the enchanted books are often empty, I'm assuming this is a bug and not the intended operation of the mod.

Please let me know if there's any more information you need from me, as I would love to see this issue resolved if possible!

Thank you so much!

Edited config Json doesn't work

Long story short: i edited the config, here's the final:

{
"allow_removing_curses": false,
"dedicated_server_options": {
"alternative_cost_display_enabled": false
},
"client_options": {
"show_enchantment_cost": true
},
"disenchant_to_book": {
"enabled": true,
"consume_enchanted_item": false,
"cost_function": {
"function": {
"type": "grindenchantments:count_levels"
},
"factor": 0.05,
"offset": 1.0,
"type": "grindenchantments:transform"
}
},
"move_enchantments": {
"enabled": true,
"cost_function": {
"function": {
"function": {
"normal_factor": 0.5,
"treasure_factor": 0.5,
"type": "grindenchantments:count_levels"
},
"type": "grindenchantments:first_enchantment"
},
"factor": 0.5,
"offset": 0.5,
"type": "grindenchantments:transform"
}
},
"version": 2
}

Apparently something went wrong and the game didn't apply the edits, also I read this message in the logs:
Error decoding config: No key treasure_factor in MapLike[{"type":"grindenchantments:count_levels"}]; No key normal_factor in MapLike[{"type":"grindenchantments:count_levels"}]

How do I edit correctly the config?
Is there a bug or something?

[Bug] Changing config doesn't work

This is the configuration where I tried to set the disenchantment cost based on the sum of the spell power (Efficiency III = 3 levels), it doesn't seem to work.

{
"allow_removing_curses": false,
"dedicated_server_options": {
"alternative_cost_display_enabled": false
},
"client_options": {
"show_enchantment_cost": true
},
"disenchant_to_book": {
"enabled": true,
"consume_enchanted_item": false,
"cost_function": {
"function": {
"type": "grindenchantments:count_levels"
},
"factor": 1.0,
"offset": 0.0,
"type": "grindenchantments:transform"
}
},
"move_enchantments": {
"enabled": true,
"cost_function": {
"function": {
"function": {
"normal_factor": 1.0,
"treasure_factor": 2.0,
"type": "grindenchantments:count_levels"
},
"type": "grindenchantments:first_enchantment"
},
"factor": 0.5,
"offset": 0.5,
"type": "grindenchantments:transform"
}
},
"version": 2
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.