Comments (8)
Alright - could you try again with the latest build? I've updated to 1.5.1. I also updated the NPM package (forgot to do that for 1.5.0... oops.)
The problem was some variables weren't being protected from name mangling.
from pokesprite.
I haven't tested that in a while. To be truthful, the JS code is very old and doesn't have unit tests, but I haven't had much time to replace it. I'll see if I can fix this.
from pokesprite.
I was just about to ask the same question. Any luck with a fix?
from pokesprite.
Apologies for the lack of an update. I'm going to resolve this either today or tomorrow—I've got a pretty short workday today, but I'm hoping to have it resolved anyway. I'm sure the problem isn't that hard to fix.
from pokesprite.
Strangely, it seems that the Closure Compiler is somehow mangling the input JS code in such a way that it breaks using regular numbers. I'll need to look at this more closely tonight.
from pokesprite.
Working fine for me, thanks!
from pokesprite.
I'll take a look at this tonight! Thanks :)
from pokesprite.
Let me know if anything's wrong, assuming it works for now. 😊
from pokesprite.
Related Issues (20)
- Images for Badges? HOT 1
- PokemonSay using PokeSprite HOT 1
- Genesect Gen8 sprite inconsistency / missing Appletun-Gmax / contribution question(s) HOT 5
- Pokémon BDSP - New Icons HOT 7
- Custom female Wobbuffet sprites. HOT 1
- Pokémon LA - New Graphics HOT 5
- Pokemon PLA Sprites for Spreadsheet HOT 2
- Missing Galarian Sprites HOT 3
- Shiny Tentacruel sprite colors HOT 3
- Pixel Sprites for Hisui Balls dumped from HOME HOT 1
- [REQUEST] Origin Marks under Misc HOT 4
- shiny/decidueye-hisui same color as decidueye-hisui HOT 2
- Add Sprite for Uncloaked Burmy
- Add Generation 1/2 Icon Sprites
- 2x Single wrong pixel gen8 HOT 1
- Twinkling Star Ribbon is still missing HOT 1
- [Request] PoGo? HOT 3
- Yakkun zukan sprites HOT 2
- Add sprites from Pokemon Scarlet and Violet HOT 17
- Major updates to Pokésprite HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokesprite.