Giter Site home page Giter Site logo

dex number slug not working about pokesprite HOT 8 CLOSED

msikma avatar msikma commented on August 25, 2024
dex number slug not working

from pokesprite.

Comments (8)

msikma avatar msikma commented on August 25, 2024 1

Alright - could you try again with the latest build? I've updated to 1.5.1. I also updated the NPM package (forgot to do that for 1.5.0... oops.)

The problem was some variables weren't being protected from name mangling.

from pokesprite.

msikma avatar msikma commented on August 25, 2024

I haven't tested that in a while. To be truthful, the JS code is very old and doesn't have unit tests, but I haven't had much time to replace it. I'll see if I can fix this.

from pokesprite.

ProjectInkfish avatar ProjectInkfish commented on August 25, 2024

I was just about to ask the same question. Any luck with a fix?

from pokesprite.

msikma avatar msikma commented on August 25, 2024

Apologies for the lack of an update. I'm going to resolve this either today or tomorrow—I've got a pretty short workday today, but I'm hoping to have it resolved anyway. I'm sure the problem isn't that hard to fix.

from pokesprite.

msikma avatar msikma commented on August 25, 2024

Strangely, it seems that the Closure Compiler is somehow mangling the input JS code in such a way that it breaks using regular numbers. I'll need to look at this more closely tonight.

from pokesprite.

andreacassani avatar andreacassani commented on August 25, 2024

Working fine for me, thanks!

from pokesprite.

dominicbarnes avatar dominicbarnes commented on August 25, 2024

I'll take a look at this tonight! Thanks :)

from pokesprite.

msikma avatar msikma commented on August 25, 2024

Let me know if anything's wrong, assuming it works for now. 😊

from pokesprite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.