msilb/scalanda

Scala/Akka wrapper for Oanda REST and Stream API

scalanda's Issues

Oanda ID's moving to 64 bit

Hi,

Given the announcement to move ID's to 64 bit by Oanda - http://developer.oanda.com/rest-live/64-bit-transition/ does this have a knock on effect in that all relevant ID's now need to move from Int to Long in the response / request case classes?

Thanks

Mark

Implement support for Oanda v20 REST API

Specs: REST API v20. Only supported by new v20 type of accounts!

Technical changes:

• migrate from akka actors to Scala futures
• migrate from spray http client to dispatch
• migrate from spray-json to circe

Graceful handling of incomplete streaming line data

I've recently seen some errors in the streaming api with message
"unhandled event MessageChunk(Bytes(),) in state Disconnected"
where xxx is a number.
Looking at the earlier log messages this seems to have been caused by some invalid JSON trying to be parsed in my case it was - {"tick":{"instrumen . I'm guessing an incomplete line was sent from Oanda.

Looking at StreamingConnector.scala line 112 the statement line.parseJson.asJsObject.fields.head assumes the line is valid JSON in order to parse correctly. In the case it is not valid JSON an json exception is thrown in - spray.json.JsonParsersParsingException.

A possible work around may be to put a catch around line.parseJson.asJsObject.fields.head and return a Option[JSON] which could then be an additional case to match against.

Hope this all makes sense.