Percentage stuff not working (fix inside)

[msimerson]

Percentage stuff not working (fix inside)

[msimerson]

I think if you'll read that code more carefully, especially with the comment I just added, you'll see that no changes are necessary.

[SebastianS90]

Are you sure? I get to this for a aol.com unaligned mail (note the quarantine disposition together with p=reject, pct=100 and absence of any whitelist or other settings)

$VAR1 = bless( {
                 'disposition' => 'quarantine',
                 'published' => bless( {
                                         'rua' => 'mailto:[email protected]',
                                         'pct' => '100',
                                         'domain' => 'aol.com',
                                         'p' => 'reject',
                                         'ruf' => 'mailto:[email protected]',
                                         'v' => 'DMARC1'
                                       }, 'Mail::DMARC::Policy' ),
                 'dkim' => 'fail',
                 'spf' => 'fail',
                 'result' => 'fail'
               }, 'Mail::DMARC::Result' );

paypal.com (without pct) works as expected:

$VAR1 = bless( {
                 'disposition' => 'reject',
                 'published' => bless( {
                                         'rua' => 'mailto:[email protected]',
                                         'domain' => 'paypal.com',
                                         'p' => 'reject',
                                         'ruf' => 'mailto:[email protected],mailto:[email protected]',
                                         'v' => 'DMARC1'
                                       }, 'Mail::DMARC::Policy' ),
                 'dkim' => 'fail',
                 'spf' => 'fail',
                 'result' => 'fail'
               }, 'Mail::DMARC::Result' );

[msimerson]

Ahah. The issue is that IF block was selecting those to be sample out (hence the reason being set in it). But the sampling logic followed the IF block instead of being contained in it. So I inverted the IF condition as you suggested, set the disposition to the effective policy, and moved the reason setter down below that IF block. Check this commit instead.

[SebastianS90]

Thank you, this fix works :)

[msimerson]

Great, I just pushed a release with that in there.