msp-greg/virtual-environments

GitHub Actions virtual environments

virtual-environments's Issues

MSYS2...

@m-minasyan

Sorry for the ping, but I noticed some branches in your fork...

1. In the header for Install-MSYS2.ps1, I left the phrase '(32-bit commented out)'. At a later time, I uncommented the code to install 32 bit tools. Depending on what's decided as to including 32 build tools, that could/should be deleted.

2. Re Validate-MSYS2.ps1, please consider adding a test for pacman. If that doesn't work... EDIT: Disregrard. The install will fail if pacman doesn't work...

3. MSYS2 and system PATH - quite a mess. When using 64 bit tools, path changes are a combination of C:\msys64\mingw64\bin, C:\msys64\clang64\bin, and C:\msys64\usr\bin, 32 bit tools are C:\msys64\mingw32\bin, C:\msys64\clang32\bin, and C:\msys64\usr\bin. I would suggest leaving MSYS2 out of the system path and letting people change it in their scripts/workflows. If people reach as consensus as to adding some or all to the system PATH, it can be changed later. There's already a lot of conflicts on Windows images.

Thanks for your work on this, Greg

[Windows] Add MSYS2 ucrt packages

@miketimofeev

I updated three files (Windows 2019 only) that should install the MSYS2 ucrt packges and test them. See the commit at
2e4c70c.

You may find it helpful, I think.

I'm not familiar with the spec framework, so I didn't think I should do a PR...

I. images/win/scripts/Installers/Install-Msys2.ps1:

One change here. pacman.exe -Q can take a while. Changed to collect the output to a string, then grep on that.

II. images/win/scripts/Tests/MSYS2.Tests.ps1:

1. There were two places where Where-Object was used due to the itinerator, changed that.
2. The exe/bin path ($ExecDir) is embedded in this file for mingw64 and mingw32, so I moved to the toolset-*.json file.
3. Not sure about about the scope of ExecDir, re within the function and within the $executables object, along with its use in the specs. It may be able to be removed from $executables?

III. images/win/toolsets/toolset-2019.json:

1. As mentioned above, added exec_dir to the 'mingw' objects.
2. Added code for the ucrt packages.
3. I added two packages that a lot if Ruby CI's install, they may be common with other languages also. They are dlfcn and libyaml. You can remove them if you're not comfortable adding them, as we don't want to start a run with everyone asking for a particular package to be installed...