Comments (2)
Thanks for this very thorough bug report.
It seems I misunderstood what the API calls are doing exactly, so when setting the preset, the mode is not actually changed to auto/clock program. The first part of code that you identified is a bit of hack to make sure the HA interface updates immediately after you change the setting, before the cloud actually has time to update and inform us of the change. Here I made the mistake of changing the "zoneMode" while the API call you identified in the third snippet does not do this.
There are two options to solve this. I can either not update the mode, which matches the app does when you change the clock program while in manual mode. Or I can automatically change the mode to auto when you select a preset. Let me know what you prefer.
from remeha_home.
I've just tested back on the app, you're right, changing the program does not switch to "schedule" mode. Not sure if it's really intended though considering the other bug I reported above...
Personally, if you really ask me, I'd find convenient to have the mode changed to "auto" when you change the preset. If the integration does this, I fully rely on you ;) to do the sync of 2 consecutive changes (auto mode and preset) for me. Doing that in an automation is possible, but feels less reliable to throw 2 service calls to the same entity one after the other. It's just a personal opinion here.
I believe that this should also be documented in your install page, so people will be aware of this behaviour.
PS: I have no problem with the hack of displaying the target state before it is really synced. Other integrations do this as well, and yet others ask if you want to pre-display the target state before the sync or if you want to wait for the sync to have happened to display the target state. If the API is slow but reliable, as I expect the Remeha is, then anticipating the change with your hack should be a better option, I agree with you.
from remeha_home.
Related Issues (20)
- "List index out of range" issue? HOT 8
- Feature Requests & Suggestions HOT 8
- will De Dietrich work too? HOT 6
- integration failing to load HOT 2
- Gas consumption sensors not available HOT 4
- Water temperature not consistently updated HOT 4
- Consumption sensors BETA HOT 15
- Remeha Home not starting in 2023.11.3 HOT 13
- Remeha Home integration stops working with unknown error HOT 2
- Flaky API Responses HOT 6
- Integration can't log in HOT 18
- thermostat HOT 1
- sensor current temperature HOT 2
- "Unknown error occurred" when setting up integration HOT 9
- Feature request
- Water Temperature missing
- Hot tapwater switch HOT 2
- DeDietrich HOT 3
- Debug logging shows an entry that requests to report this HOT 1
- Stopped collecting consumption values HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from remeha_home.