mthom/prolog_parser

An operator precedence parser for Scryer Prolog, an up and coming ISO Prolog implementation.

prolog_parser's Issues

How to contribute descriptive error messages?

Let's say I get educated in what an error message really means and I want to contribute a more descriptive error message to the codebase to help future coders running into the same problem. Where would I begin?

Also, it would be amazing (but probably very difficult?) to implement error messages like Rust does.

An empty stream should not throw an error

This causes an error when hitting Ctrl+D in scryer-prolog with the error:

caught: error(syntax_error(unexpected_end_of_file),read_term/2)

I will fix this.

src/parser.rs:7:5 - error[E0432]: unresolved import `rug::ops::NegAssign`

See https://travis-ci.com/github/mthom/scryer-prolog/jobs/315547668

 Compiling prolog_parser v0.8.49
     Running `rustc --crate-name prolog_parser /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/prolog_parser-0.8.49/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C debuginfo=2 --cfg 'feature="num"' --cfg 'feature="num-rug-adapter"' -C metadata=07e9b25620cc8d14 -C extra-filename=-07e9b25620cc8d14 --out-dir /home/travis/build/mthom/scryer-prolog/target/debug/deps -L dependency=/home/travis/build/mthom/scryer-prolog/target/debug/deps --extern lexical=/home/travis/build/mthom/scryer-prolog/target/debug/deps/liblexical-c8d36ff4339b7273.rmeta --extern num_rug_adapter=/home/travis/build/mthom/scryer-prolog/target/debug/deps/libnum_rug_adapter-a91ca42a72ee10bc.rmeta --extern ordered_float=/home/travis/build/mthom/scryer-prolog/target/debug/deps/libordered_float-04e0015dbc4456cf.rmeta --extern unicode_reader=/home/travis/build/mthom/scryer-prolog/target/debug/deps/libunicode_reader-97a6913793916f3e.rmeta --cap-lints allow`
error[E0432]: unresolved import `rug::ops::NegAssign`
 --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/prolog_parser-0.8.49/src/parser.rs:7:5
  |
7 | use rug::ops::NegAssign;
  |     ^^^^^^^^^^---------
  |     |         |
  |     |         help: a similar name exists in the module: `PowAssign`
  |     no `NegAssign` in `ops`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0432`.
error: could not compile `prolog_parser`.
Caused by:
  process didn't exit successfully: `rustc --crate-name prolog_parser /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/prolog_parser-0.8.49/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C debuginfo=2 --cfg 'feature="num"' --cfg 'feature="num-rug-adapter"' -C metadata=07e9b25620cc8d14 -C extra-filename=-07e9b25620cc8d14 --out-dir /home/travis/build/mthom/scryer-prolog/target/debug/deps -L dependency=/home/travis/build/mthom/scryer-prolog/target/debug/deps --extern lexical=/home/travis/build/mthom/scryer-prolog/target/debug/deps/liblexical-c8d36ff4339b7273.rmeta --extern num_rug_adapter=/home/travis/build/mthom/scryer-prolog/target/debug/deps/libnum_rug_adapter-a91ca42a72ee10bc.rmeta --extern ordered_float=/home/travis/build/mthom/scryer-prolog/target/debug/deps/libordered_float-04e0015dbc4456cf.rmeta --extern unicode_reader=/home/travis/build/mthom/scryer-prolog/target/debug/deps/libunicode_reader-97a6913793916f3e.rmeta --cap-lints allow` (exit code: 1)
The command "cargo test --verbose --all --no-default-features --features num" exited with 101.