Comments (3)
I found this, that should help to know what makes a string parseable into pep440: https://github.com/pypa/packaging/blob/d59efa2141210447ae21c4d48813d720e0d1dbfd/packaging/version.py#L225-L254
from dunamai.
Hi! Sorry for the late response, and thanks for pointing this out. I'll definitely relax ^v(?P<base>\d+\.\d+\.\d+)
to ^v(?P<base>\d+(\.\d+)*)
, since that was an oversight. The v
prefix was a conscious decision, though, to avoid false positives from things like ticket ID-based tags, so I would consider that a backwards-incompatible change. I think the pattern should be general enough so that it doesn't need different defaults for different versioning systems, but I would be open to adding extra defaults if there's a clear need.
As a workaround, there's the possibility to pass a custom pattern if running from python:
For reference, this is also available from the command line as --pattern
.
from dunamai.
This is now fixed in 1.6.0.
from dunamai.
Related Issues (20)
- Could not properly parse with Version.parse HOT 9
- Possibly misleading vcs check message for git HOT 1
- Style is overwritten which causes validation of format regardless if user passed parameter HOT 15
- 1.16.0: pytest needs `setuptools` HOT 9
- dunamai.Version.from_git() fails if 'v' prefix not set HOT 4
- sdist is missing tests HOT 1
- Wrong version being reported HOT 9
- Bump fails for lazy clone (GitLab CI/CD) with `tag-branch = "master"` HOT 2
- dunamai 1.18.0 silently does not produce version with `--strict` in CI HOT 2
- Git version detection fails if `log.excludeDecoration = refs/tags` set in git config HOT 2
- Support getting versions from VCS at a specified directory HOT 2
- Visual Studio Code Workspace Settings file is missing ending `}` HOT 1
- calver versioning HOT 1
- Remove python dependency upper bound HOT 1
- `test__version__from_fossil` fails without home HOT 6
- bump behavior different in command line and python API HOT 4
- "RuntimeError: Unable to detect version control system" HOT 3
- Add option for detecting only changed files as dirty HOT 1
- Confusing behavior (bug?) v0.0.0 fallback code does not work if there are *any* tags in the repo HOT 1
- Inconsistent distance for non-matching tags HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dunamai.