Version.serialize for SemVer fails after update to 1.6.0

[mtkennerly]

Version.serialize for SemVer fails after update to 1.6.0

[mtkennerly]

Hi! This isn't an issue with Version.serialize, but rather is a side effect of a bug fix. Dunamai's default tag pattern previously required versions with three parts (v0.3.0), but that was an oversight, because Dunamai is meant to work also for other versioning systems like PEP 440 where 0.3 or 0.3.0.5 would be valid. So your v0.3 tag, which was previously ignored because it did not match the default pattern, is now being recognized as a version tag, so Dunamai tries to use it, but then it fails because it's invalid under Semantic Versioning (should be v0.3.0).

If you can't or don't want to change the tags, then you can pass a custom pattern to Version.from_git. This was the previous one, if you want to use it as-is:

dunamai/dunamai/__init__.py

Lines 26 to 31 in 7f62349

	_VERSION_PATTERN = r"""
	(?x) (?# ignore whitespace)
	^v(?P<base>\d+\.\d+\.\d+) (?# v1.2.3)
	(-?((?P<stage>[a-zA-Z]+)\.?(?P<revision>\d+)?))? (?# b0)
	(\+(?P<tagged_metadata>.+))?$ (?# +linux)
	""".strip()

Hi! Thank you for the quick response. Yes, I investigated the issue a little bit more, you are correct. Thank you for the clarification.