multidots/multicollab

multicollab's Issues

Incorrectly comparing isset() against strings

multicollab/admin/classes/class-commenting-block-rest-routes.php

Line 130 in f45518a

if ( 'draft' !== isset( $comment['status'] ) && 'permanent_draft' !== isset( $comment['status'] ) ) {

Since PHP's isset() function will return boolean true or false, then it's never going to match any particular string; this conditional is fundamentally flawed.

Multicolab breaks when used with plugin HTML Editor Syntax Highlighter

Hi,

I encounter error when i view the content as code with the plugin HTML Editor Syntax Highlighter.

After viewing as code and change back to normal view, upon clicking the save button, i encounter an error, and i think it's related to your plugin.

Could the meta tags be hidden?

We make quite a bit of use of custom meta fields on CSS-Tricks, and now every single post has extra meta fields that I don't really know what are for and don't really wanna see:

(The quote is ours, the other two are not.)

Can't internally-used meta fields start with an underscore or something so authors don't need to see them?

Comments Panel always visible

Hi,

First: great plugin! I hope this functionality will be in core one time.

I have version 1.0.1 installed and always see the Comments Panel even when there are no comments or the comment panel is not active.

I don't see this behaver in the demo but on two of my live sites and on my test site.

Rename repo to `gutenberg-commenting` (replace underscore)

Makes it look less hacky.

Breaks all non-WP Gutenberg blocks

The latest version of the plugin (3.7) breaks all non-WP Gutenberg blocks. Attaching a video recreation below:

https://share.cleanshot.com/DK2MT573ww1fjGPPBH0G

Everything works fine on version 3.6. Please let me know if I can do anything to help out 👍

Error when accessing widget.php and edit reusable_block

Hi,

I encounter this error message when i try to access wp-admin/widgets.php and edit any reusable block.

The error copied is :

TypeError: Cannot read properties of undefined (reading '_sb_is_suggestion_mode')
    at new o (https://test.local/wp-content/plugins/commenting-feature/admin/assets/js/dist/activityCentre.build.min.js?ver=3432532089:21:132338)
    at Yg (https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:68:243)
    at rh (https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:98:274)
    at zj (https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:228:490)
    at Th (https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:152:223)
    at tj (https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:152:152)
    at Te (https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:146:151)
    at https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:61:68
    at unstable_runWithPriority (https://test.local/wp-includes/js/dist/vendor/react.min.js?ver=16.13.1:25:260)
    at Da (https://test.local/wp-includes/js/dist/vendor/react-dom.min.js?ver=16.13.1:60:280)

WP-CLI plugin activation breaks due to redirect

When activating all plugins on a site using wp-cli, the process breaks after activating multicollab due to a redirect. The remainder of the plugins do not get activated due to this issue.

Plugin 'xxx' activated. Warning: Some code is trying to do a URL redirect. Backtrace: #0 WP_CLI\Utils\wp_redirect_handler(http://[domain.com]/wp-admin/admin.php?activated=1&page=editorial-comments) called at [/path/to/core/wp-includes/class-wp-hook.php:305]

Warning when accessing roles property for non-existing users

The following line generates Attempt to read property "roles" on bool warnings in some scenarios:

multicollab/admin/classes/class-commenting-block-rest-routes.php

Line 178 in 58cf1c3

'defaultUserRole' => $Defaultusers->roles[0],

This could happen if the value from the post_author field is 0 or the author doesn't exist.
In those cases, the call to get_userdata() will return false:

multicollab/admin/classes/class-commenting-block-rest-routes.php

Line 162 in 58cf1c3

$Defaultusers = get_userdata( $author_id );

Can't use the Enter Key to add a new paragraph

Hi,

I can't use the Enter Key to add a new paragraph/block inside the Block Editor if the Plugin is enabled.

permission_callback for register_rest_route missing

Since WordPress version 5.5 a permission_callback is needed for register_rest_route. I think the endpoint should only available logged in.

( ! ) Notice: register_rest_route was called <strong>incorrectly</strong>. The REST API route definition for <code>cf/cf-get-comments-api</code> is missing the required <code>permission_callback</code> argument. For REST API routes that are intended to be public, use <code>__return_true</code> as the permission callback. Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 5.5.0.) in /wp-includes/functions.php on line 5311

class-commenting-block-public.php: enqueues assets with double slash, causes redirects

https://developer.wordpress.org/reference/functions/plugin_dir_url/ uses trailingslashit().

multicollab/public/class-commenting-block-public.php

Line 80 in 23b1633

wp_enqueue_style($this->plugin_name, COMMENTING_BLOCK_URL . '/public/css/commenting-block-public.css', array(), $this->version, 'all');

and

multicollab/public/class-commenting-block-public.php

Line 103 in 23b1633

wp_enqueue_script($this->plugin_name, COMMENTING_BLOCK_URL . '/public/js/commenting-block-public.js', array( 'jquery' ), $this->version, false);

should not add another slash behind COMMENTING_BLOCK_URL.

URL cleanse redirect like below will trip on this mistake

# BEGIN Eliminate double slashes
<IfModule mod_rewrite.c>
  RewriteEngine On
  RewriteCond %{THE_REQUEST} //
  RewriteRule ^.*$ $0 [R=302,L,NE]
</IfModule>
# END Eliminate double slashes

Source: https://stackoverflow.com/q/31933042/35946

Show icon in the main toolbar instead of under the dropdown

Hi,
I'm not using the plugin (or Wordpress) but you might be interested in moving the button to a more accessible place in the editor toolbar, using BlockControls instead of RichTextToolbarButton.

See in particular the commit referenced at WordPress/gutenberg#14881 (comment)

Block editor has encountered an unexpected error

As a user with administrator role I get following error when I open edit page screen.

Plugin version: 88c4c00
but it failed as well in regular 1.3.3

TypeError: this.activateMode is not a function
    at https://example.com/wp-includes/js/media-views.min.js?ver=5.7.1:2:24653
    at bs (https://example.com/wp-content/plugins/commenting-feature.git/admin/assets/js/dist/block.build.min.js?ver=3411895896:45:4724)
    at Function.Xr (https://example.com/wp-content/plugins/commenting-feature.git/admin/assets/js/dist/block.build.min.js?ver=3411895896:45:39314)
    at n._createModes (https://example.com/wp-includes/js/media-views.min.js?ver=5.7.1:2:24613)
    at n.initialize (https://example.com/wp-includes/js/media-views.min.js?ver=5.7.1:2:24022)
    at n.initialize (https://example.com/wp-includes/js/media-views.min.js?ver=5.7.1:2:25673)
    at n.initialize (https://example.com/wp-includes/js/media-views.min.js?ver=5.7.1:2:29540)
    at n.h.View (https://example.com/wp-includes/js/backbone.min.js?ver=1.4.0:2:14140)
    at n.constructor (https://example.com/wp-includes/js/wp-backbone.min.js?ver=5.7.1:2:2600)
    at n.constructor (https://example.com/wp-includes/js/media-views.min.js?ver=5.7.1:2:23469)

Additional log:

12:09:26.824 The above error occurred in the <MediaUpload> component:
    in MediaUpload (created by WithFilters(MediaUpload))
    in WithFilters(MediaUpload) (created by PostFeaturedImage)
    in MediaUploadCheck (created by PostFeaturedImage)
    in div (created by PostFeaturedImage)
    in PostTypeSupportCheck
    in Unknown (created by WithSelect(PostTypeSupportCheck))
    in WithSelect(PostTypeSupportCheck) (created by PostFeaturedImageCheck)
    in ThemeSupportCheck
    in Unknown (created by WithSelect(ThemeSupportCheck))
    in WithSelect(ThemeSupportCheck) (created by PostFeaturedImageCheck)
    in PostFeaturedImageCheck (created by PostFeaturedImage)
    in PostFeaturedImage (created by WithFilters(PostFeaturedImage))
    in WithFilters(PostFeaturedImage) (created by WithDispatch(WithFilters(PostFeaturedImage)))
    in WithDispatch(WithFilters(PostFeaturedImage))
    in Unknown (created by WithSelect(WithDispatch(WithFilters(PostFeaturedImage))))
    in WithSelect(WithDispatch(WithFilters(PostFeaturedImage))) (created by (WithSelect(WithDispatch(WithFilters(PostFeaturedImage)))))
    in (WithSelect(WithDispatch(WithFilters(PostFeaturedImage)))) (created by FeaturedImage)
    in div (created by PanelBody)
    in PanelBody (created by FeaturedImage)
    in PostTypeSupportCheck
    in Unknown (created by WithSelect(PostTypeSupportCheck))
    in WithSelect(PostTypeSupportCheck) (created by PostFeaturedImageCheck)
    in ThemeSupportCheck
    in Unknown (created by WithSelect(ThemeSupportCheck))
    in WithSelect(ThemeSupportCheck) (created by PostFeaturedImageCheck)
    in PostFeaturedImageCheck (created by FeaturedImage)
    in FeaturedImage (created by WithDispatch(FeaturedImage))
    in WithDispatch(FeaturedImage)
    in Unknown (created by WithSelect(WithDispatch(FeaturedImage)))
    in WithSelect(WithDispatch(FeaturedImage)) (created by SettingsSidebar)
    in div (created by ForwardRef(Panel))
    in ForwardRef(Panel) (created by ComplementaryArea)
    in div (created by ComplementaryAreaFill)
    in SlotComponent (created by Context.Consumer)
    in Slot (created by slot_fill_Slot)
    in slot_fill_Slot (created by ComplementaryAreaSlot)
    in ComplementaryAreaSlot (created by Layout)
    in div (created by ForwardRef(InterfaceSkeleton))
    in div (created by ForwardRef(InterfaceSkeleton))
    in div (created by ForwardRef(InterfaceSkeleton))
    in div (created by ForwardRef(InterfaceSkeleton))
    in ForwardRef(InterfaceSkeleton) (created by Layout)
    in Layout (created by Editor)
    in ErrorBoundary (created by Editor)
    in BlockEditorProvider
    in Unknown (created by Context.Consumer)
    in WithRegistryProvider(BlockEditorProvider) (created by EditorProvider)
    in BlockContextProvider (created by EditorProvider)
    in EntityProvider (created by EditorProvider)
    in EntityProvider (created by EditorProvider)
    in EditorProvider
    in Unknown (created by Context.Consumer)
    in WithRegistryProvider(EditorProvider) (created by Editor)
    in DropZoneContextProvider (created by Editor)
    in slot_fill_provider_SlotFillProvider (created by SlotFillProvider)
    in SlotFillProvider (created by Editor)
    in StrictMode (created by Editor)
    in Editor
React will try to recreate this component tree from scratch using the error boundary you provided, ErrorBoundary. commenting-block-admin.js:961:31