mustafaberkaymutlu/uv-index

This is a work-in-progress (🔧️) ultraviolet index viewer app for demonstrating Instant Apps + Kotlin + Dagger + MVP

uv-index's Issues

multiple <android:name=""> for instant app

Hi I have been looking at how you have structured you instant app for dagger2.

I have a question about using dagger2 for multiple features, in your example you have
a feature module called 'query'. In the manifest file for that feature you have the following:
android:name=".QueryApplication"
in tag.

What happens if you have another feature module, is it possible to add dagger2 to the new feature module?

When I try setting "android:name=.SecondFeatureModule" in the new feature module manifest file, I get a compilation error saying AndroidManifest.xml file cannot have duplicate attributes i.e 'android:name=' is being added twice

Do you have any suggestions for resolving this?
Or does your example only work if you have 1 feature module for instant app?
Would you need to setup dagger2 differently if you had multiple feature modules?

Resources not found

I've been researching why Android Studio gives the following error "resource integer / google_play_services_version not found" when the Google Play Services library is added in the "query" module. It also happens to me with more liberies. In particular with the FacebookSdk, the error that gives me is the following "resource style / com_facebook_activity_theme not found" Does anyone know why? Thank you