mustaphatr/generals-alpha

Generals Alpha is an OpenRA mod that recreates Command & Conquer: Generals on OpenRA engine as much as possible but using Red Alert and Tiberian Dawn artworks.

generals-alpha's Issues

GrantConditionOnProduction seems not to be caps sensitive.

Mod will not build: GeoLite2-Country.mmdb.gz cannot be downloaded anymore

Hi,

This mod currently fails to build with the error:

Version changed to 1160.git.e448241.
OpenRA engine version gen-20190202 is required.
Downloading engine...
Compiling engine...
make[1]: Entering directory '/data/AUR/openra-gen-git/src/Generals-Alpha/generals-alpha-engine'
make[1]: Leaving directory '/data/AUR/openra-gen-git/src/Generals-Alpha/generals-alpha-engine'
make[1]: Entering directory '/data/AUR/openra-gen-git/src/Generals-Alpha/generals-alpha-engine'
Fetching StyleCopPlus from NuGet
Fetching StyleCop files from NuGet
Fetching ICSharpCode.SharpZipLib from NuGet
Fetching MaxMind.Db from NuGet
Fetching SharpFont from NuGet
Fetching NUnit from NuGet
Fetching NUnit.Console from NuGet
Fetching Open.Nat from NuGet
Fetching FuzzyLogicLibrary from NuGet.
Fetching SDL2-CS from GitHub.
Fetching OpenAL-CS from GitHub.
Fetching Eluant from GitHub.
Fetching rix0rrr.BeaconLib from NuGet.
Updating GeoIP country database from MaxMind.
make[1]: *** [Makefile:319: geoip-dependencies] Error 6
make[1]: Leaving directory '/data/AUR/openra-gen-git/src/Generals-Alpha/generals-alpha-engine'
make: *** [Makefile:52: engine] Error 2

Thanks for your time

Sneak Attack can be placed Anywhere

SpawnActorPower ignores the placement rules:

OpenRA.Mods.Common/Traits/Repairable.cs(39,18): error CS0414: Warning as Error: The private field `OpenRA.Mods.Common.Traits.Repairable.movement' is assigned but its value is never used

Hi,

I know you're getting Travis errors with this error message, but in case you're wondering whether this is an error without consequence on Linux, it isn't. It is causing build errors and I simply cannot use these latest commits at all.

Here is the precise output from running make with commit 1138 (3f7ad30):

OpenRA engine version gen-20190121 is required.
Downloading engine...
Compiling engine...
make[1]: Entering directory '/data/GitHub/others/Generals-Alpha/generals-alpha-engine'
make[1]: Leaving directory '/data/GitHub/others/Generals-Alpha/generals-alpha-engine'
make[1]: Entering directory '/data/GitHub/others/Generals-Alpha/generals-alpha-engine'
Fetching StyleCopPlus from NuGet
Fetching StyleCop files from NuGet
Fetching ICSharpCode.SharpZipLib from NuGet
Fetching MaxMind.Db from NuGet
Fetching SharpFont from NuGet
Fetching NUnit from NuGet
Fetching NUnit.Console from NuGet
Fetching Open.Nat from NuGet
Fetching FuzzyLogicLibrary from NuGet.
Fetching SDL2-CS from GitHub.
Fetching OpenAL-CS from GitHub.
Fetching Eluant from GitHub.
Fetching rix0rrr.BeaconLib from NuGet.
Updating GeoIP country database from MaxMind.
Detected Lua 5.1 library at /lib/liblua.so.5.1.5
Eluant.dll.config has been created successfully.
CSC fixheader.exe
CSC OpenRA.Game.exe
CSC OpenRA.Platforms.Default.dll
CSC mods/common/OpenRA.Mods.Common.dll
OpenRA.Mods.Common/Traits/Repairable.cs(39,18): error CS0414: Warning as Error: The private field `OpenRA.Mods.Common.Traits.Repairable.movement' is assigned but its value is never used
Compilation failed: 1 error(s), 0 warnings
make[1]: *** [Makefile:280: mods/common/OpenRA.Mods.Common.dll] Error 1
make[1]: Leaving directory '/data/GitHub/others/Generals-Alpha/generals-alpha-engine'
make: *** [Makefile:52: engine] Error 2

I hope I do not come across as hectoring you, if you're working on this already please feel free to ignore this bug report, I just wish to inform you it is not a Travis failure without consequence on users.

Thanks for your time,
Brenton

Game becomes uplayably laggy after all resources are depleted

I need to find a solution to that. I think it is because AI trying to find ore and failing constantly.

Error 6 when Updating GeoIP country database

I've been trying to build Generals-Alpha on a Linux system for a while now and it always seems to stop at the point where it is trying to update the GeoIP country database. Every time I try it game me the following error.
$ make
make[1]: Entering directory '/home/SteamsDev/generals-alpha/Generals-Alpha/generals-alpha-engine'
Updating GeoIP country database from MaxMind.
make[1]: *** [Makefile:319: geoip-dependencies] Error 6
make[1]: Leaving directory '/home/SteamsDev/generals-alpha/Generals-Alpha/generals-alpha-engine'
make: *** [Makefile:52: engine] Error 2

Any help is appreciated. I have a Debian system.

Game crashes upon startup.

i installed with the .exe from releases. But the game crashes upon startup.

The GeneralsAlpha-gen-20190128_3 Works for me i had.

i have _3 installed right now. Let me know if you want me to try the latest from march again.

PS: i love the game it's so fun.

error CS0414: Warning as Error: The private field `OpenRA.Mods.Common.Activities.EnterSharedTransport.maxTries' is assigned but its value is never used

Hi,

I managed to try to build early commits of this repository fine on openSUSE Tumbleweed, but the latest one fails with the error:

OpenRA.Mods.Common/Activities/EnterSharedTransport.cs(21,16): error CS0414: Warning as Error: The private field `OpenRA.Mods.Common.Activities.EnterSharedTransport.maxTries' is assigned but its value is never used

some of the previous lines of output were:

Detected Lua 5.1 library at /usr/lib64/liblua5.1.so.5.1
Eluant.dll.config has been created successfully.
CSC fixheader.exe
CSC OpenRA.Game.exe
CSC OpenRA.Platforms.Default.dll
CSC mods/common/OpenRA.Mods.Common.dll

running make clean also returned this error.

Thanks for your time,
Brenton

Linux Release?

why there is a windows release but not linux

USA SpySat Timer too short

I don't know if you noticed already, but the SpySat timer for USA is way too short. For me the cooldown timer is 7 seconds. Could you possibly fix that so it's not spammed all the time? Thanks!

USA Intelligence affects other players

I've encountered a bug related to USA: I was doing a game as USA against another USA and a PRC, and I found out that the AI USA's Intelligence still had an effect on me even though he was an enemy. Because of that I could see the entire PRC base without needing my Intelligence. I figured maybe that wasn't intended.

As you can see my intelligence still had 11 seconds left to recharge, and yet I had a similar experience to the Intelligence by being able to see the entire PRC base.

OpenRA has encountered a fatal error

Hey there!

I am not sure if you are still working on this or not but I got the following error when I was trying to launch the game:

Platform is Windows (X64)
Engine version is 725f926b29e4b80b5572431c86c5a4e8f6c87a26
Runtime: .NET CLR 6.0.25
Renderer initialization failed. Check graphics.log for details.
Renderer initialization failed. Check graphics.log for details.
Exception of type System.InvalidOperationException: Failed to initialize platform-integration library. Check graphics.log for details.
at OpenRA.Game.Initialize(Arguments args) in C:\Users\cosmi\Desktop\Generals-Alpha-master\engine\OpenRA.Game\Game.cs:line 358
at OpenRA.Game.InitializeAndRun(String[] args) in C:\Users\cosmi\Desktop\Generals-Alpha-master\engine\OpenRA.Game\Game.cs:line 301
at OpenRA.Launcher.Program.Main(String[] args) in C:\Users\cosmi\Desktop\Generals-Alpha-master\engine\OpenRA.Launcher\Program.cs:line 32

---

OpenRA has encountered a fatal error.

• Log Files are available in Documents\OpenRA\Logs
• FAQ is available at https://github.com/OpenRA/OpenRA/wiki/FAQ
  Thank you!

Crash related to ParallelBuild Queue

Happens pretty often, so this needs to be solved.

OpenRA engine version gen-20171003
Generals Alpha mod version gen-20171003
on map 316b6cf61b70824d295dc89667f08530d9953d3d (Vegetation by hamb/Chris Forbes).
Date: 2017-10-06 12:39:48Z
Operating System: Windows (Microsoft Windows NT 6.1.7601 Service Pack 1)
Runtime Version: .NET CLR 4.0.30319.42000
Exception of type `System.IndexOutOfRangeException`: Dizin, dizi sınırlarının dışındaydı.
   konum: OpenRA.Mods.Common.Graphics.DefaultSpriteSequence.GetSprite(Int32 start, Int32 frame, Int32 facing) h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Mods.Common\Graphics\DefaultSpriteSequence.cs içinde: satır 307
   konum: OpenRA.Mods.Common.Graphics.DefaultSpriteSequence.GetSprite(Int32 frame, Int32 facing) h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Mods.Common\Graphics\DefaultSpriteSequence.cs içinde: satır 287
   konum: OpenRA.Graphics.Animation.get_Image() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Graphics\Animation.cs içinde: satır 53
   konum: OpenRA.Mods.Common.Widgets.ProductionPaletteWidget.Draw() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Mods.Common\Widgets\ProductionPaletteWidget.cs içinde: satır 407
   konum: OpenRA.Widgets.Widget.DrawOuter() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 473
   konum: OpenRA.Widgets.Widget.DrawOuter() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 475
   konum: OpenRA.Widgets.Widget.DrawOuter() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 475
   konum: OpenRA.Widgets.Widget.DrawOuter() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 475
   konum: OpenRA.Widgets.Widget.DrawOuter() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 475
   konum: OpenRA.Widgets.Widget.DrawOuter() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 475
   konum: OpenRA.Widgets.Widget.DrawOuter() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 475
   konum: OpenRA.Widgets.Ui.Draw() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Widgets\Widget.cs içinde: satır 92
   konum: OpenRA.Game.RenderTick() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Game.cs içinde: satır 657
   konum: OpenRA.Game.Loop() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Game.cs içinde: satır 777
   konum: OpenRA.Game.Run() h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Game.cs içinde: satır 795
   konum: OpenRA.Program.Run(String[] args) h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Support\Program.cs içinde: satır 136
   konum: OpenRA.Program.Main(String[] args) h:\OpenRA\Generals Alpha\generals-alpha-engine\OpenRA.Game\Support\Program.cs içinde: satır 40

Here comes the crash

At 8d630b3

A crash related to SharedCargo, using deploy order.

OpenRA engine version 286e100caa3de0374682717625982ec0c21fdeec
OpenRA Language: en
Generals Alpha mod version gen-20230705
on map b3cb982f715e98b4183a7ce7505fee21a506d44a (Burning Plain by james.bong).
Date: 2023-09-07 13:58:53Z
Operating System: Windows (X64, Microsoft Windows NT 10.0.19045.0)
Runtime Version: .NET CLR 6.0.11
Installed Language: zh (Installed) zh (Current) zh (Current UI)
Exception of type `System.ArgumentException`: An item with the same key has already been added. Key: vehicle.quad_cannon 3736
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at OpenRA.Mods.Common.Traits.GivesBounty.OpenRA.Mods.Common.Traits.INotifyPassengerEntered.OnPassengerEntered(Actor self, Actor passenger) in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Mods.Common\Traits\GivesBounty.cs:line 87
   at OpenRA.Mods.AS.Traits.SharedCargo.Load(Actor self, Actor a) in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Mods.AS\Traits\SharedCargo.cs:line 330
   at OpenRA.Mods.AS.Activities.RideSharedTransport.<>c__DisplayClass6_0.<OnEnterComplete>b__0(World w) in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Mods.AS\Activities\RideSharedTransport.cs:line 69
   at OpenRA.World.Tick() in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Game\World.cs:line 453
   at OpenRA.Game.InnerLogicTick(OrderManager orderManager) in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Game\Game.cs:line 631
   at OpenRA.Game.LogicTick() in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Game\Game.cs:line 646
   at OpenRA.Game.Loop() in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Game\Game.cs:line 815
   at OpenRA.Game.Run() in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Game\Game.cs:line 868
   at OpenRA.Game.InitializeAndRun(String[] args) in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Game\Game.cs:line 305
   at OpenRA.Launcher.Program.Main(String[] args) in D:\work\Projects\Github\Generals-Alpha\engine\OpenRA.Launcher\Program.cs:line 32

replay.zip

Update:

In short:

vehicle.quad_cannon 3736, produced at 57184 ticks, at cyan color player, Stealth General.

building.tunnel_network 3810->SharedCargo: It is Loaded at: 58394, it is in world? True
building.tunnel_network 3810->GivesBounty: It is loaded in: 58394
building.tunnel_network.no_free_actor 3842->SharedCargo: INotifyEnteredSharedCargo initialized: 58431, it is in world? False
building.tunnel_network.no_free_actor 3842->GivesBounty: It is loaded in: 58431
building.tunnel_network 3810->SharedCargo: It is Unloaded at: 60595, it is in world? False
building.tunnel_network 3810->GivesBounty: It is unloaded at: 60595
building.tunnel_network.no_free_actor 3842->SharedCargo: It is Loaded at: 61005, it is in world? True
building.tunnel_network.no_free_actor 3842->GivesBounty: It is loaded in: 61005

Building like in Generals and offer rockets AA and AT different. Also tanks have machineguns

Thank you! Interesting game already. Some ideas
What also is good to have, more realism:

1. Building like in Generals or RA3 Soviet/Jap - for enemy visible what is building. OpenKrush on openra did it. Also Jap did in Fractured Realms on openra. This is big issue for other C&C games
2. Generals End of Days mod offer rockets AA and AT different. Also tanks have machineguns and ok vs infantry

make test fails on openSUSE Tumbleweed: Actor type `vehicle.combat_cycle` consumes conditions that are not granted: driver_killed

Hi,

On openSUSE Tumbleweed I've noticed that while Generals builds fine, make test fails with the errors

[  122s] Testing map: X-Lake
[  122s] Testing map: Ysmir
[  122s] Testing map: Desert Shellmap
[  128s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle` consumes conditions that are not granted: driver_killed
[  128s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle.demo` consumes conditions that are not granted: driver_killed
[  130s] Testing map: 01: The Dragon Awakes (WIP)
[  136s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle` consumes conditions that are not granted: driver_killed
[  136s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle.demo` consumes conditions that are not granted: driver_killed
[  139s] Testing map: Snow Shellmap
[  144s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle` consumes conditions that are not granted: driver_killed
[  144s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle.demo` consumes conditions that are not granted: driver_killed
[  147s] Testing map: Temperate Shellmap
[  152s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle` consumes conditions that are not granted: driver_killed
[  152s] OpenRA.Utility(1,1): Error: Actor type `vehicle.combat_cycle.demo` consumes conditions that are not granted: driver_killed
[  155s] Errors: 26
[  156s] make: *** [Makefile:101: test] Error 1

(ignore the [ (number)s] it pertains to the Open Build Service I'm using to build this). This issue was introduced in commit 27499a9, earlier commits didn't have this problem. I see your Travis CI build is failing too, presumably for the same reasons.

Thanks for your time and this mighty fine mod,
Brenton

Make on macOS failes

when I try to run make on my mac I get this error:
Raz-MACLP:Generals-Alpha raz$ make
/bin/sh: ./fetch-engine.sh: Permission denied
Unable to continue without engine files
make: *** [engine] Error 1
Raz-MACLP:Generals-Alpha raz$ chmod 777 . -R
Raz-MACLP:Generals-Alpha raz$ make
OpenRA engine version gen-20170925 is required.
Downloading engine...
Compiling engine...
Fetching StyleCopPlus from NuGet
Fetching StyleCop files from NuGet
Fetching ICSharpCode.SharpZipLib from NuGet
Fetching MaxMind.Db from NuGet
Fetching SharpFont from NuGet
Fetching NUnit from NuGet
Fetching NUnit.Console from NuGet
Fetching Open.Nat from NuGet
mv: cannot move 'Open.NAT' to a subdirectory of itself, 'Open.Nat/Open.NAT'
make[1]: *** [cli-dependencies] Error 1
make: *** [engine] Error 2

can you assist?

Supplytruck stuck

test, it is not the problem of MoveBackwards setting

Music will not download

Hi

I tried using the content manager to download the generals music and it errors out and will not download, could this be fixed??

Thanks