mwpowellhtx/code.generation.roslyn

dotnet Code Generation using the Roslyn API.

code.generation.roslyn's Issues

Reconsider how the Generated Code occurs

We are more or less a third, perhaps one half, of the way there, we think. Consider instead of invoking a code generation asynchronously, that the service yields to a reactive, observable collection of CompilationUnitSyntax elements. Upon each element being generated, that is when we would do such things as write the generated code to file, register said generated code with the internal registries for bookkeeping, and so on.

Discovered a version bumping issue with multi-targeting

The Bump Assembly Version action is apparently invoked for every target in the build. If there is one target, it happens one time only. If there are more than one targets, i.e. a multi-target, then is apparently occurs asynchronously, and we may see +N, or +N-1, depending on which target resolved last, either of which is incorrect for increment versions. Should be +1.

Correct a typo in the Microsoft.CodeAnalysis.CSharp package dependency version

Was referencing a non existing MicrosoftCodeAnalysisCSharp property, whereas should have been MicrosoftCodeAnalysisCSharpVersion. This yields much better results.

Duplicated class generated

Hi, I've followed the tutorial for building a generator and in the project that I use the CodeGeneration the class Bar was duplicated.

As you can see I just pressed F12 on Bar, and it shoes 2 class, one from my file Bar.cs, and another from the generated one.

The Bar class

using Alberto.FastMap.CodeGen;

namespace Alberto.TheApp
{
    [ImplementCloneableInterface]
    public class Bar
    {
    }
}

I've used same classes that you showed in readme tutorial ImplementCloneableInterfaceAttribute and ImplementCloneableInterfaceGenerator

Thats my CodeGen project csproj

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.1</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Code.Generation.Roslyn" Version="1.2.0.20972" />
  </ItemGroup>

</Project>

And that is my Client app that uses the CodeGen

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp2.1</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Code.Generation.Roslyn.BuildTime" Version="1.2.0.20971" PrivateAssets="all"/>
    <DotNetCliToolReference Include="dotnet-cgr" Version="[1,2)" />
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\Alberto.FastMap.CodeGen\Alberto.FastMap.CodeGen.csproj" />
  </ItemGroup>

</Project>