mxaddict/mmaker

MMaker is a Market Making trading bot

mmaker's Issues

Running Two Instances

Freaking great job with the bot mate, it's wonderful. I was wondering if there was a way to run multiple instances of the bot without having to create separate VMs. Are there some "good practices" tips you can share? Thanks :)

Other Exchanges

Hello,
Many thanks for the efforts you have devoted to this bot. Currently, only bitfinex is supported. Are you able to add more exchanges?

TypeError

On running the bot, am getting this error> the definition of the function "privatePostPositions" is missing
[TypeError] this.exchange.privatePostPositions is not a function
Kindly rectify.

[Error] NaN: Invalid Number

First of all, awesome work on the bot! This is probably going to annoy you, as I've read that you were thinking of refactoring the bot from scratch, but I really need this issue fixed soon.

Although the exchange hasn't been merged with the main branch, its passed all checks and seems to work fine. You can see the bitmax (not to be confused with bitmex 😅) js file here.

First problem I ran into was the getting the orderbook depth. I thought I solved that problem by replacing the respective line to: let orderbook = await this.exchange.publicGetDepth({'symbol': this.market})

I keep getting the following error:

`/6/2019 7:01:16 PM | /BTC
9/6/2019 7:01:16 PM | 1000 // some personal debugging (this.orderSize)
9/6/2019 7:01:16 PM | undefined (price, this.price, this.adjustOrderSize(price) all gives undefined)
9/6/2019 7:01:16 PM | [Error] NaN: invalid number (contains an illegal character 'N')

                      at decimalToPrecision  ccxt/js/base/functions/number.js:177  throw new Error (`${str}: invalid number (contains an illegal character '${str[…
                      at priceToPrecision    ccxt/js/base/Exchange.js:1308         return decimalToPrecision (price, ROUND, this.markets[symbol].precision.price, …
                      at createOrder         ccxt/js/bitmax.js:456                 'orderPrice': this.priceToPrecision (symbol, price),                            
                      at _tickCallback       internal/process/next_tick.js:68`

Any idea what might be causing this and a quick fix? I'm willing to give you a little gift for your time.

Invalidorder bitmex orderQty is invalid http error

Got bitmex connected, but keep receiving the repeating error below:

`oor@toor-VirtualBox:~/mmaker$ ./mmaker.js
8/26/2019 6:51:23 AM | COLORS ENABLED
8/26/2019 6:51:23 AM | Using Exchange "bitmex"
8/26/2019 6:51:25 AM | Using Market "BTC/USD"
8/26/2019 6:51:26 AM | price bid/ask/spread % | asset balance start/current | currency start/current | asset p/l value/% | currency p/l value/% | overall p/l % | orders size/buy/sell
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
USD +10,337/+10,337.50/+00.005% | BTC +0.03016809/+0.03016809 | USD 0/+311.85 | BTC 0/00.000% | USD +311.85/Infinity% | BTC/USD Infinity% | BTC 0/0/0
8/26/2019 6:51:26 AM | [InvalidOrder] bitmex {"error":{"message":"orderQty is invalid","name":"HTTPError"}}

                       at handleErrors   ccxt/js/bitmex.js:1233            throw new exact[message] (feedback);                                            
                       at then           ccxt/js/base/Exchange.js:628      this.handleErrors (response.status, response.statusText, url, method, responseH…
                       at _tickCallback  internal/process/next_tick.js:68           

how to change the exchange for the algo?

You mentioned in the readme how binance is currently default, but any exchange within CCXT can be connected.

Do you have any instruction on that change within your code?

Looking to connect Bitmex.

Sorry if noob question. Just need direction as to where to start, and I'll be off to the races.

Thanks!

@mxaddict