mybatis/parent

The MyBatis parent POM which has to be inherited by all MyBatis modules

parent's Issues

Jacoco Issue

@emacarron I wasn't sure what the removal was for during release. Can you list the issue here so we can track it?

Invalid value passed to m-enforcer-p rule "requireJavaVersion"

Only version ranges according to https://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html and https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html are supported but currently just a comma separated list of major versions are passed in

parent/pom.xml

Line 612 in fcf4376

<version>${allowed.build.jdks}</version>

.

Although this works for requiring a lower bound (more or less by incident, for details refer to eclipse-m2e/m2e-core#1120) it doesn't work for enforcing the upper bound properly. Also it won't accept version "11" but only a minor version above 0!
This value must either be a single version (for just requiring a minimum version) or a range starting with either ( or [.

Set the site logo on the site.xml descriptor

Generated sites actually still point to old logo - it would be more canonical pointing to a Gravatar link, such as https://secure.gravatar.com/avatar/f6383f37362f18524a1d180f0fd9b1bd?s=150

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

github-actions

.github/workflows/ci.yaml

• actions/checkout v4
• actions/setup-java v4

.github/workflows/site.yaml

• actions/checkout v4
• actions/setup-java v4
• JamesIves/github-pages-deploy-action v4

.github/workflows/sonar.yaml

• actions/checkout v4
• actions/setup-java v4

.github/workflows/sonatype.yaml

• actions/checkout v4
• actions/setup-java v4

maven

pom.xml

• com.github.hazendaz.maven:whitespace-maven-plugin 1.3.2
• com.github.ekryd.sortpom:sortpom-maven-plugin 4.0.0
• io.github.git-commit-id:git-commit-id-maven-plugin 9.0.1
• com.github.spotbugs:spotbugs-maven-plugin 4.8.6.2
• com.mycila:license-maven-plugin 4.5
• com.mycila:license-maven-plugin-git 4.5
• com.github.hazendaz.maven:coveralls-maven-plugin 4.5.0-M3
• net.revelc.code:impsort-maven-plugin 1.11.0
• net.revelc.code.formatter:formatter-maven-plugin 2.24.1
• com.github.hazendaz:build-tools 1.3.1
• biz.aQute.bnd:bnd-maven-plugin 7.0.0
• biz.aQute.bnd:biz.aQute.bndlib 7.0.0
• org.apache.maven.plugins:maven-antrun-plugin 3.1.0
• org.apache.maven.plugins:maven-assembly-plugin 3.7.1
• org.mybatis:base-bundle-descriptor 11
• org.apache.maven.plugins:maven-checkstyle-plugin 3.4.0
• org.apache.maven.plugins:maven-clean-plugin 3.4.0
• org.apache.maven.plugins:maven-compiler-plugin 3.13.0
• org.apache.maven.plugins:maven-dependency-plugin 3.7.1
• org.apache.maven.plugins:maven-deploy-plugin 3.1.2
• org.apache.maven.plugins:maven-enforcer-plugin 3.5.0
• org.codehaus.mojo:extra-enforcer-rules 1.8.0
• org.apache.maven.plugins:maven-gpg-plugin 3.2.4
• org.apache.maven.plugins:maven-install-plugin 3.1.2
• org.apache.maven.plugins:maven-jar-plugin 3.4.2
• org.apache.maven.plugins:maven-javadoc-plugin 3.8.0
• org.apache.maven.plugins:maven-jxr-plugin 3.4.0
• org.apache.maven.plugins:maven-pdf-plugin 1.6.1
• org.apache.maven.plugins:maven-pmd-plugin 3.24.0
• org.sonarsource.scanner.maven:sonar-maven-plugin 4.0.0.4121
• org.apache.maven.plugins:maven-project-info-reports-plugin 3.6.2
• org.apache.maven.plugins:maven-release-plugin 3.1.1
• org.apache.maven.plugins:maven-resources-plugin 3.3.1
• org.apache.maven.plugins:maven-scm-publish-plugin 3.3.0
• org.apache.maven.plugins:maven-shade-plugin 3.6.0
• org.apache.maven.plugins:maven-site-plugin 4.0.0-M16
• org.apache.maven.skins:maven-fluido-skin 2.0.0-M9
• org.apache.maven.plugins:maven-source-plugin 3.3.1
• org.apache.maven.plugins:maven-surefire-plugin 3.3.1
• org.apache.maven.plugins:maven-surefire-report-plugin 3.3.1
• org.jacoco:jacoco-maven-plugin 0.8.12
• org.codehaus.mojo:clirr-maven-plugin 2.8
• org.apache.bcel:bcel 6.9.0
• org.codehaus.mojo:taglist-maven-plugin 3.1.0
• org.codehaus.mojo:versions-maven-plugin 2.17.1
• org.gaul:modernizer-maven-plugin 2.9.0
• org.ow2.asm:asm 9.7
• org.openrewrite.maven:rewrite-maven-plugin 5.36.0
• com.puppycrawl.tools:checkstyle 10.17.0
• com.github.hazendaz:build-tools 1.3.1

maven-wrapper

.mvn/wrapper/maven-wrapper.properties

• maven 3.9.8
• maven-wrapper 3.3.2

---

• Check this box to trigger a request for Renovate to run again on this repository

Drop the gcupload profile and attach assemblies to project

As discussed in the ML, I proposed to avoid to upload assemblies "bundles" in favour of the Central repository.

At the end, what users need, are just links where downloading stuff, so no technical needs to upload them in different places.

Another option would be avail Bintray, which quickly got the interest of OSS communities

JDK 15 'maven-bundle-plugin' fails with ConcurrentModificationException / Needs bndtools 5.1.0 and jacoco 0.8.6 as well (unreleased)

see https://issues.apache.org/jira/browse/FELIX-6259

The issue is currently not fixed in a release. It is slated for 5.1.0. The plugin currently is using 4.2.0. I tried 5.0.1 as other user noted but it still had same issue. Adding this to keep track that we cannot use jdk 15 currently for travis ci builds.

Checkstyle defect - hold on any release

Checkstyle plugin 3.0.0 supports up to checkstyle 8.24.

Checkstyle plugin 3.1.0 supports up to checkstyle 8.28 but has a major regression. Change MCHECKSTYLE-365 attempted to fix a counting problem by changing behaviour. This results in projects like mybatis-3 failing to delivery anything in the 'rules aggregate' section. This is because mybatis-3 doesn't have any 'error' condition issues. Further, the newer checkstyles shows far more issues than in the past which we need to account for and without an overall statistic check on overall issue, it's hard to know what to focus our efforts on.

The above issue has been reported to maven checkstyle plugin team. I'm supplying a partial revert of the original commit but do not know if it will be accepted or fixed. That means for the time being, I'm putting a hold on releasing mybatis-parent in order to not cause downstream issues.

As it stands, all projects are generally being released on mybatis parent 31 before 32 is available anyways but this is here to prevent forgetting and subsequent release which then dependabot will apply everywhere.

configuration of findbugs-maven-plugin is wrong

type of findbugsXmlOutput is boolean. However current definition used the string type as follow:

<findbugsXmlOutput>${project.build.directory}/target/findbugs-reports</findbugsXmlOutput>

plugin usage for ide's suggested removal

maven-idea-plugin is retired and probably should be removed.
maven-eclipse-plugin is flagged for future retirement. Using this with modern eclipse versions actually causes way more issues than it attempts to solve since it does a lot of legacy things and m2e is preferred these days.

For eclipse plugin being potentially retired...
http://maven.40175.n5.nabble.com/DISCUSS-Move-everything-to-1-6-take-2-was-Re-I-can-t-make-a-release-td5820796.html#a5820985

If no objections, I can do a pull request on this. Thanks.

Question: what's the purpose of sonatype-oss-snapshots repository defined in POM?

Release parent 31

jdk 8 level
nearly all plugins up-to-date.

todo
review upgrading the bundle plugin

Maven Site 4 will break code highlight of Markdown source

repro repo https://github.com/awxiaoxian2020/code-render-bug
master branch is Maven Site 3 with Fluido skin 1
v4 branch is Maven Site 4 with Fluido skin 2.

Open their respective target/site/test.html files in local to see the rendered result.