mysociety/alavetelitheme

An example theme for alaveteli

Alavetelitheme

This is a "hello world" type theme package for Alaveteli.

The intention is to support simple overlaying of templates and resources without the need to touch the core Alaveteli software.

Typical usage should be limited to that described in the documentation:

To install:

In the Alaveteli general.yml configuration file change the default mysociety theme repository to your theme repository in the THEME_URLS setting:

THEME_URLS:
  - 'git://github.com/YOUR_GITHUB_USERNAME/YOUR_THEME_NAME.git'

You can then switch the theme the application is using:

bundle exec rake themes:install

To run tests:

To run tests, in the Alaveteli Rails.root (with this theme installed):

    bundle exec rspec lib/themes/alavetelitheme/spec

Copyright (c) 2011 mySociety, released under the MIT license

alavetelitheme's Issues

Add action menu styling

Add style guide to help people adapt the alaveteli theme and write css for their own themes

@garethrees suggests using something like http://warpspire.com/kss/

Request page "Make a request" ad broken

Use Rails.root instead of RAILS_ROOT to be Rails 3 compatible

Remove courier font from responses

A theme name with a hyphen breaks the automagic setting up of view paths

When I have a theme named (for example) panama-theme, I get the following error on loading a view:

undefined local variable or method `set_view_paths_for_panama'

Presumably because something goes awry in the meta-programming that should create this method: https://github.com/mysociety/alavetelitheme/blob/master/lib/alavetelitheme.rb#L1-L13

Copying the section from wtdk's theme which is more explicit: https://github.com/mysociety/whatdotheyknow-theme/blob/master/lib/alavetelitheme.rb#L4-L15 works fine however.

Sorry I can't be of more help. FWIW, adding some puts statements into the alavetelitheme.rb tells me that:

• THEME_NAME is correctly deduced to be panama-theme
• path_function_name becomes set_view_paths_for_panama-theme

So I guess the problem is in the define_method bit?

Fix user dropdown menu target

The arrow to open the dropdown is in slightly the wrong place, clicking on the username goes to the profile page instead:

Request status text is the same colour as the background

Any desire to enable Travis?

Hello:

Is there any desire to get travis working with this repo?

Create link icon

Should be white and fit in the circles at the bottom right hand corner of correspondence on pages like https://louise.whatdotheyknow.com/request/holding_pen. See https://camo.githubusercontent.com/e3453f1221c0f83b3af8878911e5f2365d2663e9/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f3131333932392f313135303935342f66626639336531322d316566322d313165332d383237352d3862383935326131326262382e706e67 for icon appearance.

Deprecate/remove lib/public_body_categories_en.rb

As of Alaveteli 0.20 (mysociety/alaveteli#1911) PublicBodyCategories will be database driven and managed in the admin interface.

Set responsive stylesheet font from mockups

Shouldn't be a webfont as this is the base design we're distributing to other people

Overriding of public_body_categories_en.rb doesn't happen as documented

There is a lib/public_body_categories_en.rb file in alavetelitheme as an example but it looks like that file actually needs to be in lib/lib/public_body_categories_en.rb.

I've looked through a couple of alaveteli themes. See for example:
https://github.com/dcabo/asktheeu-theme/blob/master/lib/lib/public_body_categories_en.rb

If this is expected then it would be good to move the file in this example alavetelitheme and change the documentation in alaveteli.

Create language switcher icon

See for example https://camo.githubusercontent.com/9713d496e6eeceb17b0a74eee46f4ac722966556/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f3131333932392f313133313338332f39363835356263652d316262392d313165332d383339652d6438633565313666346538642e706e67.

For the HTML this is to be used in, see http://louise.whatdotheyknow.com/

Remove test directory

Alaveteli uses Rspec

Decide success, failure and pending colours for alaveteli theme and generate status icon set

See

https://louise.whatdotheyknow.com/list/all?#results

The current code is using some placeholder success, failure, and pending text colours, and the icons that Zarino created for the WDTK theme. We need to decide if these are good colours and remake the icons for this theme in those colours.

Comment out code examples of how to customise theme

It's good that these are here to show people how to do things but they get in the way when actually customising.

Check for accidental regressions of css enhancements from 0.27

• The user menu dropdown appears blank as it's white text on a white background
• The arrow to open the dropdown is in slightly the wrong place, clicking on the username goes to the profile page instead
  
• Follow buttons need styling
• New request call to action text on the request page should be black
• Status description text on request page should be black

AssetNotPrecompiled exception

Sprockets::Rails::Helper::AssetNotPrecompiled in RequestController#show

Asset was not declared to be precompiled in production. Add
`Rails.application.config.assets.precompile += %w( logo-opengraph.png )` 
to `config/initializers/assets.rb` and restart your server

When loading any page under 0dee8c3 on mysociety/alaveteli@c8f2707.

Rename 'body' routes to 'authorities' to be consistent with the site text

add facebook_username to config

So we can use it in the new footer

Check quality of alaveteli logo

Not sure if this is just a rough? https://raw.githubusercontent.com/mysociety/alaveteli/feature/redesign-prep-rebased/app/assets/images/logo.png

Refactor alavetelitheme

• Strip out some of the customisations - make it less opinionated
• Porting over button styles, and colour variable setup from whatdotheyknow-theme

Set correct styles for request footer action menu and track button

• Action menu lacks text styling and has no pill background
• Follower count lacks text styling and container border

Footer is always detached from the literal foot of page

This fragment...

<a href="#content" class="show-with-keyboard-focus-only skip-to-link">Back to content</a>

...sits outside and after the footer on WDTK and lots of other sites, and causes a white space of approx 1em to appear underneath the footer. It's hideous. And if it's required, shouldn't it be above the footer anyway?

Dev server doesn't autoreload/re-apply theme's monkey patches

It would be a nicer experience developing an alaveteli theme if the dev server auto-reloaded the code you're working on. Currently if you change something in, say, controller_patches.rb you have to stop and start the server before it's picked up and applied. It looks like this is the intention, with sections like: https://github.com/mysociety/alavetelitheme/blob/master/lib/controller_patches.rb#L1-L9 but it doesn't seem to work as intended. Perhaps it's something about when/how this is run? https://github.com/mysociety/alavetelitheme/blob/master/lib/alavetelitheme.rb#L24-L29 (I'm afraid my rails knowledge is a bit too limited to be of more help here)

What parts of the new WDTK theme should we port into alavetelitheme?

before_filter is deprecated

Required by mysociety/alaveteli#3969

$ BUNDLE_GEMFILE="Gemfile.rails5" bundle exec rspec spec/models/
DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from <class:Base> at /home/vagrant/alaveteli/lib/themes/alavetelitheme/lib/alavetelitheme.rb:12)

Add stylesheets to implement new look and feel

Create stylesheets from Jed's designs for the new Alaveteli look and feel, similar to the work done on mysociety/whatdotheyknow-theme#128 for WDTK. Can reuse some code already committed to https://github.com/mysociety/alaveteli/tree/feature/redesign-prep-rebased and https://github.com/mysociety/whatdotheyknow-theme/tree/redesign

Use default alaveteli logo for Facebook default logo rather than 'your logo here'

Add encoding line to top of all .rb files

# -*- encoding : utf-8 -*-

Write some advice for installers on what size their logo should be

Don't distribute examples that modify alaveteli core

I just cloned alavetelitheme to use as a base for a new Alaveteli install.

I noticed the <title> had changed to "Make and browse Right to Know (RTI) requests". This is caused by distributing https://github.com/mysociety/alavetelitheme/blob/master/locale-theme/en/app.po.

Not sure if Know/RTI is a typo or intentional, but this shouldn't get applied anyway. Examples should be commented out or part of the alaveteli.org documentation.

Date links on correspondence different colours

Seems wrong?

Mobile nav menu cannot be closed once it is opened

Looking at the page source, I think it might be a CSS specificity issue, where the proper behaviour (eg: display: none for a.open when the menu is open) is getting overridden by a slightly more specific selector from somewhere else. And likewise, the .close button is affected by the same bug.