GitHub enterprise support

[naholyr]

GitHub enterprise support

[naholyr]

I use github module which seems to accept a url configuration param. But I don't provide any way to fill it right now.

I'll push very quickly a change in a new branch so you can test if it fits your need.

[naholyr]

I tried something in a new branch feature/16-github-url. You can try it with:

npm install -g "naholyr/github-todos#feature/16-github-url"

This version exposes a new option "github.url", in your case you should then

ght config github.host BASE_DOMAIN
ght config github.url /api/v3

Not sure where you should put the slashes or not, I've seen they used a single concatenation in github module instead of path.join() so you may need to customize that too.

I have no Github Enterprise to test so tell me if it suits you before I push it :)

[ianwremmel]

Looks like that worked, thanks!

The leading slash on /api/v3 is required.

[ianwremmel]

I take that back. It looks like I can auth against that url, but I these errors look like it's trying to use the standard API somewhere:

$ github-todos _hook -R 0.4.45..0.4.52

[Github-Todos] Error { [Error: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"}]
  message: '{"message":"Not Found","documentation_url":"https://developer.github.com/v3"}',
  code: 404 }
{"message":"Not Found","documentation_url":"https://developer.github.com/v3"}

[naholyr]

Looks like a future PR for github module ;)

Could you please try again after a new npm i -g "naholyr/github-todos#feature/16-github-url" prepending with DEBUG=* to
enable debug info output (DEBUG=* github-todos _hook …) and tell me what
you get?

[ianwremmel]

Ok, I figured out what's going on here (and I'd like to avoid posting the output because it includes some semi-private data). The problem was actually the value that I had in the repo field in .github-todos.

First, I had tried the name of my remote (e.g. origin) so when that didn't work, I copied the full repository URL. It seems that I just need org/reponame.

[naholyr]

Yes, yes you do :)
Maybe I should add a validation step in issue service for those cases.

Le jeu. 11 déc. 2014 18:05, Ian Remmel [email protected] a écrit :

Ok, I figured out what's going on here (and I'd like to avoid posting the
output because it includes some semi-private data). The problem was
actually the value that I had in the repo field in .github-todos.

First, I had tried the name of my remote (e.g. origin) so when that didn't
work, I copied the full repository URL. It seems that I just need
org/reponame.

—
Reply to this email directly or view it on GitHub
#16 (comment).

[naholyr]

Note: added validateConfig in 2.3.0