namely/ruby-client

Namely API Ruby Client

ruby-client's Issues

stripe gem conflict

Im having a dependency conflict with rest_client and netrc via stripe. full error report is below. would bumping the rest-client version dependency up be possible?

    Bundler could not find compatible versions for gem "netrc":
      In Gemfile:
        namely (>= 0) ruby depends on
          rest_client (>= 0) ruby depends on
            netrc (~> 0.7.7) ruby

        stripe (>= 0) ruby depends on
          rest-client (~> 1.4) ruby depends on
            netrc (0.10.2)

Drop backports / old rubies?

Using Ruby 2.4.0, our Rails app spits out warnings from the backports gem, which is required by the namely gem:

/Users/oli/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/backports-3.6.8/lib/backports/1.8.7/fixnum/div.rb:1: warning: constant ::Fixnum is deprecated
/Users/oli/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/backports-3.6.8/lib/backports/1.8.7/fixnum/fdiv.rb:1: warning: constant ::Fixnum is deprecated
/Users/oli/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/backports-3.6.8/lib/backports/2.1.0/bignum/bit_length.rb:1: warning: constant ::Bignum is deprecated
/Users/oli/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/backports-3.6.8/lib/backports/2.1.0/fixnum/bit_length.rb:1: warning: constant ::Fixnum is deprecated

Looking at this repo I noticed the travis.yml also uses old version of Ruby:

rvm:
  - 1.9.3
  - jruby-19mode
  - 2.0.0
  - 2.1.3

Ruby 1.9.3 and 2.0.0 have now reached end-of-life status. Could they be dropped, along with backports?

Support `per_page` parameter?

We're seeing a lot of 502 responses when attempting to fetch profiles, and it looks like the current recommendation is to fetch 20 per page, while it defaults to 30:

https://developers.namely.com/1.0/profiles/profiles-index

Is this currently supported by the gem? I did not find any reference to per_page in the code.

RubyGems 2.4.5 raises warning about `rest_client`

The following warning is raised when using the Ruby Client in a project while on Ruby Gems 2.4.5:

WARNING: The rest_client gem is deprecated and will be removed from RubyGems. Please use rest-client gem instead.

504 GatewayTimeout returned while retrieving paged profiles

While using connection.profiles.all occasionally the namely API will return a 504 gateway timeout status while retrieving one of the pages. This raises an exception and derails the (sometimes lengthy) process of retrieving all of the paged results.

One possible solution would be to catch that exception and retry a few times before returning the error. PR example solution forthcoming...

Improve handling of slow API calls

Some Namely API requests are very slow (like >30s). This means that RestClient will throw a timeout exception before the request completes.

Two ways to resolve:

1. Set RestClient timeout param to -1 (never timeout): http://stackoverflow.com/a/11658655/862544
2. Allow caller to pass in a timeout param to when making API calls via this wrapper

Working with client identifier and client secret?

It seems like your Auth documentation recommends against using the permanent access token, but it doesn't appear that your gem supports any other method. Any clarification on why it doesn't support client identifier and secret as well as permanent access token?

Namely.readme.io is empty

http://namely.readme.io/ (linked on README.md) is not working.

When visiting , I get the message "Project doesnt exist... yet!"