nanikit/bettersort

Beat saber plugin that adds last played date sort.

bettersort's Issues

ScoreSaber Replay is being counted as play

As title, replay is being counted as a play of the level.

To replicate, watch a replay of some level that you haven't played in a while. Then sort by LastPlay, you will see the level that you just watched the replay of is the top one

Import data from SongPlayHistoryContinued mod

Suggested by DM.

Currently thinking about importing json at mod launch.

BetterSongList in Namespace

Would you mind removing BetterSongList from the namespace of this sorter?

My concern is that whenever there happens to be an update which might break this sorter people could be mislead by the logged exceptions, thinking it is related to BetterSongList itself when it might just be the Sorter that broke.

An alternative I'd have in mind could be LastPlayedSort_for_BetterSongList

Doesn't work when scoresaber is not installed

Reported from beatmods approval team. The following is reproduced log.

[DEBUG @ 12:54:51 | BetterSort.LastPlayed] Initialize()
[ERROR @ 12:54:51 | IPA] BetterSort.LastPlayed OnEnable: Zenject.ZenjectException: Error occurred while instantiating object with type 'Scoresaber' ---> System.NullReferenceException: Object reference not set to an instance of an object
[ERROR @ 12:54:51 | IPA]   at BetterSort.LastPlayed.External.Scoresaber..ctor (IPA.Logging.Logger logger) [0x00017] in <cc82a20168ef4047b65484262724e3fb>:0 
[ERROR @ 12:54:51 | IPA]   at (wrapper dynamic-method) System.Object.lambda_method(System.Runtime.CompilerServices.Closure,object[])
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.InstantiateInternal (System.Type concreteType, System.Boolean autoInject, System.Collections.Generic.List`1[T] extraArgs, Zenject.InjectContext context, System.Object concreteIdentifier) [0x00164] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]    --- End of inner exception stack trace ---
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.InstantiateInternal (System.Type concreteType, System.Boolean autoInject, System.Collections.Generic.List`1[T] extraArgs, Zenject.InjectContext context, System.Object concreteIdentifier) [0x0018c] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.InstantiateExplicit (System.Type concreteType, System.Boolean autoInject, System.Collections.Generic.List`1[T] extraArgs, Zenject.InjectContext context, System.Object concreteIdentifier) [0x00044] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.TransientProvider.GetAllInstancesWithInjectSplit (Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Action& injectAction, System.Collections.Generic.List`1[T] buffer) [0x0005e] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.CachedProvider.GetAllInstancesWithInjectSplit (Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Action& injectAction, System.Collections.Generic.List`1[T] buffer) [0x00063] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.IProviderExtensions.GetAllInstances (Zenject.IProvider creator, Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Collections.Generic.List`1[T] buffer) [0x00006] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.IProviderExtensions.GetAllInstances (Zenject.IProvider creator, Zenject.InjectContext context, System.Collections.Generic.List`1[T] buffer) [0x00000] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.GetDecoratedInstances (Zenject.IProvider provider, Zenject.InjectContext context, System.Collections.Generic.List`1[T] buffer) [0x00022] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.SafeGetInstances (Zenject.DiContainer+ProviderInfo providerInfo, Zenject.InjectContext context, System.Collections.Generic.List`1[T] instances) [0x00078] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.Resolve (Zenject.InjectContext context) [0x001c9] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.InstantiateInternal (System.Type concreteType, System.Boolean autoInject, System.Collections.Generic.List`1[T] extraArgs, Zenject.InjectContext context, System.Object concreteIdentifier) [0x00100] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.InstantiateExplicit (System.Type concreteType, System.Boolean autoInject, System.Collections.Generic.List`1[T] extraArgs, Zenject.InjectContext context, System.Object concreteIdentifier) [0x00044] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.TransientProvider.GetAllInstancesWithInjectSplit (Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Action& injectAction, System.Collections.Generic.List`1[T] buffer) [0x0005e] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.CachedProvider.GetAllInstancesWithInjectSplit (Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Action& injectAction, System.Collections.Generic.List`1[T] buffer) [0x00063] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.IProviderExtensions.GetAllInstances (Zenject.IProvider creator, Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Collections.Generic.List`1[T] buffer) [0x00006] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.IProviderExtensions.GetAllInstances (Zenject.IProvider creator, Zenject.InjectContext context, System.Collections.Generic.List`1[T] buffer) [0x00000] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.GetDecoratedInstances (Zenject.IProvider provider, Zenject.InjectContext context, System.Collections.Generic.List`1[T] buffer) [0x00022] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.SafeGetInstances (Zenject.DiContainer+ProviderInfo providerInfo, Zenject.InjectContext context, System.Collections.Generic.List`1[T] instances) [0x00078] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.Resolve (Zenject.InjectContext context) [0x001c9] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.InstantiateInternal (System.Type concreteType, System.Boolean autoInject, System.Collections.Generic.List`1[T] extraArgs, Zenject.InjectContext context, System.Object concreteIdentifier) [0x00100] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.InstantiateExplicit (System.Type concreteType, System.Boolean autoInject, System.Collections.Generic.List`1[T] extraArgs, Zenject.InjectContext context, System.Object concreteIdentifier) [0x00044] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.TransientProvider.GetAllInstancesWithInjectSplit (Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Action& injectAction, System.Collections.Generic.List`1[T] buffer) [0x0005e] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.CachedProvider.GetAllInstancesWithInjectSplit (Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Action& injectAction, System.Collections.Generic.List`1[T] buffer) [0x00063] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.IProviderExtensions.GetAllInstances (Zenject.IProvider creator, Zenject.InjectContext context, System.Collections.Generic.List`1[T] args, System.Collections.Generic.List`1[T] buffer) [0x00006] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.IProviderExtensions.GetAllInstances (Zenject.IProvider creator, Zenject.InjectContext context, System.Collections.Generic.List`1[T] buffer) [0x00000] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.GetDecoratedInstances (Zenject.IProvider provider, Zenject.InjectContext context, System.Collections.Generic.List`1[T] buffer) [0x00022] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.SafeGetInstances (Zenject.DiContainer+ProviderInfo providerInfo, Zenject.InjectContext context, System.Collections.Generic.List`1[T] instances) [0x00078] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.Resolve (Zenject.InjectContext context) [0x001c9] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.ResolveId (System.Type contractType, System.Object identifier) [0x0000f] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.Resolve (System.Type contractType) [0x00000] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at Zenject.DiContainer.Resolve[TContract] () [0x00000] in <c39bfb311e694e2db267af53bb95bde7>:0 
[ERROR @ 12:54:51 | IPA]   at BetterSort.LastPlayed.Plugin.Initialize () [0x000bb] in <cc82a20168ef4047b65484262724e3fb>:0 
[ERROR @ 12:54:51 | IPA]   at (wrapper dynamic-method) System.Object.lambda_method(System.Runtime.CompilerServices.Closure,object)
[ERROR @ 12:54:51 | IPA]   at IPA.Loader.PluginExecutor.Enable () [0x0000c] in <85e5e5773585418d89fcc2712ee48bcc>:0 
[ERROR @ 12:54:51 | IPA]   at IPA.Loader.Composite.CompositeBSPlugin+<>c.<OnEnable>b__4_0 (IPA.Loader.PluginExecutor plugin) [0x00000] in <85e5e5773585418d89fcc2712ee48bcc>:0 
[ERROR @ 12:54:51 | IPA]   at IPA.Loader.Composite.CompositeBSPlugin.Invoke (IPA.Loader.Composite.CompositeBSPlugin+CompositeCall callback, System.String method) [0x00018] in <85e5e5773585418d89fcc2712ee48bcc>:0