nassosstylianou/football-transfer-window-analysis

Analysing 2017-18 football transfer window data

football-transfer-window-analysis's Issues

The player name problem

football-transfer-window-analysis/js/main.js

Lines 43 to 48 in 5338f13

	/* When I do just this, I get the name of only the first player.
	$("#playerNames").html(value.player_name);
	But if I actually call value. player_name, I get all the player names from the selected team back into the console */
	console.log(value.player_name);

Are you sure that you're getting the name of the first player and not the last player? I think what's happening is that the contents of the div are being rewritten every time it goes over the $.each loop - so you're left with only the last one. It looks like it works in the console because it doesn't overwrite what's in the console, it keeps the history.

football-transfer-window-analysis/js/main.js

Lines 50 to 55 in 5338f13

	/* If I comment the first bit out and go just with the code below so instead if I actually try to iterate through the player names, I find I am iterating through each letter in the name (but it does access all names, even if one letter at a time). I assume that the length is the length of all letters together, but still a little weird. */
	var playerName = '';
	for(i=0; i < value.player_name.length; i++){
	playerName += value.player_name[i] + "<br>";
	}
	$('#playerNames').append(playerName);

I'm surprised this is doing each one letter by letter, but I reckon it's because you've got a for loop within the each loop. So value.player_name must equal a name and value.player_name[i] must equal a letter? It gets all the names in the end because you are using $('#playerNames').append rather than $("#playerNames").html