natanaelel / bankstorage Goto Github PK
View Code? Open in Web Editor NEWA portable storage device that can store up to 1,000,000,000 items per slot.
Home Page: https://modrinth.com/mod/bank-storage
License: MIT License
A portable storage device that can store up to 1,000,000,000 items per slot.
Home Page: https://modrinth.com/mod/bank-storage
License: MIT License
Describe the bug
the game crashes to desktop while trying to place a block using the bank in build mode while sneaking.
To Reproduce
in trying, i've only had and been able to reproduce the crash in the nether. i've not tried any other dimensions.
Logs
reproduced in an instance with only this mod: https://pastebin.com/YTngx2Sg
Describe the bug
Game crashes on launch with a Critical Injection Failure due to injection conflicts with at least one other mod.
To Reproduce
Expected behavior
Game launches.
Logs
crash-2024-02-03_14.27.20-client.txt
latest.log
Additional context
I've got quite a few mods here, and I'm not in the mood to do extensive testing to see which other mods conflict. I know that a previous crash reported a conflict with Packages.
Mod version
1.0.2
Describe the bug
Had an ME system insert items into a bank which was in a dock, didn't void overflow items(deepslate)
To Reproduce
Steps to reproduce the behavior:
fill a slot in a bank,
have it on void overflow,
have ae2 insert more items with ex. storage bus,
it now uses a new slot.
Expected behavior
Void overflow working with AE2
Screenshots
Reason for the amount of deepslate is another bug(dupe...).
Haven't tested via other item insertion methods than ae2, but think it will be the same?
Mod version
BankStorage 1.3.1
Describe the bug
Honestly not sure if this inherent to the mod but I'm coming across the issue while in the bank screen. Hovering over any stack with a stack size greater than 99 crashes the game. I just created an iron bank, hovering over a stack of 106 redstone. Game crashed. Repeated the process until I realized it was telling me it should be {1;99}. Item tag doesn't even show, just crashes
To Reproduce
Steps to reproduce the behavior:
Obviously there shouldn't be an issue when doing so as I've used mods in the past such as simple backpacks where stack sizes were increased. Somewhere in the code? I'm sure there is an exception made but I have no idea lol.
crash-2024-06-21_00.35.36-client.txt
debug.log
Just want to know if this is an issue with the mod or perhaps other mods that are conflicting with it.
Sidenote: I removed expanded storage just to see if it was messing with anything and I was, for a moment, able to see the tag when hovering over the stack but the game still crashed
Describe the bug
Right clicking to open bank in inventory while holding a block in the offhand places the block and opens the inventory. I would expect right clicking the bank to open it would consume the right click event and not let it propagate to being able to place the block. Naturally this only occurs if you would otherwise be able to place the block in your offhand, such as looking at the ground in front of you or a wall.
To Reproduce
Expected behavior
Open bank, don't place block.
Screenshots
Nah
Logs
Nope
Additional context
Nuh uh
Describe the bug
Placing multiple bundles in a bank storage and right clicking places the item inside all of the stacked bundles
To Reproduce
Place two or more bundles into a bank storage
Right click an item while hovering over the bundle stack
Take the bundles out of the dank storage and right click them
Each bundle will contain a copy of the items put in
Expected behavior
The bank storage will not duplicate items placed inside and will instead put bundles with different contents in separate stacks/wont change inventories of other bundles
Additional context
Discovered to be working on the AOF6/7 modpack, haven't confirmed if it works on other versions
My suggestion is to allow the use of a keybind to "lock" a slot in the bank to only allow a particular item (or keep it empty).
If the key combo for it is Shift-click:
If I shift click a slot that contains cobblestone, then that slot will only allow cobblestone there. Even if you take the cobblestone out, no other items can go in that slot.
If I shift click an empty bank slot, then that slot will not fill with any items.
If I shift click a slot that is already locked, it will clear the lock, allowing any item to go into it again.
This will allow the player to ensure that there is always space for a particular item. Especially when docked and used to store byproducts (such as the sticks, logs, and other byproducts of cutting down trees) it will ensure that no one resource will block the others from being added when items are constantly being added/removed.
Describe the bug
For items that don't have the default stack size, they do not properly stack to 256/1024/4096/etc.
To Reproduce
Expected behavior
Items would stack to 256 as described in Bank 1's description
Actual behavior
Items stack to 4x their normal stack size but not to 256.
Additional context
I have not tested with higher tier banks but I assume the problem is similar for higher tiers
How to place the bank in the world, it doesn't say anywhere how! and how can I choose which block to build with on build mode!
it only uses the first slot and if u already have a huge number of items in that slot its basically impossible to change the order of which item should be in the first slot so u can build with, because u can only pick up 64 items at a time,
shouldn't it be like.. u can pick the whole thing! all items at once from one slot and change their order inside the bank!!! instead of 64 only!
Currently I don't think any of the modes do anything when docked, but it could be neat (especially if combined with my suggestion to have the current mode displayed on the bank inventory screen)
Describe the bug
The game crashed whilst ticking block entity
Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.server.MinecraftServer.method_3847(net.minecraft.class_5321)" because "server" is null
To Reproduce
Steps to reproduce the behavior:
Expected behavior
my world launch
Logs
latest.log
Describe the bug
I'm not sure what the bug is, but you've coded the mod to shout at me when something breaks.
[23:31:44] [Render thread/INFO]: [CHAT] §c§lTHIS WAS NOT SUPPOSED TO HAPPEN!
§rPlease make a bug report
§rdescribing what caused this message to appear.
§rhttps://github.com/Natanaelel/BankStorage/issues
§rMath.Random PlayerEntity.bankstorage$getSyncedRandom() returned null
If this error persists, try rejoining the server/world.
To Reproduce
I'm not sure, but here's what I did recently:
Other notes:
Expected behavior
No big chat message!
Screenshots
Logs
If applicable, add logs found in minecraft-instance/logs/latest.log
and minecraft-instance/crash-reports/<crashlog>.txt
Additional context
Add any other context about the problem here.
##Suggestion
Allow the player to remove a Bank from its dock without breaking the dock.
As a secondary suggestion, allow the player to right click an occupied dock with another bank to swap them.
Perhaps a minor nitpick, but a display on the bank inventory screen that tells you what mode it's in would be nice.
This is especially relevant for bigger danks where the inventory would cover up the text that appears when you toggle modes.
This is a feature in the mod "Packed Up", another backpack mod. When you press your chosen keybind, it opens the first backpack (from Packed Up) it finds in your inventory, regardless of position. The backpack does not need to be worn (with the Curios API) nor on your hotbar.
This would be a neat function to add to this mod, if you're so inclined.
This feature might be challenging based on you're implementing Banks, but is one of my most used features from Dank Storage.
Basically, in Dank Storage each dank was assigned a sequential ID (I know Bank Storage uses UUIDs instead). If two danks were the same size, you could manually change the ID of one dank to match another to have them share an inventory.
By doing this, you could effectively use Banks as a sort of Entangled Chest in addition to its other functionality.
The descriptions for all banks state "Numer of slots" instead of "Number of slots."
Describe the bug
A clear and concise description of what the bug is.
Get Crash on occasion when trying to place a block with build mode
To Reproduce
Steps to reproduce the behavior:
Hard to reproduce only happens sometimes
Logs
If applicable, add logs found in minecraft-instance/logs/latest.log
and minecraft-instance/crash-reports/<crashlog>.txt
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.