natanaelel/bankstorage

A portable storage device that can store up to 1,000,000,000 items per slot.

bankstorage's Issues

build mode crash

Describe the bug
the game crashes to desktop while trying to place a block using the bank in build mode while sneaking.

To Reproduce
in trying, i've only had and been able to reproduce the crash in the nether. i've not tried any other dimensions.

1. spawn in any bank, fill with any number of blocks
2. set bank to build mode
3. sneak-walk backwards and hold down the place block button to build a bridge over air
4. if needed, jitter view a little to simulate missing - the crash occurs on switching to random build mode and immediately placing a block

Logs
reproduced in an instance with only this mod: https://pastebin.com/YTngx2Sg

Crash on launch?

Describe the bug
Game crashes on launch with a Critical Injection Failure due to injection conflicts with at least one other mod.

To Reproduce

1. Install both Spyglass Astronomy and Bank Storage.
2. Start game.
3. Crash.

Expected behavior
Game launches.

Logs
crash-2024-02-03_14.27.20-client.txt
latest.log

Additional context
I've got quite a few mods here, and I'm not in the mood to do extensive testing to see which other mods conflict. I know that a previous crash reported a conflict with Packages.

Void overflow doesn't seem to work with AE2

Mod version
1.0.2

Describe the bug
Had an ME system insert items into a bank which was in a dock, didn't void overflow items(deepslate)

To Reproduce
Steps to reproduce the behavior:
fill a slot in a bank,
have it on void overflow,
have ae2 insert more items with ex. storage bus,
it now uses a new slot.

Expected behavior
Void overflow working with AE2

Screenshots

Reason for the amount of deepslate is another bug(dupe...).

Haven't tested via other item insertion methods than ae2, but think it will be the same?

Client side crash when hovering over an item >99 stack size

Mod version
BankStorage 1.3.1

Describe the bug
Honestly not sure if this inherent to the mod but I'm coming across the issue while in the bank screen. Hovering over any stack with a stack size greater than 99 crashes the game. I just created an iron bank, hovering over a stack of 106 redstone. Game crashed. Repeated the process until I realized it was telling me it should be {1;99}. Item tag doesn't even show, just crashes

To Reproduce
Steps to reproduce the behavior:

1. Go to bank storage than can hold max size greater than 99
2. Hover over
3. Crash
4. See error

Obviously there shouldn't be an issue when doing so as I've used mods in the past such as simple backpacks where stack sizes were increased. Somewhere in the code? I'm sure there is an exception made but I have no idea lol.

crash-2024-06-21_00.35.36-client.txt
debug.log

Just want to know if this is an issue with the mod or perhaps other mods that are conflicting with it.

Sidenote: I removed expanded storage just to see if it was messing with anything and I was, for a moment, able to see the tag when hovering over the stack but the game still crashed

Right clicking to open bank in inventory while holding a block in the offhand places the block and opens the inventory

Describe the bug
Right clicking to open bank in inventory while holding a block in the offhand places the block and opens the inventory. I would expect right clicking the bank to open it would consume the right click event and not let it propagate to being able to place the block. Naturally this only occurs if you would otherwise be able to place the block in your offhand, such as looking at the ground in front of you or a wall.

To Reproduce

1. Put bank in your hotbar and a placeable block/item in your offhand
2. Be in a position where you could place the block in your offhand under normal conditions
3. Right click with the bank in your main hand to open it
4. Behold - you've opened the bank and placed a block

Expected behavior
Open bank, don't place block.

Screenshots
Nah

Logs
Nope

Additional context
Nuh uh

Bank storages can be used to duplicate items

Describe the bug
Placing multiple bundles in a bank storage and right clicking places the item inside all of the stacked bundles

To Reproduce
Place two or more bundles into a bank storage
Right click an item while hovering over the bundle stack
Take the bundles out of the dank storage and right click them
Each bundle will contain a copy of the items put in

Expected behavior
The bank storage will not duplicate items placed inside and will instead put bundles with different contents in separate stacks/wont change inventories of other bundles

Additional context
Discovered to be working on the AOF6/7 modpack, haven't confirmed if it works on other versions

Suggestion: Lock slots

My Suggestion:

My suggestion is to allow the use of a keybind to "lock" a slot in the bank to only allow a particular item (or keep it empty).

Example:

If the key combo for it is Shift-click:

If I shift click a slot that contains cobblestone, then that slot will only allow cobblestone there. Even if you take the cobblestone out, no other items can go in that slot.

If I shift click an empty bank slot, then that slot will not fill with any items.

If I shift click a slot that is already locked, it will clear the lock, allowing any item to go into it again.

Why?

This will allow the player to ensure that there is always space for a particular item. Especially when docked and used to store byproducts (such as the sticks, logs, and other byproducts of cutting down trees) it will ensure that no one resource will block the others from being added when items are constantly being added/removed.

Incorrect Stack Sizes

Describe the bug
For items that don't have the default stack size, they do not properly stack to 256/1024/4096/etc.

To Reproduce

1. Take 65+ ender pearls or 5+ non-stackable items (such as water buckets)
2. Place them into a Bank 1

Expected behavior
Items would stack to 256 as described in Bank 1's description

Actual behavior
Items stack to 4x their normal stack size but not to 256.

Additional context
I have not tested with higher tier banks but I assume the problem is similar for higher tiers

Needed improvement!!

How to place the bank in the world, it doesn't say anywhere how! and how can I choose which block to build with on build mode!
it only uses the first slot and if u already have a huge number of items in that slot its basically impossible to change the order of which item should be in the first slot so u can build with, because u can only pick up 64 items at a time,
shouldn't it be like.. u can pick the whole thing! all items at once from one slot and change their order inside the bank!!! instead of 64 only!

Suggestion: Modes while docked

Currently I don't think any of the modes do anything when docked, but it could be neat (especially if combined with my suggestion to have the current mode displayed on the bank inventory screen)

1. No Pickup/Pickup All function as normal
2. Filtered Pickup could only accept items already in the Bank
3. Void Excess could function like Filtered Pickup, but also void excess items

the game crashed when I placed the bank in the docking station under the chute from the create mod

Describe the bug
The game crashed whilst ticking block entity
Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.server.MinecraftServer.method_3847(net.minecraft.class_5321)" because "server" is null

To Reproduce
Steps to reproduce the behavior:

1. place the dock under chute from create mod
2. Click on dock with bank
3. the game will freeze
4. game crash

Expected behavior
my world launch

Logs
latest.log

"THIS WAS NOT SUPPOSED TO HAPPEN!" error message when opening Bank

Describe the bug
I'm not sure what the bug is, but you've coded the mod to shout at me when something breaks.

[23:31:44] [Render thread/INFO]: [CHAT] §c§lTHIS WAS NOT SUPPOSED TO HAPPEN!
§rPlease make a bug report
§rdescribing what caused this message to appear.
§rhttps://github.com/Natanaelel/BankStorage/issues
§rMath.Random PlayerEntity.bankstorage$getSyncedRandom() returned null
If this error persists, try rejoining the server/world.

To Reproduce
I'm not sure, but here's what I did recently:

1. Flew to the Stronghold and went to the End (already defeated the Dragon)
2. When I got there realized I was out of food so I came back through the portal
3. Got food, repeat step 1.
4. Mined about 2k obsidian out of one of the towers, which got picked up in on of my banks.
5. Went back through the portal
6. Opened my bank by looking at the floor at a normal construction block. Got the error message.
7. Shift-clicked obsidian out then deposited in ME and repeated a few times, getting the error message immediately upon opening the bank each time.

Other notes:

1. I have 3 banks in my inventory
2. The issue happens with each bank right now
3. The issue only happens when I look at a block and open it. If I open the bank in the air, it does not happen.
4. After disconnecting from the server and reconnecting, the issue is not happening anymore. I play on a locally hosted server.

Expected behavior
No big chat message!

Screenshots

Logs
If applicable, add logs found in minecraft-instance/logs/latest.log and minecraft-instance/crash-reports/<crashlog>.txt

Additional context
Add any other context about the problem here.

Suggestion: Remove Banks from Bank Dock Without Breaking it

##Suggestion

Allow the player to remove a Bank from its dock without breaking the dock.

As a secondary suggestion, allow the player to right click an occupied dock with another bank to swap them.

Suggestion: Mode Display

Perhaps a minor nitpick, but a display on the bank inventory screen that tells you what mode it's in would be nice.

This is especially relevant for bigger danks where the inventory would cover up the text that appears when you toggle modes.

[Suggestion] Add keybind to open first bank found in inventory

This is a feature in the mod "Packed Up", another backpack mod. When you press your chosen keybind, it opens the first backpack (from Packed Up) it finds in your inventory, regardless of position. The backpack does not need to be worn (with the Curios API) nor on your hotbar.

This would be a neat function to add to this mod, if you're so inclined.

[BS 0.1.5] Mode button doesn't seem to work anymore

Minecraft_.1.20.1.-.Singleplayer.2023-10-02.10-46-52.mp4

Suggestion: Changing Bank IDs for shared storage

This feature might be challenging based on you're implementing Banks, but is one of my most used features from Dank Storage.

Basically, in Dank Storage each dank was assigned a sequential ID (I know Bank Storage uses UUIDs instead). If two danks were the same size, you could manually change the ID of one dank to match another to have them share an inventory.

By doing this, you could effectively use Banks as a sort of Entangled Chest in addition to its other functionality.

Typo: Number of Slots

The descriptions for all banks state "Numer of slots" instead of "Number of slots."

Get this crash on occasion

Describe the bug
A clear and concise description of what the bug is.

Get Crash on occasion when trying to place a block with build mode

To Reproduce
Steps to reproduce the behavior:

Hard to reproduce only happens sometimes

Logs
If applicable, add logs found in minecraft-instance/logs/latest.log and minecraft-instance/crash-reports/<crashlog>.txt

https://pastebin.com/sHcVZvfB