navidsassan/icingaweb2-module-director

The Director aims to be your new favourite Icinga config deployment tool. Director is designed for those who want to automate their configuration deployment and those who want to grant their “point & click” users easy access to the configuration.

icingaweb2-module-director's Issues

try improving the diff of datafields in basket snapshots

The goal would be to have a nicer diff for the datafields, as the datafield_ids alone are not very informative. Screenshot with my adjustments:

Problems with my current implementation attempt:

• Some datafields have a diff directly after restoring them (minimal-datafield1.json).
• What do we do with the fields key in the main diff of the object? Right now, it always leads to the object being "modified" due to the different datafield_ids. If we use tweakTargetIds(), what exactly should it do? At the moment it sets the datafield_id of the current object to the one of the basket - I would prefer if it was the other way around, if we need to keep the fields around at all.
• Getting the current field does not 100% follow DirectorDatafield::import() (Code in BasketController.php)
• The new code in the BasketController has to be improved. Currently it is calling BasketDiff too many times to get only slightly different things.
• Stacktrace when trying to look at a command in the director (SQLSTATE[42000]: Syntax error or access violation)