navikt/bidrag-actions

Github Actions for team bidrag

bidrag-actions's Issues

DevOps release

Når ting merges til master og det er angitt at releaseinnslag i README.md som ikke er tagget, kjør en git. tag

release-prepare-mvn-pkg/prepare-release.sh leser inn snapshot-versjon med innrykk

release-prepare-mvn-pkg/prepare-release.sh leser inn snapshot-versjon med innrykk.

Endre

RELEASE_VERSION=$(cat pom.xml | grep version | grep SNAPSHOT | \ sed 's/version//g' | sed 's/ //' | sed 's/-SNAPSHOT//' | sed 's;[</>];;g')

til

RELEASE_VERSION=$(cat pom.xml | grep version | grep SNAPSHOT | \ sed 's/version//g' | sed 's/ //' | sed 's/-SNAPSHOT//' | sed 's;[</>];;g' | xargs)

for å bli kvitt problemet

remove git diff --only-name --cached in tag-and-commit/git.sh

This only adds to confusion, because nothing is displayed in the log.

rename input parameter in tag-and-commit/action.yml

this will further the reading of the action and use the same naming standard as the other actions.

from file_is_releaseto is_auto_release_file_name
from tag_file to release_version_file_name

note.. fix up tag-and-commit/git.sh for this change

count number of SNAPSHOT dependencies in maven script

The action verify-mvn-dependencies which run the shell script verify.sh will fail when the environment variable COUNT (of SNAPSHOT) is greater than 0.

I would like to fail this script if any commands have an exit code not like 0, ie start the script with:

#!/bin/bash
set -e

However, this backfires because when the command grep -c encounters 0 targets (i.e. do not find any SNAPSHOT dependencies) it fails with exit code 1.

This is the number which it should NOT fail with, so these are the actions for this enhancement:

1. tell the script to fail fast, ie start with:

#!/bin/bash
set -e

2. configure the grep command to not fail when grep -c SNAPSHOT = 0
   OR
   add the text SNAPSHOT to the dependency-graph and subtract this one occurrence before checking that the value is 0