neatorobito/scoop-crystal

Scoop bucket for the Crystal programming language on Windows

scoop-crystal's Issues

Nightly build install is not working

Hi,

PS C:\Users\mavu> scoop install crystal-nightly
Couldn't find manifest for 'crystal-nightly'.

 scoop install https://github.com/neatorobito/scoop-crystal/raw/main/nightly/crystal-nightly.json
Installing 'crystal-nightly' (1.6.56) [64bit]
The remote server returned an error: (404) Not Found.
URL https://nightly.link/crystal-lang/crystal/actions/artifacts/485523404.zip is not valid

Can't install nightly build with scoop install crystal-nightly or scoop install crystal-preview
if I try the manifest directly, see above error.

[email protected]: hash check failed

C:\Users\vince>scoop update crystal
crystal: 1.13.0 -> 1.13.1
Updating one outdated app:
Updating 'crystal' (1.13.0 -> 1.13.1)
Downloading new version
crystal-1.13.1-windows-x86_64-msvc-unsupported.zip (44.2 MB) [==============================================================] 100%
Checking hash of crystal-1.13.1-windows-x86_64-msvc-unsupported.zip ... ERROR Hash check failed!
App: crystal-preview/crystal
URL: https://github.com/crystal-lang/crystal/releases/download/1.13.1/crystal-1.13.1-windows-x86_64-msvc-unsupported.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected: 7c16276604bbfaf9d96a6973ea09d79168c7c227d39c9d27d6c6479baca7920f
Actual: 9c1d2a8746be249bf69d77cc56192c19b293ddb1c6a13b65c9dbd354f590efa4

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/neatorobito/scoop-crystal/issues/new?title=crystal%401.13.1%3a+hash+check+failed

Error when updating to 1.9.0

Installing 'crystal' (1.9.0) [64bit] from crystal-preview bucket
Loading crystal-1.9.0-windows-x86_64-msvc-unsupported.exe from cache
Linking A:\Scoop\apps\crystal\current => A:\Scoop\apps\crystal\1.9.0
Creating shim for 'crystal'.
Can't shim 'crystal.exe': File doesn't exist.

Error when run `scoop install vs_2022_cpp_build_tools` after installed it already use vs_BuildTools

Please check following screenshot. （选项=option, 未知=unknown)

I guess the --passive was passed with without -- prefix.

Thanks

PS C:\Users\zw963> scoop install vs_2022_cpp_build_tools
Installing 'vs_2022_cpp_build_tools' (17.0) [64bit] from crystal-preview bucket
vs_BuildTools.exe (2.0 MB) [=============================================================================================================================================================================] 100%
Checking hash of vs_BuildTools.exe ... ok.
Running installer... done.
Linking ~\scoop\apps\vs_2022_cpp_build_tools\current => ~\scoop\apps\vs_2022_cpp_build_tools\17.0

Scoop install doesn't work with non-ASCII user name

PS C:\Users\Андрей> scoop install crystal
Installing 'crystal' (1.3.1.2) [64bit]
Loading 144748738.zip from cache
Checking hash of 144748738.zip ... ok.
Extracting 144748738.zip ... done.
Linking ~\scoop\apps\crystal\current => ~\scoop\apps\crystal\1.3.1.2
Creating shim for 'crystal'.
Running post-install script...
'crystal' (1.3.1.2) was installed successfully!
'crystal' suggests installing 'scoop-crystal/shards'.
PS C:\Users\Андрей> crystal -v
Could not create process with command 'C:\Users\??????\scoop\apps\crystal\current\crystal.exe  -v'.
PS C:\Users\Андрей>

[email protected]: hash check failed

It seems that the expected hash for vs_2022_cpp_build_tools does not match the actual upstream one. Maybe the upstream installer was updated?

btw, thank you for making this scoop bucket!

Hash checking for downloads is gone

f5dccd1#diff-51a72be21a2e29db22429ca095acf9be8b06a5360510cc054955feb5f1b65ecc

Why?

[email protected]: hash check failed

scoop install crystal

Installing 'crystal' (1.13.1) [64bit] from 'crystal-preview' bucket
crystal-1.13.1-windows-x86_64-msvc-unsupported.zip (44.2 MB) [================================================] 100%
Checking hash of crystal-1.13.1-windows-x86_64-msvc-unsupported.zip ... ERROR Hash check failed!
App:         crystal-preview/crystal
URL:         https://github.com/crystal-lang/crystal/releases/download/1.13.1/crystal-1.13.1-windows-x86_64-msvc-unsupported.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    7c16276604bbfaf9d96a6973ea09d79168c7c227d39c9d27d6c6479baca7920f
Actual:      9c1d2a8746be249bf69d77cc56192c19b293ddb1c6a13b65c9dbd354f590efa4

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/neatorobito/scoop-crystal/issues/new?title=crystal%401.13.1%3a+hash+check+failed

Crystal tagged builds now available - should they replace nightlies?

https://github.com/crystal-lang/crystal/releases/tag/1.3.1
https://github.com/crystal-lang/crystal/releases/download/1.3.1/crystal-1.3.1-windows-x86_64-msvc-unsupported.zip

I think these downloads should become what 'crystal.json' is about. Whereas the current 'crystal.json' might be moved to 'crystal-nightly'.

These downloads also contain 'shards.exe'. Perhaps 'shards.json' could rely on that exact same download but keep only 'shards.exe' from it. Or do you think 'crystal.json' should provide 'shards.exe'? (I don't think so)

Ref crystal-lang/crystal#11489 (comment)

scoop vs tools

PS C:\Users\rdp> git --version
git version 2.10.1.windows.1

PS C:\Users\rdp> scoop install vs_2022_cpp_build_tools

Couldn't find manifest for 'vs_2022_cpp_build_tools'.

Can anybody confirm?

Scoop install fails - script seems to check in wrong directory for executable.

I've been updating via scoop for many months. Now it won't install correctly.
Output:

Get-Command : The term 'crystal.exe' is not recognized as the name of a cmdlet, function, script file, or operable
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At C:\Users\usuario\scoop\apps\scoop\current\lib\install.ps1:757 char:21
+             $bin = (Get-Command $target).Source
+                     ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (crystal.exe:String) [Get-Command], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException,Microsoft.PowerShell.Commands.GetCommandCommand

Can't shim 'crystal.exe': File doesn't exist.

It does in fact exist (at least until I do 'scoop uninstall crystal'):

C:\Users\usuario\scoop\apps\crystal\1.13.1\crystal-release\crystal.exe

I haven't delved into the source code, but I believe the script is still looking for the executable in

C:\Users\usuario\scoop\apps\crystal\1.13.1\

I would prefer to keep using scoop to update, and hope this can be fixed.

Recommend `shards` when installing `crystal`

I think it's good to have separate packages for crystal and shards. But it can be confusing when you install crystal but don't get shards and no information about it. This has already been noticed here: https://forum.crystal-lang.org/t/cant-run-shards-command-on-windows-crystal-v-1-3-0/4243

Most packages ship shards with crystal, but I think separation is better.
However, it would help to recommend installing shards when you install crystal (and vice versa probably?).
It seems scoop has a "suggest" property for this. That would print a recommendation to install shards when you install crystal (and don't have shards installed).

Alternatively, it could also be considered as a dependency. This would install shards automatically if you install crystal. But that would be wrong. shards is only a weak dependency. You can use Crystal perfectly well without shards.