Giter Site home page Giter Site logo

laravel-smsportal's People

Contributors

dependabot[bot] avatar johnroux avatar neolikotsi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

laravel-smsportal's Issues

Laravel 7.* Support

Hey,

Wanting to use this on Laravel 7.* but having issues with the guzzle version as Laravel now requires it at ^6.3 and this package is requiring ~5.0

Delivery Environment

Hey,

It's a little odd ad very counter-intuitive that by default config, this will send smses on all environments except production

I was going to make a PR, but there are two main options here:

  1. Simple: Have a single env variable which is just an enabled flag: (SMS_PORTAL_DELIVERY_ENABLED, true)
    It wouldn't care what environment you're on, it's configurable and very easily understood

  2. Environment aware: Have an array in the config with they key/val being environment/bool. The implementation then looks at app env, finds the key in the array based on the env and looks up it's enabled state.

Option 2 would mean the least impact for users and by default we can disable sending sms's out on testing environments etc
But it would be a bit more prone to issues (if someone has an environment outside the norms, it would give a key error etc)

Thoughts?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.