neolikotsi / laravel-smsportal Goto Github PK
View Code? Open in Web Editor NEWSMS Portal Notification Channel for laravel
License: MIT License
SMS Portal Notification Channel for laravel
License: MIT License
Hey,
Wanting to use this on Laravel 7.* but having issues with the guzzle version as Laravel now requires it at ^6.3
and this package is requiring ~5.0
Hey,
It's a little odd ad very counter-intuitive that by default config, this will send smses on all environments except production
I was going to make a PR, but there are two main options here:
Simple: Have a single env variable which is just an enabled flag: (SMS_PORTAL_DELIVERY_ENABLED, true)
It wouldn't care what environment you're on, it's configurable and very easily understood
Environment aware: Have an array in the config with they key/val being environment/bool. The implementation then looks at app env, finds the key in the array based on the env and looks up it's enabled state.
Option 2 would mean the least impact for users and by default we can disable sending sms's out on testing environments etc
But it would be a bit more prone to issues (if someone has an environment outside the norms, it would give a key error etc)
Thoughts?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.