nerc-ceh/puppet-fstab

A lightweight puppet module for managing mounts and server exports

puppet-fstab's Issues

problem with file mode declaration

Hi,

I get the following issue with Puppet 4.5.2 declaring the credentials file:

Error: Failed to apply catalog: Parameter mode failed on File[/root/mount.smb]: The file mode specification must be a string, not 'Fixnum' at /etc/puppetlabs/code/environments/hotfix/modules/fstab/manifests/mount.pp:28

To fix that, just replace mode => 400, with mode => '0400', on line 28 of mount.pp.

PS: do you want a PR?

Syntax of credentials file is incorrect for RHEL7

The correct syntax for the credentials file for RHEL7 is actually:

user=
password=

Currently, puppet-fstab outputs:

username=
password=

I think this behavior changed with a more recent version of cifs-utils package but I can't be sure.

fstab::mount mount resource fails if $manage_dir = false

If $manage_dir is equal to false then the file{$name} resource (directory) doesn't get created and the dependency fails on mount { $name}

Relax requirement on puppetlabs-concat

Puppetlabs concat is now at 2.2.0. The 2.0.0 requirement makes it difficult to upgrade.

I have tested puppet-fstab with version 2.2.0 successfully.

See #9