Comments (7)
@ctjlewis thanks for finding this and opening! at first i thought the leading * was necessary because our original syntax wasn't working but that syntax ended up being separate from the *. opening a PR now! <3
from next-on-netlify.
no worries for the CLI questions! happy to help if i can, especially because this is directly related to the issue you opened! that said, you're asking a great question, lol. as evidenced by the several changes i've made now to NoN's _headers logic, it's not exactly my area of expertise. the strange things for me are: 1. the rule/path is respected in and works in production just fine 2. people on the CLI issue you linked claim these rules work just fine if configured in the .toml file. i'd pause that work/PR until you/we can get confirmation on netlify/cli#1148, though i love that you started one already!!!!! i'll be sure to ping people on slack tomorrow about it
from next-on-netlify.
@ctjlewis ah okay! sounds good. i just sent this message in slack:
hello! i have a next-on-netlify user who wants to open a PR that addresses netlify/cli#1148. however, he’s/we’re not sure what in this issue is actually considered a valid path and whether it’s safe for him to “remove” this check https://github.com/netlify/cli/blob/425e2c6eeb6a3b589370a78407b18c53f4b850bc/src/utils/headers.js#L65-L73. i’m not entirely sure why these rules seemingly work in production and when configured in .toml files, as the issue commenters suggest. lmk!
feel free to tag me in the PR draft and i'll update my slack message with the PR link!
from next-on-netlify.
@ctjlewis morning! don't see a draft PR from you but here's what my team has said:
Looks like the implementation was based on the docs:
https://github.com/netlify/cli/pull/754#issuecomment-599325288 which don’t have that information, but if it works in production it’s most likely the CLI’s fault.
I would suggest the user to try with the experimental -t flag (e.g. ntl dev -t) .
That would delegate headers parsing to the traffic mesh local agent.
my teammate that works most on the CLI said you "can open a draft PR fixing the specific use case that doesn't work in the CLI (but works in production) and they'll comment on the PR"!
from next-on-netlify.
There is an issue matching this one in the CLI repo. Please let me know if it would be best to add to that thread and I can close this.
from next-on-netlify.
@lindsaylevine No worries at all!
Am I right in understanding that this is actually a valid path, and that the CLI should be patched? I started working on a PR in that repo, but I'm not sure if that would be a desirable change (to remove the "cannot contain anything after *" check and add a test to make sure it accepts this path form, /*/.../stuff
).
I suppose the real issue at hand there is whether or not this path is actually valid. If it is, we should remove that check. The author of that issue seemed to indicate it was.
Also sorry for spilling CLI questions over into this issue.
from next-on-netlify.
It's already pretty much done, so what I will do is send it in as a draft and you guys can edit it if you need, toss it if not. Like you said, it depends on that clarification - if that rule really is allowed, the PR can get merged, and if not, someone might to update documentation / deploy logic.
Anyway, no rush at all, TYSM for your help! Mind if I CC you on that PR draft when I send it?
from next-on-netlify.
Related Issues (20)
- Add tests for root level index pages of all page types for i18n
- Use splats in SSG redirects instead of adding a redirect for every exact prerendered path HOT 5
- Investigate tradeoffs between redirects and copying files [to correct paths] HOT 1
- Netlify post processing/bundling causes some rendering to be blocked HOT 4
- "blocking" on getStaticPaths' fallback throwing ambiguous error HOT 1
- Cannot find module 'critters' HOT 2
- Missing `pages-manifest.json` HOT 1
- Failure when the publish directory is `public`. HOT 1
- Cannot find module 'jimp' HOT 12
- _redirects sorted wrong when using catch all route and dynamic routes HOT 4
- Add clarification for deployment with submodules HOT 4
- Cannot find module critters HOT 15
- [i18n] preview redirects are failing with non-default locales HOT 8
- Forward options params to "nextOnNetlify" function from node command-line args HOT 1
- Allow API routes to optionally run as background function HOT 3
- "The 'path' argument must be of type string. Received undefined" when using next-auth HOT 18
- Missing locale files with next-i18next HOT 10
- Timeout error when using MongoDB in getServerSideProps HOT 4
- *** deprecating next-on-netlify *** (info & feedback) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from next-on-netlify.