Giter Site home page Giter Site logo

Comments (4)

lindsaylevine avatar lindsaylevine commented on May 29, 2024 1

hey @ctjlewis! thanks so much for opening this issue and the accompanying PR!! this is an interesting use case i personally haven't encountered before but a very valid and not uncommon one, of course. there are a few things that come to mind. with the Next on Netlify initiative here at netlify, we will eventually be moving away from this repo. i think it doesn't hurt at all to merge your PR (thanks for the accessibility changes as well!!) with the submodule details; that said, i think it may/will be more appropriate in netlify's docs whenever we get to a point of having a thorough breakdown of the framework in our docs (vs scattered between here and the plugin repo and stuff). that's just me kindof sharing my line of thinking; doesn't really change things for you :). it'll just be on me to make sure this bit gets transferred over to wherever we'll be housing all the next stuff in our docs. lmk if you have any other thoughts! and feel free to tag me in the PR when it's no longer a draft!

from next-on-netlify.

lindsaylevine avatar lindsaylevine commented on May 29, 2024 1

totally with you! is your PR still a draft or is it ready to be reviewed/merged? :D @ctjlewis

from next-on-netlify.

ctjlewis avatar ctjlewis commented on May 29, 2024

I had the same thoughts - this isn't really a Next on Netlify thing, it's really a Deploy footnote in general.

Ideally, like you said, that note would go in the Deploy docs, and there would just be a tiny footnote in the section we have now like "please see this note regarding private submodules," which is much less intrusive on existing docs as well.

I just sent PRs in for all the bumps I hit trying to get netlify dev to work, and this was the final thing that caused the CLI to throw! Not trying to spam pointless changes, hope it's not a bother.

from next-on-netlify.

ctjlewis avatar ctjlewis commented on May 29, 2024

It's probably good to review/merge @lindsaylevine! I will update.

from next-on-netlify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.