Comments (4)
hey @ctjlewis! thanks so much for opening this issue and the accompanying PR!! this is an interesting use case i personally haven't encountered before but a very valid and not uncommon one, of course. there are a few things that come to mind. with the Next on Netlify initiative here at netlify, we will eventually be moving away from this repo. i think it doesn't hurt at all to merge your PR (thanks for the accessibility changes as well!!) with the submodule details; that said, i think it may/will be more appropriate in netlify's docs whenever we get to a point of having a thorough breakdown of the framework in our docs (vs scattered between here and the plugin repo and stuff). that's just me kindof sharing my line of thinking; doesn't really change things for you :). it'll just be on me to make sure this bit gets transferred over to wherever we'll be housing all the next stuff in our docs. lmk if you have any other thoughts! and feel free to tag me in the PR when it's no longer a draft!
from next-on-netlify.
totally with you! is your PR still a draft or is it ready to be reviewed/merged? :D @ctjlewis
from next-on-netlify.
I had the same thoughts - this isn't really a Next on Netlify thing, it's really a Deploy footnote in general.
Ideally, like you said, that note would go in the Deploy docs, and there would just be a tiny footnote in the section we have now like "please see this note regarding private submodules," which is much less intrusive on existing docs as well.
I just sent PRs in for all the bumps I hit trying to get netlify dev
to work, and this was the final thing that caused the CLI to throw! Not trying to spam pointless changes, hope it's not a bother.
from next-on-netlify.
It's probably good to review/merge @lindsaylevine! I will update.
from next-on-netlify.
Related Issues (20)
- Add tests for root level index pages of all page types for i18n
- Use splats in SSG redirects instead of adding a redirect for every exact prerendered path HOT 5
- Investigate tradeoffs between redirects and copying files [to correct paths] HOT 1
- Netlify post processing/bundling causes some rendering to be blocked HOT 4
- "blocking" on getStaticPaths' fallback throwing ambiguous error HOT 1
- Cannot find module 'critters' HOT 2
- Missing `pages-manifest.json` HOT 1
- Failure when the publish directory is `public`. HOT 1
- Cannot find module 'jimp' HOT 12
- Header config causes CLI to throw "invalid rule: cannot contain anything after *" HOT 7
- _redirects sorted wrong when using catch all route and dynamic routes HOT 4
- Cannot find module critters HOT 15
- [i18n] preview redirects are failing with non-default locales HOT 8
- Forward options params to "nextOnNetlify" function from node command-line args HOT 1
- Allow API routes to optionally run as background function HOT 3
- "The 'path' argument must be of type string. Received undefined" when using next-auth HOT 18
- Missing locale files with next-i18next HOT 10
- Timeout error when using MongoDB in getServerSideProps HOT 4
- *** deprecating next-on-netlify *** (info & feedback) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from next-on-netlify.