newrelic / nri-nginx Goto Github PK
View Code? Open in Web Editor NEWNew Relic Infrastructure Nginx Integration
License: Apache License 2.0
New Relic Infrastructure Nginx Integration
License: Apache License 2.0
Nginx config file parser fails with an error if the file ends with an empty newline.
Nginx config file parser fails should handle this, as it is common and mandated by POSIX.
When a newline is found, subsequent spaces and newlines are consumed in a loop. Subsequently, reader.UnreadRune()
. Is called. However, UnreadRune()
will return an error if a rune was not read in the last operation (as it's the case for EOF).
Lines 60 to 64 in 128c9be
If status module is set to discover, it only works as expected if is Nginx or Nginx Plus < = 1.13
๐คThis issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.
This Repolinter run generated the following results:
โ Error | โ Fail | โ Pass | Ignored | Total | |
---|---|---|---|---|---|
0 | 0 | 0 | 7 | 0 | 7 |
license-file-exists
#Found file (LICENSE
). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.
readme-file-exists
#Found file (README.md
). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.
readme-starts-with-community-plus-header
#The first 5 lines contain all of the requested patterns. (README.md
). The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/.
readme-contains-link-to-security-policy
#Contains a link to the security policy for this repository (README.md
). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy
or ../../security/policy
) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
readme-contains-discuss-topic
#Contains a link to the appropriate discuss.newrelic.com topic (README.md
). New Relic recommends directly linking the your appropriate discuss.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
code-of-conduct-should-not-exist-here
#New Relic has moved the CODE_OF_CONDUCT
file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT
file in a repository is now redundant and should be removed. Note that you will need to adjust any links to the local CODE_OF_CONDUCT
file in your documentation to point to the central file (README
and CONTRIBUTING
will probably have links that need updating). For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Did not find a file matching the specified patterns. All files passed this test.
third-party-notices-file-exists
#Found file (THIRD_PARTY_NOTICES.md
). A THIRD_PARTY_NOTICES.md
file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES
). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
tests/integration/docker-compose.yml
nginx 1.27.0
build/Dockerfile
golang 1.22.5-bookworm
tests/integration/Dockerfile
golang 1.22.5-bookworm
.github/workflows/automated_release.yaml
newrelic/coreint-automation v3
.github/workflows/on_prerelease.yaml
newrelic/coreint-automation v3
.github/workflows/on_push_pr.yaml
newrelic/coreint-automation v3
.github/workflows/on_release.yaml
newrelic/coreint-automation v3
.github/workflows/repolinter.yml
newrelic/coreint-automation v3
.github/workflows/security.yaml
newrelic/coreint-automation v3
go.mod
go 1.22.5
github.com/jeremywohl/flatten v1.0.1
github.com/newrelic/infra-integrations-sdk v3.8.2+incompatible
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.9.0
github.com/xeipuuv/gojsonschema v1.2.0
golang.org/x/tools v0.21.0
Using current Kafka/Redis GHA template migrate current build pipeline into GHA
Here is the reference: https://github.com/newrelic/nri-flex/blob/master/.goreleaser.yml#L7
Try to reduce the failure rate of the Guided Install by finding improvements to suggest to the Virtuoso Recipes and/or Documentation
Hi, can you improve the documentation for nginx agent installation for docker and Kubernetes, please?
I think that an example it is enough.
๐คThis issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.
This Repolinter run generated the following results:
โ Error | โ Fail | โ Pass | Ignored | Total | |
---|---|---|---|---|---|
0 | 0 | 0 | 7 | 0 | 7 |
license-file-exists
#Found file (LICENSE
). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.
readme-file-exists
#Found file (README.md
). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.
readme-starts-with-community-plus-header
#The first 5 lines contain all of the requested patterns. (README.md
). The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/.
readme-contains-link-to-security-policy
#Contains a link to the security policy for this repository (README.md
). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy
or ../../security/policy
) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
readme-contains-discuss-topic
#Contains a link to the appropriate discuss.newrelic.com topic (README.md
). New Relic recommends directly linking the your appropriate discuss.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
code-of-conduct-should-not-exist-here
#New Relic has moved the CODE_OF_CONDUCT
file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT
file in a repository is now redundant and should be removed. Note that you will need to adjust any links to the local CODE_OF_CONDUCT
file in your documentation to point to the central file (README
and CONTRIBUTING
will probably have links that need updating). For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Did not find a file matching the specified patterns. All files passed this test.
third-party-notices-file-exists
#Found file (THIRD_PARTY_NOTICES.md
). A THIRD_PARTY_NOTICES.md
file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES
). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.
Update Go to version 1.16
Migrate to Go modules
Update Infrastructure SDK to version 3.6.7.
Update other dependencies
The infrastructure agent can be run in a Docker environment. This is described in the documentation: https://docs.newrelic.com/docs/infrastructure/install-infrastructure-agent/get-started/requirements-infrastructure-agent/.
The documentation does not describe how to install the integration for NGINX in docker.
If we create nginx-config.yml and run the container, we will see an error:
level=warning msg="can't instantiate integrations from file" component=integrations.Manager error="can't instantiate integration: can't find an executable given the name: nri-nginx" file=/etc/newrelic-infra/integrations.d/nginx-config.yml
The error tells us that the integration needs to be installed first.
The newrelic/infrastructure docker image is based on Alpine linux. You can verify this by typing in the terminal:
cat /etc/os-release
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.18.0
PRETTY_NAME="Alpine Linux v3.18"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"
Alpine linux uses the APK package manager and does not have the nri-nginx package in the repositories.
If this package were in the repository, then it would be possible to build a Docker image like this:
FROM newrelic/infrastructure:latest
ADD newrelic-infra.yml /etc/newrelic-infra.yml
ADD nginx-config.yml /etc/newrelic-infra/integrations.d/nginx-config.yml
RUN apk add nri-nginx
There are many examples with building a docker image here: https://docs.newrelic.com/docs/infrastructure/install-infrastructure-agent/linux-installation/container-infrastructure-monitoring/
If I understand correctly, in Alpine linux we need to build the package from source.
Could you add an example to the documentation on how to properly install and use the NGINX integration for Alpine linux and docker in particular?
the graph is defined as
SELECT average(net.requestsPerSecond) FROM NginxSample WHERE host LIKE '%cust-XXX-%' TIMESERIES FACET `host` LIMIT 10 SINCE 259200 seconds ago EXTRAPOLATE
once an nginx process restarted, the graph went down to minus 35k. Obviously the request counter restarted form 0 and the agent did not detect that. It should detect such occasions and simply reset its own counter.
Goal: have new version released and published via new workflow
Hi, the sample config file has a endpoints
config option:
nri-nginx/nginx-config.yml.sample
Line 11 in 4563398
However, the official nri-nginx New Relic documentation does not mention this option. Is it possible to update the documentation to understand how to set up the endpoints
config option and what it does?
๐คThis issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.
This Repolinter run generated the following results:
โ Error | โ Fail | โ Pass | Ignored | Total | |
---|---|---|---|---|---|
0 | 1 | 0 | 6 | 0 | 7 |
code-of-conduct-file-does-not-exist
#New Relic has moved the CODE_OF_CONDUCT
file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT
file in a repository is now redundant and should be removed. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Found files. Below is a list of files or patterns that failed:
CODE_OF_CONDUCT.md
license-file-exists
#Found file (LICENSE
). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.
readme-file-exists
#Found file (README.md
). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.
readme-starts-with-community-plus-header
#The first 5 lines contain all of the requested patterns. (README.md
). The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/.
readme-contains-link-to-security-policy
#Contains a link to the security policy for this repository (README.md
). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy
or ../../security/policy
) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
readme-contains-discuss-topic
#Contains a link to the appropriate discuss.newrelic.com topic (README.md
). New Relic recommends directly linking the your appropriate discuss.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
third-party-notices-file-exists
#Found file (THIRD_PARTY_NOTICES.md
). A THIRD_PARTY_NOTICES.md
file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES
). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.
Customers do not know whether it is worth it or not to install this integration if we do not show them the metrics that are captured out of the box.
I see the link to the docs website but we cannot outsource this completely to the documentation team. The docs teams may be able to add additional bells and whistles sometimes, but engineers who are searching for nginx and new relic will not want to be taken to several different pages to learn how to see what the benefits are of the integration and how long it will take to install and configure.
Using current Kafka/Redis GHA template migrate current Travis-CI pipeline into GHA
Hi Folks!
Read me hints at installing from 'archive files' but I don't see any.
Am I missing something?
naive apt-get install nri-nginx
also seems to fail which is the recommendation from the nginx notes.
Thanks
Alex
๐คThis issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.
This Repolinter run generated the following results:
โ Error | โ Fail | โ Pass | Ignored | Total | |
---|---|---|---|---|---|
0 | 1 | 0 | 6 | 0 | 7 |
readme-starts-with-community-header
#The README of a community project should have a community project header at the start of the README. If you already have a community project header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/. Below is a list of files or patterns that failed:
README.md
: The first 5 lines do not contain the pattern(s): Open source Community header (see https://opensource.newrelic.com/oss-category).
the latest code snippet found at https://github.com/newrelic/opensource-website/wiki/Open-Source-Category-Snippets#code-snippet-1
to filelicense-file-exists
#Found file (LICENSE
). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.
readme-file-exists
#Found file (README.md
). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.
readme-contains-link-to-security-policy
#Contains a link to the security policy for this repository (README.md
). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy
or ../../security/policy
) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
readme-contains-forum-topic
#Contains a link to the appropriate forum.newrelic.com topic (README.md
). New Relic recommends directly linking the your appropriate forum.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
code-of-conduct-should-not-exist-here
#New Relic has moved the CODE_OF_CONDUCT
file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT
file in a repository is now redundant and should be removed. Note that you will need to adjust any links to the local CODE_OF_CONDUCT
file in your documentation to point to the central file (README
and CONTRIBUTING
will probably have links that need updating). For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Did not find a file matching the specified patterns. All files passed this test.
third-party-notices-file-exists
#Found file (THIRD_PARTY_NOTICES.md
). A THIRD_PARTY_NOTICES.md
file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES
). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.
๐คThis issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.
This Repolinter run generated the following results:
โ Error | โ Fail | โ Pass | Ignored | Total | |
---|---|---|---|---|---|
0 | 2 | 0 | 4 | 0 | 6 |
readme-starts-with-community-plus-header
#The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date. For more information please visit https://opensource.newrelic.com/oss-category/. Below is a list of files or patterns that failed:
README.md
: The first 1 lines do not contain the pattern(s): Open source Community Plus header (see https://opensource.newrelic.com/oss-category).
[![Community Plus header](https://github.com/newrelic/opensource-website/raw/master/src/images/categories/Community_Plus.png)](https://opensource.newrelic.com/oss-category/#community-plus)
to filereadme-contains-link-to-security-policy
#Doesn't contain a link to the security policy for this repository (README.md
). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy
) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
license-file-exists
#Found file (LICENSE
). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.
readme-file-exists
#Found file (README.md
). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.
readme-contains-discuss-topic
#Contains a link to the appropriate discuss.newrelic.com topic (README.md
). New Relic recommends directly linking the your appropriate discuss.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
third-party-notices-file-exists
#Found file (THIRD_PARTY_NOTICES.md
). A THIRD_PARTY_NOTICES.md file must be present in your repository to grant attribution to all dependencies being used by this project. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.
I found out that the our Nginx newrelic integration dashboard is showing total request as request per second.
I believe the problem is here:
Line 33 in 38246a6
For Nginx document, connections.accepted means total accepted request since start:
http://nginx.org/en/docs/http/ngx_http_api_module.html#def_nginx_connections
Could we have a fix for this, please?
Cheers,
Allan
๐คThis issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.
This Repolinter run generated the following results:
โ Error | โ Fail | โ Pass | Ignored | Total | |
---|---|---|---|---|---|
0 | 0 | 0 | 7 | 0 | 7 |
license-file-exists
#Found file (LICENSE
). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.
readme-file-exists
#Found file (README.md
). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.
readme-starts-with-community-plus-header
#The first 5 lines contain all of the requested patterns. (README.md
). The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/.
readme-contains-link-to-security-policy
#Contains a link to the security policy for this repository (README.md
). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy
or ../../security/policy
) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
readme-contains-forum-topic
#Contains a link to the appropriate forum.newrelic.com topic (README.md
). New Relic recommends directly linking the your appropriate forum.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.
code-of-conduct-should-not-exist-here
#New Relic has moved the CODE_OF_CONDUCT
file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT
file in a repository is now redundant and should be removed. Note that you will need to adjust any links to the local CODE_OF_CONDUCT
file in your documentation to point to the central file (README
and CONTRIBUTING
will probably have links that need updating). For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Did not find a file matching the specified patterns. All files passed this test.
third-party-notices-file-exists
#Found file (THIRD_PARTY_NOTICES.md
). A THIRD_PARTY_NOTICES.md
file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES
). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.
Line 296 in 0eb1eae
It appears the error result of the call to getStandardMetrics()
is never checked before the value is used causing a nil map to be used.
The infra agent now supports:
When I run make
command I get the following error:
src/nginx.go:63:4: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
and the build fails
I expect make
command not to fail and produce the binary.
make (base) master โฑ โผ
=== nginx === [ clean ]: cleaning workspace...
=== nginx === [ validate ]: running golangci-lint & semgrep... INFO [config_reader] Config search paths: [./ /home/pakallis/Projects/douleutaras/nri-nginx /home/pakallis/Projects/douleutaras /home/pakallis/Projects /home/pakallis /home /]
INFO [lintersdb] Active 7 linters: [errcheck gosimple govet ineffassign staticcheck typecheck unused]
INFO [loader] Go packages loading at mode 575 (types_sizes|deps|name|compiled_files|exports_file|files|imports) took 105.590969ms
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 1.223358ms
INFO [linters_context/goanalysis] analyzers took 0s with no stages
INFO [runner] Issues before processing: 5, after processing: 1
INFO [runner] Processors filtering stat (out/in): skip_dirs: 5/5, uniq_by_line: 1/1, fixer: 1/1, path_prefixer: 1/1, exclude: 5/5, nolint: 1/1, max_same_issues: 1/1, path_shortener: 1/1, cgo: 5/5, skip_files: 5/5, autogenerated_exclude: 5/5, exclude-rules: 1/5, severity-rules: 1/1, source_code: 1/1, sort_results: 1/1, filename_unadjuster: 5/5, path_prettifier: 5/5, identifier_marker: 5/5, diff: 1/1, max_per_file_from_linter: 1/1, max_from_linter: 1/1
INFO [runner] processing took 525.624ยตs with stages: nolint: 203.162ยตs, identifier_marker: 121.201ยตs, exclude-rules: 104.457ยตs, autogenerated_exclude: 41.822ยตs, path_prettifier: 29.631ยตs, source_code: 13.492ยตs, skip_dirs: 4.475ยตs, max_same_issues: 1.443ยตs, cgo: 1.381ยตs, uniq_by_line: 861ns, filename_unadjuster: 709ns, max_from_linter: 628ns, path_shortener: 591ns, fixer: 368ns, skip_files: 305ns, max_per_file_from_linter: 221ns, diff: 214ns, exclude: 204ns, severity-rules: 190ns, sort_results: 180ns, path_prefixer: 89ns
INFO [runner] linters took 33.564989ms with stages: goanalysis_metalinter: 32.978544ms
src/nginx.go:63:4: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
strings.Title(strings.Replace(integrationName, "com.newrelic.", "", 1)),
^
INFO File cache stats: 1 entries of total size 4.5KiB
INFO Memory: 3 samples, avg is 33.5MB, max is 44.4MB
INFO Execution took 144.574037ms
exit status 1
make: *** [Makefile:21: validate] Error 1
git clone <repo>
cd nri-nginx
make
Ubuntu 20.04
go version go1.19.7 linux/amd64
Improve static analysis with Semgrep adding the newrelic-infra-checkers actions to get the semgrep and golangci-lint configurations.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.