nexgenanalytics/trilinos

Primary repository for the Trilinos Project

trilinos's Issues

Compile and run Zoltan2 on Device

Verify that:

• Zoltan2 compiles on Device
• All tests pass

Write tests for updated `TpetraCrsColorer_Zoltan2`

Write performance report (Multi Jagged vs Quotient Graph)

Add documentation for new API

Add informative and user friendly documentation of new API (in form of Doxygen)

Provide new API for Adapters that make use of Kokkos::Views (both Host and Device spaces)

Provide new API for Zoltan2's Adapters. New API should consist of new get functions (that currently use raw pointers or ArrayViews) that return Kokkos::View in Host or Device space.
Example:

// Old (deprecated) API
virtual void getIDsView(const gno_t *&ids) const;
virtual void getIDsKokkosView(ConstIdsDeviceView &ids) const;

// New API
virtual void getIDsHostView(ConstIdsHostView &hostIds) const;
virtual void getIDsDeviceView(ConstIdsDeviceView &deviceIds) const; 

Compile and run Zoltan2 on Host

Verify that:

• Zoltan2 compiles on Host
• All tests pass

Build `miniEM` on Device (with Zoltan2)

`TpetraCrsColorer` - Add option to do transpose symmetrization

Cleanup Zotlan2's Adapters

• Fix formatting
• Remove dead code
• Add missing Documentation

Study `TpetraCrsColorer_Zoltan2` and `TpetraCrsColorer_Zoltan`

Add unit tests for new API

Add extensive unit tests for new API. Make sure to use existing Teuchos

Figure out the way to run `miniEM`

Figure out the way to properly run miniEM with Zoltan2 (Quotient/MJ Algorithms). Provide the full command line arguments (srun -N -n etc.)

MueLu: code coverage (mirror issue)

Mirror issue of trilinos#9743
This allows us (non-Trilinos developers) to actually edit the list.

muelu/adapters/stratimikos

• Thyra_MueLuPreconditionerFactory
• Thyra_XpetraLinearOp

muelu/adapters/tpetra

• MueLu_TpetraOperator

muelu/adapters/xpetra

• MueLu_Maxwell_Utils
• MueLu_RefMaxwell
• MueLu_Maxwell1

muelu/src/Graph/Containers

• MueLu_LWGraph_kokkos_def
• MueLu_LWGraph
• MueLu_Zoltan2GraphAdapter

muelu/src/Graph/HybridAggregation

• MueLu_HybridAggregationFactory (*must enable MueLu research code)

muelu/src/Graph/MatrixTransformation

• MueLu_VariableDofLaplacianFactory
• Muelu_AmalgamationInfo
• MueLu_CoalesceDropFactory

muelu/src/Graph/StructuredAggregation

• MueLu_IndexManager

muelu/src/Graph/StructuredAggregation/coupled

• MueLu_GlobalLexicographicIndexManager

muelu/src/Graph/StructuredAggregation/uncoupled

• MueLu_UncoupledIndexManager

muelu/src/Graph/UncoupledAggregation

• MueLu_UncoupledAggregationFactory_kokkos
• MueLu_UncoupledAggregationFactory
• MueLu_PreserveDirichletAggregationAlgorithm_kokkos
• MueLu_AggregationPhase3Algorithm

muelu/src/Graph/UserAggregation

• MueLu_UserAggregationFactory

muelu/src/Interface

• MueLu_AdaptiveSaMLParameterListInterpreter
• MueLu_HierarchyManager
• MueLu_ML2MueLuParameterTranslator

muelu/src/Interface/FacadeClasses

• MueLu_Facade_Simple
• MueLu_Facade_BGS2x2
• MueLu_FacadeClassFactory
• MueLu_FacadeClassBase

muelu/src/Misc

• MueLu_FilteredAFactory
• MueLu_SegregatedAFactory
• MueLu_DropNegativeEntriesFactory
• MueLu_CoordinatesTransferFactory_kokkos
• MueLu_FineLevelInputDataFactory
• MueLu_BlockedRAPFactory
• MueLu_AggregateQualityEstimateFactory
• MueLu_LineDetectionFactory

muelu/src/MueCentral

• MueLu_FactoryManager

muelu/src/Rebalancing

• MueLu_NodePartitionInterface
• MueLu_RebalanceMapFactory
• MueLu_RebalanceAcFactory
• MueLu_RebalanceBlockInterpolationFactory

muelu/src/Smoothers

• MueLu_NodePartitionInterface
• MueLu_RebalanceMapFactory
• MueLu_RebalanceAcFactory
• MueLu_RebalanceAcFactory
• MueLu_RebalanceBlockInterpolationFactory

muelu/src/Smoothers/BlockedSmoothers

• MueLu_BlockedDirectSolver

muelu/src/Transfers/Classical

• MueLu_ClassicalMapFactory_def.hpp

muelu/src/Transfers/Energy-Minimization

• MueLu_EminPFactory_def.hpp

Transfers/Petrov-Galerkin-SA

• MueLu_PGPFactory

muelu/src/Transfers/GeneralGeometric

• MueLu_GeometricInterpolationPFactory_kokkos

muelu/src/Transfers/SemiCoarsen

• MueLu_ToggleCoordinatesTransferFactory

muelu/src/Transfers/SmoothedAggregation

• MueLu_SaPFactory
• MueLu_SaPFactory_kokkos
• MueLu_TentativePFactory
• MueLu_TentativePFactory_kokkos

Transfers/User

• MueLu_UserPFactory

muelu/src/Utils

• MueLu_AggregationExportFactory
• MueLu_AlgebraicPermutationStrategy
• MueLu_CoarseningVisualizationFactory
• MueLu_CoupledRBMFactory
• MueLu_LocalPermutationStrategy
• MueLu_MatrixAnalysisFactory
• MueLu_PerfUtils
• MueLu_PermutationFactory
• MueLu_RigidBodyModeFactory
• MueLu_UtilitiesBase
• MueLu_Utilities
• MueLu_Utilities_kokkos
• MueLu_VisualizationHelpers

Modify MatrixAdapter signature to return ArrayRCP

In the file
packages/zoltan2/core/src/input/Zoltan2_MatrixAdapter.hpp

there are a couple of calls that need the interface changed and to all the inherited classes.

These two calls need to be modified from

virtual void getCRSView(const offset_t *&offsets, const gno_t *&colIds) const
to
virtual void getCRSView( ArrayRCP &offsets, ArrayView &colIds) const

and this call needs the same thing

virtual void getCRSView(const offset_t *&offsets,
const gno_t *& colIds,
const scalar_t *&values) const
to
virtual void getCRSView(ArrayRCP &offsets,
ArrayRCP & colIds,
ArrayRCP &values) const

Neither of these can return an unmanaged pointer, going with ArrayRCP since that is what is held in the class currently, rather than sending back just a pointer.

This is based on the branch ppp-zoltan2

Here is the config script to build and test

here is a config script
temp.txt

So, once this is done we can take care of the next step.

Compare results for `miniEM` with the MueLu (Multi Jagged vs Quotient Graph)

`TpetraCrsColorer` - Add option to do bipartate symmetrization

Integrate Quotient Graph into `miniEM`

Update `TpetraCrsColorer_Zoltan2` to match `TpetraCrsColorer_Zoltan`