nextcloud / bookmarks Goto Github PK

View Code? Open in Web Editor NEW

962.0 87.0 174.0 17.36 MB

🔖 Bookmark app for Nextcloud

Home Page: https://apps.nextcloud.com/apps/bookmarks

License: GNU Affero General Public License v3.0

PHP 41.28% JavaScript 49.61% Makefile 0.11% Vue 9.00%

nextcloud bookmarks free-software bookmark nextcloud-bookmarks bookmarks-manager bookmarking bookmark-manager

bookmarks's People

Contributors

Stargazers

Watchers

Forkers

neosin manoharsai pheraph twlkyao desyncr zenoniii charlotteasen flause cnylnk nalt lazzurs agitate hugobonav queer1 davidprevot 5im-0n ganomi quisa137 nagyist astanofka le-fractal behrisch xsbaggage tflidd chouchen memphisx erama ege1 thorko kelemenbalazs jbpiacentino bbstar076 naruto-natsu shtrom caasar alberanid amin-hedayati woodworker ctingwai biffhero huidaecho g4b0 my-owncloud deastiny thewatchmen janklostermann posytive iamra cloudcopy2 ttuxx wesavetheworld rowhit artificialowl maitrenem karolklp owncloud-archive marcelklehr kissthink jakop345 nextgenerationcloud bjornnorman e-alfred quinndiggity alboro quelonasec evancreno ascode crystalsilver slamj1 uniblockchain wrestrtdr dominic-p damko chiotisn planetahuevo pablocastellano izifortune lexelby dgmid iw0nderhow kkoojjyy msgpo nitind dynamicdesignz tarsbase s-johansson adolfoeliazat frankstolle rhinux timewindse snte bookmarktools violet-ve milenium8612 jessesteele smartree erebus999 swipswaps cloudcopy gmlee0231

bookmarks's Issues

Bookmarks refresh and go to top of page whenever updating a bookmark

Whenever you update a bookmark (adding a tag, for example), the bookmarks refresh and you are taken to the top of the page. This makes it really hard to maintain your bookmarks, since you have to keep scrolling back down to find your place..

More than 10 tags and all bookmarks disappear.

Imported my Firefox bookmarks by exporting to html and importing into OC 5.0.10 Bookmarks (downloaded GIT version of Bookmark app as at 28-Aug-2013)
Looked fine initially.
Started editing tags.

A bookmark of the name 'XRAY' simply refused to allow addition of a tag
Once I had more than 10 tags, all bookmarks disappear, unless I filter by a bookmark
It's a pain in the arse if you import lots of bookmarks and you want to tag them. There appears to be no obvious way to filter by bookmarks with NO tags, otherwise, you have to constantly scroll down after every tag update. With many bookmarks, the scrolling gets tedious.

Otherwise, another step towards me ditching delicious.com in favour of my own hosted bookmarks :)

Bookmarks - How create Tag

Hello,

It seems impossible to create a Tag when I'm editing a bookmark already created.

How can we create Tag ?

Thanks

Page title is truncated if it contains some characters.

If a page with a hash sign (#) is bookmarked with the bookmarklet the page title is truncated at the position of the hash sign.

also tested with ampersand.

Minimal html to reproduce:

<html> 
<head> 
<title>Testpage §$#%&/()=?'`+~|;:-_–test page test</title>
</head>
<body> 
content
</body>
</html>

Ability to edit tags?

This may be there and I just don't see it, but would be good to be able to edit tags and/or remove tags without hitting the DB directly.

Add Sharing / Use share api [$145]

The Current version of bookmark does not allow to share bookmark using the sharing api.

Let the user share a tag with users and using a "private link".

Export a simple page with the bookmarks and an feed (atom, rss, ..) .

There is a $145 open bounty on this issue. Add to the bounty at Bountysource.

Translation to other languages

Not all strings get translated.
One of them is "Filter by tag" for example

The reason for that is first argument of function "t" in file "js/bookmarks.js", which in some places of code is 'bookmark' instead of 'bookmarks'.

It should be easily resolved :)

integrate Firefox sync app

As discussed on the mailing list, the Bookmarks app and the Firefox bookmark sync app should be combined. The bookmarks in Firefox and in the Bookmarks app should be one and the same, synced.

Add "Folders" to Bookmarks to collect Bookmarks into Categories

I find the Bookmarks feature really useful since I find myself in many different locations and on different computers. So I collect a large number of bookmarks.

To help me organize my Bookmarks, I'd like to request a new "Folder" feature in Bookmarks so I can group related Bookmarks together. I'm attaching a picture to help explain this concept. This concept is very similar to how Firefox and Chrome organize bookmarks.

I should probably mention I'm using OwnCloud 5.0.5 on OpenSUSE 12.2 x64 LAMP setup, and am brand new to OwnCloud.

Thank you,
Craig

Can't use bookmarks at all since moving to MySQL.

Here's my problem: Earlier this week, I did an export from Delicious and imported everything into Owncloud's Bookmarks app.

Then, I decided to migrate from SQLite to MySQL, and because I wasn't too enthusiastic about the existing migration guides, I exported the content of each single app, moved away my Owncloud install directory and started from scratch using the web installer.

Now, I can't import my bookmarks again. After uploading either the Delicious export or my Owncloud export, I get "Import completed successfully", but there are no bookmarks to be found. I also can't add bookmarks interactively or through the bookmark-bookmarklet. The oc_bookmark tables in MySQL remain empty.

What can I do to narrow this issue down?

Cannot edit bookmark (Internal server error)

When I try to edit a bookmark, nothing happens and I get an Internal server error.

Log:

{"app":"PHP","message":"Call to a member function numRows() on a non-object at \/srv\/www\/cloud.kaiser.me\/public\/apps\/bookmarks\/lib\/bookmarks.php#299","level":4,"time":1375165745}

ownCloud 5.0.9, Debian GNU/Linux 6.0, PHP 5.4.17 (dotdeb), nginx 1.4.1

Filtering on a tag broken w/ Postgres backend

How to reproduce:

Go to main bookmarks app page.
Click on a tag
Nothing happens. Expected behavior: See a list of bookmarks with that tag.

The logfile gives the following error:

{"app":"PHP","message":"SQLSTATE[42P01]: Undefined table: 7 ERROR:  missing FROM-clause entry for table \"b\"\nLINE 4:     t2 where t2.bookmark_id = b.id and tag = $2)  ORDER BY l...
                                  ^ at \/usr\/local\/var\/www\/owncloud\/lib\/db.php#966","level":4,"time":1369687676}

Using:

owncloud 5.0.6 (manual install)
php5
postgres v9.1
lighttpd
Debian 7 stable (wheezy)

cannot add bookmark for https://github.com

Yes, it sounds strange. When I go to https://github.com or anything under that I can't add the bookmark to owncloud using the browser Read Later bookmarklet. Every other URL works fine. I'm running owncloud 5.0.10, PHP 5.3.10, Apache, mySQL, and Linux.

Edit: The browser is Firefox ESR 17.0.8 on Mac OS X 10.7 and 10.8. It occurs with both my normal profile and an unmodified profile. But on Safari 6.0.5 the bookmarklet works fine, so it seems to be a Firefox issue, not an owncloud one. Still curious about what could cause the problem since I need to use Firefox ESR as my primary browser.

Adding bookmarks could fail with older SQLite version

Hi,

there is a report of an user at the community forums:

https://forum.owncloud.org/viewtopic.php?f=23&t=10514

that adding a bookmark failed with this message:

{"app":"PHP","message":"SQLSTATE[HY000]: General error: 1 no such function: GROUP_CONCAT at \/var\/www\/html\/***\/owncloud\/lib\/db.php#384","level":4,"time":1366120340}

It seems (according to this changelog: https://www.sqlite.org/releaselog/3_5_4.html) SQlite is official supporting this GROUP_CONCAT function with 3.5.4 at the end of 2007.
I don't think that there are so many systems with that old SQlite versions out there but just want to report it here.

[Bookmarks] Edits are not beeing saved

OC 5.0.10 and OC 5.0.11, running with mysql

If i click the edit-pen of a bookmark, change something (f.e. adding a tag or description) and click save, non of the changes are saved: When I click on the edit-pen of another bookmark or reload the webpage, all changes are lost.

Tried this with different Firefox-Versions.

In the error-console of Firefox I see the following message, when I click the "save"-button:

[15:12:08.194] POST http://owncloud.xyz.de/index.php/apps/bookmarks/ajax/editBookmark.php [HTTP/1.1 500 Internal Server Error 124ms]

Error-log of owncloud doesn't show anything

Bookmark content page is not showing up on ios chrome or ios safari

Summery:
Server: debian, nginx, mysql, owncloud 5.0.10 from www.owncloud.org
Client: IPhone IOs6.1.4, chrome for IOs, Safari (bug appers)
Client: debian, chromium, ff (bug not appers)

Bug discription: Content Page (where the bookmarks are displayed) is not shown on Chrome for IOs or Safari

Hello,

i rolled out a owncloud 5.0.10 on my server (debian based, nginx, owncloud from www.owncloud.org).
I can see the content page of the bookmarks (where the bookmarks are displayed, i will use this term in the following bug report) on ff or chrome (linux system). But opening the bookmarks page on an iphone with chrome or safari does not show the content page. No error is raising up in the error.log. The access.log shows the updateList.php as the last called php script.

/index.php/apps/bookmarks/ajax/updateList.php?type=bookmark&tag=&page=1&sort=bookmarks_sorting_recent

If needed may be i can provide more information.

Kind regards

ChewyF5

set Wiki Categories and Language as tags, Wiki Introtext as description

When adding a Bookmark of a wiki like Wikipedia with the help of the Bookmarklet it would be very helpful if the app could set the Wiki Categories as tags and the Intro Text between Beginning and Table of Contents as description, additionally to HTML meta keywoeds=tags and description (see Issue #22).

Categories on On https://en.wikipedia.org/wiki/OwnCloud
- Free software for cloud computing,
- Free software programmed in JavaScript,
- Free software programmed in PHP,
- KDE software,
- KDE stubs
  The hidden categories or known internal like "* stubs" and like that could be ignored optionally.
The language is also given by subdomain en.wikipedia.org, so another tag language:en could be set as default.
Perhaps also all Parent-Categories of the mentioned Cats in hierachical tags (see below)? Like the Category Tree...
If the wikipedia page has an template it could also be hierachical tags like
- KDE:Applications:Internet:owncloud and
- Cloud computing:Applications:owncloud

Can't edit bookmark tags

When i try to edit bookmark tags and click save nothing happens. In log i see error:
Fatal PHP Call to a member function numRows() on a non-object at /var/www/owncloud/apps/bookmarks/lib/bookmarks.php#299

Can't edit bookmarks with long names in linux chromium-browser

Using Linux chromium-browser I cannot click the edit (pencil icon) on any bookmark with a long name (has the ... after it) but short named bookmarks work fine. The icon just stays grey as if it's not clickable. Issue #21 is more of a cosmetic issue, but possibly related? Using Firefox 21 or 22 on the same machine works fine.

Client:
Lubuntu 12.04.2
chromium-browser 25.0.1364.160

Server:
ownCloud 5.0.7
Ubuntu 12.04.2
apache 2.2.22
php 5.3.10
mysql-server 5.5.31

Edit: Tried this on another computer running same Lubuntu 12.04.2 and chromium and it works. PC not working is an EeePC 1000h (netbook 10" screen) and the other is a desktop with 19" monitor. Maybe screen size is problem? Closing the issue since I can't reproduce.

Register on remote.php ?

Hi,

Is there a good reason to access bookmarks only by index.php ? Register it on remote.php will be nice for API-like usage.
On yunohost for exemple, owncloud is protected by a lemonldap but the 2 remote.php and public.php are unmanage, but index.php is managed of course so we get SSO access and protection from lemonldap.
With the actual setting, it need to unprotect it for a sync usage with Android app. Not very good as if it's registering on remote.php look better.

Is there a chance to add this ?

Thanks,

Cédric

Bookmarks: automatically fetch favicon of page

The favicon of the page should be automatically fetched from the page (check how the News app does this)

add README.md

Would be useful to have a short README.md in the root folder with some info to get others started:

current maintainers (who to contact, who are the developers and designers?)
developer setup info, dependencies, special setup?
anything else?

You can use the readme of the Calendar app as template: https://github.com/owncloud/calendar

cc @eMerzh

[Minor problem] Group's contact list not updated after contact was removed from group

Modify group property of a contact, remove current group
Press Done
Contact list of current group is not refreshed (contact still in list)
Refresh works (e.g. click on group name in group list)

OC search does not work on bookmarks

I like the bookmark app however as a user I am finding that it is very hard to browse through bookmarks mainly because of the fact that the OC search functionality totally ignores the bookmarks.

Is this a bug or never intended to be part of search functionality?

thanks

[Enhancement] Have the ability to show more tags

Currently we only display a few tags in the side bar,
let's do something to display more tags than 10 and why not all ? :D

error in bookmark app

When click on the bookmarks-symbol I get the error message

Parse error: syntax error, unexpected 'var' (T_VAR), expecting ';' in /web/owncloud/owncloud/apps/bookmarks/templates/js_tpl.php on line 35

Occurred in the following configurations:

ownCloud 5.0.3
php v5.4.9
mysql 5.5.28
no 3rd party apps

PHP 5.3
OC 5.0.3
MySQL
Linux Debian Squeeze

Thread --> https://forum.owncloud.org/viewtopic.php?f=23&t=9000

Unable to modify bookmarks

I'm using owncloud 5.0.9 on Debian with the default SQLite backend. I'm using Chrome as my browser. When I go to edit a bookmark I can change the tags, but pressing save does nothing. I looked in the logs on my server and found the following:

[Sun Aug 18 17:41:34 2013] [error] [client 66.41.133.245] PHP Fatal error:  Call to a member function numRows() on a non-object in /home/httpd/html/owncloud/apps/bookmarks/lib/bookmarks.php on line 299, referer: https://mtu.net/owncloud/index.php/apps/bookmarks
[Sun Aug 18 17:41:34 2013] [error] [client 66.41.133.245] PHP Fatal error:  Call to a member function numRows() on a non-object in /home/httpd/html/owncloud/apps/bookmarks/lib/bookmarks.php on line 299, referer: https://mtu.net/owncloud/index.php/apps/bookmarks
[Sun Aug 18 17:41:34 2013] [error] [client 66.41.133.245] PHP Fatal error:  Call to a member function numRows() on a non-object in /home/httpd/html/owncloud/apps/bookmarks/lib/bookmarks.php on line 299, referer: https://mtu.net/owncloud/index.php/apps/bookmarks
[Sun Aug 18 17:41:34 2013] [error] [client 66.41.133.245] PHP Fatal error:  Call to a member function numRows() on a non-object in /home/httpd/html/owncloud/apps/bookmarks/lib/bookmarks.php on line 299, referer: https://mtu.net/owncloud/index.php/apps/bookmarks
[Sun Aug 18 17:41:34 2013] [error] [client 66.41.133.245] PHP Fatal error:  Call to a member function numRows() on a non-object in /home/httpd/html/owncloud/apps/bookmarks/lib/bookmarks.php on line 299, referer: https://mtu.net/owncloud/index.php/apps/bookmarks

set HTML meta keywords as tags and meta description as defaults

When setting a bookmark with bookmarklet it would be very helpful that the HTML meta values like
as OC description and
as tags
for the formular fields as defaults.

BTW, I miss that also on firefox or chrome and didn't have found an AddOn that has this feature....

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

longer bookmarknames

Although the webpage is wide enough, bookmarks will be cut off, so it is no not charming to use them. The matter can be fixed simply by a little hands on css i think.

a picture for better understanding

Filtering by tag doesn't show any bookmark

When I click on a tag, it doesn't show the bookmarks tagged with it.

Exemple before clicking on a tag:

After:

Allow Sorting

Expected behaviour :

The user might be able to sort his bookmarks by name, creation date, tag, ... (see Google Bookmarks or ownCloud Tasks). It would be nice if either a clickable columnheader or a series of buttons allows custum sort order.

ref owncloud-archive/apps#811

Handling of non-ASCII characters in URLs

Issue

For some years now it is allowed to have non-ASCII characters in URLs. If I enter such an URL, that contains german umlauts for example, to the bookmarks app they are converted to some replacement string.

Steps to reproduce

Add a new now bookmark with URL http://büh.net (URL does not exist, just a test case)
The URL is converted to http://b%C3%BCh.net
Edit the bookmark and change the "%C3%BC" back to "ü" again. This time it is saved like this.

Expected behavior

URLs should be saved as they are without any replacements or conversions.

System information

Server

OS: Debian 7
Web server: Apache 2.2.22
PHP: 5.4.4

Client

OS: Ubuntu 12.04 LTS
Browser: Firefox 22

rename "read it later" button in "Bookmarklet" window

Instead of "read it later" the button could be renamed as "Add to owncloud". There should also be an owncloud favicon which will be automatically saved in the bookmarklet-symbol strip. Having a "read it later" symbol in there doesn't make much of a sense to me. What's your opinion on that? Let me know!

cc @flause cc @laburramuge

Missing error handler

See #36. When this problem occurs, the client does not get any information that something went wrong.

The client should catch the error 500 and display an error message instead of completely ignoring the error.

organize bookmark grid view by month

We were thinking about a timeline structure that allows you to sort your bookmarks by month. What's your opinion on that design issue?
cc @flause cc @laburramuge

Saving bookmark fails w/o error if no description given

When creating (or saving an existing) bookmark the process fails without any indication of failure if no description is given.

Recommendation: make description optional.

grid view instead of list view for bookmarks

We are working on a grid view for the bookmarks category instead of a list view, because we think a that will make it more simple and attractive to browse the bookmarks. Our idea is to show the favicon or screenshot, titel, url, short description within every rectangle and showing the editing tools by hovering over them. In our opinion this will make the use of the bookmark tool more efficient than a list view. The list view wastes useful space. Do you have any comments on that issue? cc @laburramuge cc @flause

Collaborate with GNOME browser for bookmark sync

At GUADEC (the GNOME conference) I talked to @csaavedra about syncing the bookmarks with GNOME Web / Epiphany.

Since ownCloud is already in GNOME Online Accounts with Files, Calendar and Contacts, it would be cool to have »Bookmarks« added there too. @csaavedra can you talk to Debarshi/rishi about that? What do you need from us?

@eMerzh do we expose an API or a protocol at the moment? There’s some standard format for bookmarks, right?

Native bookmarks synchronization

I also really liked this proposal by "DeliveryBoy" http://forum.owncloud.org/viewtopic.php?f=4&t=9808 which might go halfway toward solving #13 for me. How close is this request to #2 and #5?

Summary:
I would appreciate to have an Extension, an Add-On or a Plug-In respectively; (whatever it is called for any browser) for automatically synchronizing my browser's native bookmarks with ownCloud. The idea is to have something like that for any major browsers like e.g. Safari, Firefox, Chrome, Opera and of course Internet Explorer — Are there any plans for developing such a piece of software?

I just stumbled over this existing software @ http://canisbos.com/cloudmarks — It does exactly what I want except it doesn't support ownCloud.

bookmark import failing

OC 5 fails to import my bookmark html-file that I exported from firefox.
Anyone else having problems?

When it happens, I only get

SQLSTATE[22001]: String data, right truncated: 7 ERROR:  value too long for type character varying(140) at [...]/lib/db.php#1031

in the log

From the bookmark app code I guess that's a problem with the bookmark title. Any particular reason the title does not have a maximum size of 4k, too?

Feature request - filter by no-tag

Would like the ability to have a view of all bookmarks that don't have tags set.

No refresh when tagging bookmark / "no tagged" filter

Hi,

Firstly I would like to congratulate all the contributors of OC. This project is awesome ;)

I have a lot of bookmarks (100 ~ 150)...
I started to tag them but I had to stop because each update refreshes the page and displays the first bookmarks. Then I have to scroll down and search the bookmarks without tags, it's very slow and frustating...

My proposed changes are :

Save changes for every update of bookmarks without refreshing,
or
Add a filter "without tag(s)" to update even refresh is still active.

Thanks for reading ;)

[Enhancement] Have a true sync API

Like delicious, Semantic Scuttle or anything else.. but let's a way to sync bookmarks

5.0.7: Bookmarks don't show anymore

After updating from 5.0.6 (or .5, I'm not sure) to 5.0.7 my bookmarks don't show up anymore (using Chrome). The tags are there and I can select them to filter, but there are no results. Not even the "You don't have any bookmarks" message, its just blank.

IE9 does't even show the tags, Firefox on Android has the same problem as Chrome, my desktop Firefox isn't willing to work right now, so I can't test it with it.

The Android ownCloud Bookmark Client seems to work fine.

There are no errors or simmilar in relevant logs (owncloud.log and Apache error_log).

OC 5.0.8: Bookmarks edit doesn't work anymore...

Since the update, I can't edit bookmarks anymore.

When I try to save modifications and tagg bookmarks (click on save button), nothing happens.

I found this error in apache2 error.log

PHP Fatal error: Call to a member function numRows() on a non-object in /var/www/owncloud/apps/bookmarks/lib/bookmarks.php on line 299

multiple tags dont work

when i add a bookmark with multiple tags, this is how it ends up in owncloud:

and when i search for the second tag:

Publish at http://apps.owncloud.com/

Go go go @eMerzh http://apps.owncloud.com/

Export button executes while being disabled

On the "Settings" sections the "Export" button executes it's function once pressed while being disabled (no bookmarks).

Exported file contains no bookmark and seems broken.

edit (Pencil) not clickable with narrow browser window

Owncloud 5.0.4
Bookmarks 0.3

If my browser window is narrower then ca. 1170px i am not able to click the edit button (Pencil) anymore.

Tested on:
Chromium 25.0.1364.160
Firefox 20.0
XUbuntu 12.10 (Xfce 4.10)

I don't think it matters but here are my screen setups that i use regularly, error occurred on both.

Screenconfig 1: 1920x1080
Screenconfig 2: 5120x1080 (2x 1080p, 1x 1280x1024)

Can't edit bookmarks through web interface

I've found that I can't edit any bookmarks through the web interface. I'm using ownCloud 5.0.11, Linux, mySQL, Apache, PHP 5.3.10, Firefox 17.0.9 ESR on Mac OS X 10.7, and connecting to ownCloud through SSL with a self-signed cert.

This is pretty easy to reproduce -- go to the Bookmarks app, add a new bookmark, and then try to add some tags to that bookmark after entering Edit mode with the pencil icon. The Save button does not respond. This happens for all bookmarks added through the bookmarklet as well -- it's not possible to edit them after they've been added. I've also tried this on Safari 6.0.5 with the same negative result.

The log has the following whenever I try to Save the bookmark through the web interface:

Fatal PHP Call to a member function numRows() on a non-object at /var/www/owncloud/apps/bookmarks/lib/bookmarks.php#299