Giter Site home page Giter Site logo

nextcloud / circles Goto Github PK

View Code? Open in Web Editor NEW
139.0 20.0 47.0 16.03 MB

๐Ÿ‘ช Create groups with other users on a Nextcloud instance and share with them

License: GNU Affero General Public License v3.0

PHP 68.21% JavaScript 31.60% CSS 0.06% Makefile 0.12% Shell 0.01%
circle nextcloud sharing hacktoberfest

circles's Introduction

Nextcloud Teams

Bring cloud-users closer together

Nextcloud Teams allow people to create their own groups of people/colleagues/friends. Those groups of people can then be used by any other app for sharing purpose.

The app was formerly named circles which is still used as internal identifier a lot.

Installation

The Teams app is installed and enabled by default.

Documentation

You can use the \Psr\Container\ContainerInterface, see dependency injection, to get the \OCA\Circles\CireclesManager class, see our API documentation for its interface.

Credits

App Icon by Madebyoliver under Creative Commons BY 3.0

circles's People

Contributors

artificialowl avatar azul avatar blizzz avatar carlschwan avatar come-nc avatar comradekingu avatar dependabot[bot] avatar juliushaertl avatar lukasreschke avatar max-nextcloud avatar mejo- avatar morrisjobke avatar nextcloud-bot avatar nextcloud-command avatar nickvergessen avatar oparoz avatar pvince81 avatar rakekniven avatar rullzer avatar scrutinizer-auto-fixer avatar silopolis avatar skjnldsv avatar solracsf avatar susnux avatar tcitworld avatar tcoupin avatar tortuetorche avatar valdnet avatar viniciuscb avatar wiswedel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

circles's Issues

Private circles (name and author) viewable by all users

I noticed that private circles are viewable by anyone on nextcloud (meaning the name and author). I think the name is misleading and people think those are private circles no one can see. Also they have no chance to verify that unless they have an extra account.

I've contacted few users on my nextcloud instance that have made "private" circles that were clearly not intended to be viewed by the others, and they were surprised to hear that anyone could see such circle exist.
I think either the name should be changed to something else or (preferable option) those private circles should not be viewable by anyone, unless invited to (so they are truly private).

hidden circle

An hidden circle is an open group that can be protected by a password. Users won't be able to find this Circle using Nextcloud search engine.

How do you assign a password?

Users won't be able to find this Circle using Nextcloud search engine?

People who are added to the hidden circle can still add files so what does this mean exactly?

This circle makes no sense can someone explain?

Adding new Circle: Duplicate and missing entries in circle type (twice private, twice personal, but now public or hidden)

Hi,

My issue

When I create a new circle, I type in the circle name and want to select the circle type afterwards.
I have the choice between:

  • create a personal circle
  • create a personal circle
  • create a private circle
  • create a private circle

So I can't select "public" or "hidden" circle in the drop down list:
grafik

Server configuration

Operating system: Linux nextcloud 4.4.0-83-generic #106-Ubuntu SMP Mon Jun 26 17:54:43 UTC 2017 x86_64

Web server: Apache/2.4.18 (Ubuntu) (apache2handler)

Database: mysql 5.7.18

PHP version: 7.0.18-0ubuntu0.16.04.1
Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, session, standard, apache2handler, smbclient, mysqlnd, PDO, xml, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, imagick, imap, intl, json, ldap, exif, mcrypt, mysqli, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, readline, redis, shmop, SimpleXML, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, libsmbclient, Zend OPcache

Nextcloud version: 12.0.0 - 12.0.0.29

Updated from an older Nextcloud/ownCloud or fresh install: Updated from NC11

Circles: 0.11.0

Error shown when opening pristine app

  1. Have Circles enabled
  2. Enter Circles app for the first time

circles-initial-error

Expected: do not show this not-error. (Instead show Karl Klammer aka Clippit asking you whether you need help writing a letter creating a cirlce :p)

Test on more environments

We currentl only run tests on 7.0 and sqlite.
We need to test on PHP 5.6 and 7.1 and using MySQL and PostgreSQL.

It should be simply a case of adding all these elements to the matrix in the Drones config file.

Add Scrutinizer

Scrutinizer is helpful in detecting common pattern and formatting mistakes.

Use display name instead of UID everywhere

  • Autocompletion in share sidebar
  • Owner name in circle list
  • Member name in member list

Should also add avatars (clickable with the new contacts menu) in the circle and member list.

Broken on MySQL

Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'SELECT c.id, c.name, c.description, c.type, c.creation, u.joined, u.level, u.status, o.user_id AS owner FROM oc_circles_circles c LEFT JOIN oc_circles_members u ON (c.id = u.circle_id) AND (u.user_id = ?), oc_circles_members o WHERE (c.id = o.circle_id) AND (o.level = ?) AND (((c.type = ?) AND (o.user_id = ?)) OR ((c.type = ?) AND ((u.level >= ?) OR (c.id = ?) OR (c.name = ?))) OR (c.type = ?) OR (c.type = ?)) GROUP BY c.id ORDER BY c.name ASC' with params ["lukas", 9, 1, "lukas", 2, 1, -1, "", 4, 8]: SQLSTATE[42000]: Syntax error or access violation: 1055 Expression #9 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'oc.o.user_id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

On c.nc.c

Send coverage report to analysers

In the scrutinizer config, in tools, add:

    external_code_coverage:
        timeout: 3600 # Timeout in seconds. 60 minutes

In drone, add a post test command

  - wget https://scrutinizer-ci.com/ocular.phar
  - php ocular.phar code-coverage:upload --format=php-clover tests/_output/coverage.xml
  - bash <(curl -s https://codecov.io/bash) -f tests/_output/coverage.xml -t ff710fa8-260c-4a61-bdd3-0771d6aea5b5

In the Readme, add

[![Code Coverage](https://scrutinizer-ci.com/g/nextcloud/circles/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/nextcloud/circles/?branch=master)

Documentation

https://docs.codecov.io/docs/about-the-codecov-bash-uploader

Impossible to login on Nextcloud

After a restart of the Docker container running Nextcloud 12, I'm not able to login on Nextcloud.

nc

I have theses errors on nextcloud log file :

503 Error: Class 'OCA\Circles\ShareByCircleProvider' not found
#0 [internal function]: {closure}(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#1 /nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php(105): call_user_func_array(Object(Closure), Array)
#2 /nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php(466): Sabre\Event\EventEmitter->emit('beforeMethod', Array)
#3 /nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php(254): Sabre\DAV\Server->invokeMethod(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#4 /nextcloud/remote.php(70): Sabre\DAV\Server->exec()
#5 /nextcloud/remote.php(167): handleException(Object(Error))
#6 {main}

Class 'OCA\Circles\ShareByCircleProvider' not found
#0 /nextcloud/lib/private/Share20/ProviderFactory.php(241): OC\Share20\ProviderFactory->getShareByCircleProvider()
#1 /nextcloud/lib/private/Share20/Manager.php(997): OC\Share20\ProviderFactory->getProviderForType(7)
#2 /nextcloud/apps/files_sharing/lib/MountProvider.php(74): OC\Share20\Manager->getSharedWith('dvalin', 7, NULL, -1)
#3 /nextcloud/lib/private/Files/Config/MountProviderCollection.php(108): OCA\Files_Sharing\MountProvider->getMountsForUser(Object(OC\User\User), Object(OC\Files\Storage\StorageFactory))
#4 /nextcloud/lib/private/Files/Filesystem.php(445): OC\Files\Config\MountProviderCollection->addMountForUser(Object(OC\User\User), Object(OC\Files\Mount\Manager))
#5 /nextcloud/lib/private/Cache/File.php(53): OC\Files\Filesystem::initMountPoints('dvalin')
#6 /nextcloud/lib/private/Cache/File.php(174): OC\Cache\File->getStorage()
#7 /nextcloud/lib/base.php(829): OC\Cache\File->gc()
#8 [internal function]: OC::{closure}(Object(OC\User\User), '')
#9 /nextcloud/lib/private/Hooks/EmitterTrait.php(99): call_user_func_array(Object(Closure), Array)
#10 /nextcloud/lib/private/Hooks/PublicEmitter.php(33): OC\Hooks\BasicEmitter->emit('\\OC\\User', 'postLogin', Array)
#11 /nextcloud/lib/private/User/Session.php(359): OC\Hooks\PublicEmitter->emit('\\OC\\User', 'postLogin', Array)
#12 /nextcloud/core/Controller/LoginController.php(257): OC\User\Session->completeLogin(*** sensitive parameters replaced ***)
#13 [internal function]: OC\Core\Controller\LoginController->tryLogin(*** sensitive parameters replaced ***)
#14 /nextcloud/lib/private/AppFramework/Http/Dispatcher.php(160): call_user_func_array(Array, Array)
#15 /nextcloud/lib/private/AppFramework/Http/Dispatcher.php(90): OC\AppFramework\Http\Dispatcher->executeController(Object(OC\Core\Controller\LoginController), 'tryLogin')
#16 /nextcloud/lib/private/AppFramework/App.php(114): OC\AppFramework\Http\Dispatcher->dispatch(Object(OC\Core\Controller\LoginController), 'tryLogin')
#17 /nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php(47): OC\AppFramework\App::main('OC\\Core\\Control...', 'tryLogin', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#18 [internal function]: OC\AppFramework\Routing\RouteActionHandler->__invoke(Array)
#19 /nextcloud/lib/private/Route/Router.php(299): call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array)
#20 /nextcloud/lib/base.php(1000): OC\Route\Router->match('/login')
#21 /nextcloud/index.php(40): OC::handleRequest()
#22 {main}

HTTP/1.1 503 Error: Class 'OCA\Circles\ShareByCircleProvider' not found
#0 [internal function]: {closure}(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#1 /nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php(105): call_user_func_array(Object(Closure), Array)
#2 /nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php(466): Sabre\Event\EventEmitter->emit('beforeMethod', Array)
#3 /nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php(254): Sabre\DAV\Server->invokeMethod(Object(Sabre\HTTP\Request), Object(Sabre\HTTP\Response))
#4 /nextcloud/remote.php(70): Sabre\DAV\Server->exec()
#5 /nextcloud/remote.php(167): handleException(Object(Error))
#6 {main}

Before the restart of the Docker container "Circles" app was activated.
Currently "Circles" app is not installed because by default after a restart the Docker container don't include this application.

Managing Moderator / Owner

Rights should be: Member / Moderator / Admin / Owner
Moderator can invite Members,
Admin can make any Members a Moderator
Owner can make any Members an Admin and delete the circle.

  • Owner should be able to make any Member a Moderator
  • Owner should be able to give Owner right to anyone and step down himself as an Admin ?)

Difference between personal, hidden, and private circles?

I just installed NC 12 and enabled the circles app. Without digging into the documentation it is not clear:

  • What is the difference between the types of circles (there is only an explanation for personal circles)?
  • How do I create a circle other than personal?
    screenshot from 2017-05-08 23-39-39
    Both buttons ("create personal circle" and "creation") create a personal circle. If I click on "hidden circles" first, this doesn't create a hidden circle when I'm clicking the "creation" button after.

Do I need other apps to be enabled to make this work properly?
Enabled:

  • activity: 2.5.1
  • admin_audit: 1.2.0
  • admin_notifications: 1.0.0
  • calendar: 1.5.2
  • circles: 0.9.5
  • comments: 1.2.0
  • contacts: 1.5.3
  • dav: 1.3.0
  • deck: 0.1.4
  • federatedfilesharing: 1.2.0
  • federation: 1.2.0
  • files: 1.7.2
  • files_accesscontrol: 1.2.3
  • files_automatedtagging: 1.2.2
  • files_external: 1.3.0
  • files_markdown: 1.0.1
  • files_pdfviewer: 1.1.1
  • files_reader: 1.0.4
  • files_retention: 1.1.2
  • files_sharing: 1.4.0
  • files_texteditor: 2.4.1
  • files_trashbin: 1.2.0
  • files_versions: 1.5.0
  • files_videoplayer: 1.1.0
  • firstrunwizard: 2.1
  • gallery: 17.0.0
  • groupfolders: 1.0.2
  • issuetemplate: 0.2.1
  • logreader: 2.0.0
  • lookup_server_connector: 1.0.0
  • mail: 0.6.4
  • news: 11.0.0
  • nextcloud_announcements: 1.1
  • notes: 2.2.0
  • notifications: 2.0.0
  • password_policy: 1.2.2
  • previewgenerator: 1.0.6
  • provisioning_api: 1.2.0
  • serverinfo: 1.2.0
  • sharebymail: 1.2.0
  • socialsharing_email: 1.0.1
  • systemtags: 1.2.0
  • tasks: 0.9.5
  • theming: 1.3.0
  • twofactor_backupcodes: 1.1.0
  • twofactor_totp: 1.3.0
  • twofactor_u2f: 1.2.0
  • updatenotification: 1.2.0
  • user_external: 0.4
  • workflowengine: 1.2.0

rewrite Mappers

CircleMapper and MemberMapper needs a rewrite and be more like the CircleProviderRequestBuilder

Button to confirm a request

Right now, private circle admin have to write down the name of the user that are requesting to join the circle. Replace this by a simple button .

Error enabling app on PostgreSQL

When trying to enable the Circles app, I get

Error: this app cannot be enabled because it makes the server unstable

I tried this on my production install and on a completely fresh install with the same result.
I'm using PostgreSQL 9.6.2

This is what the log shows:

Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'SELECT s.*, "f"."fileid", "f"."path", "f"."permissions" as "f_permissions", "f"."storage", "f"."path_hash", "f"."parent" as "f_parent", "f"."name", "f"."mimetype", "f"."mimepart", "f"."size", "f"."mtime", "f"."storage_mtime", "f"."encrypted", "f"."unencrypted_size", "f"."etag", "f"."checksum", "s2"."id" as "parent_id", "s2"."file_target" as "parent_target", "s2"."permissions" as "parent_perms", "st"."id" AS "storage_string_id" FROM "oc_share" s LEFT JOIN "oc_filecache" f ON "s"."file_source" = "f"."fileid" LEFT JOIN "oc_share" s2 ON ("s"."id" = "s2"."parent") AND ("s2"."share_with" = ?) LEFT JOIN "oc_storages" st ON "f"."storage" = "st"."numeric_id", "oc_circles_members" m WHERE ("s"."share_type" = ?) AND (("s"."item_type" = ?) OR ("s"."item_type" = ?)) AND ("s"."share_with" = "m"."circle_id") AND ("m"."user_id" = ?) AND ("m"."level" >= ?) OFFSET 0' with params ["user", 7, "file", "folder", "user", 1]: SQLSTATE[42883]: Undefined function: 7 ERROR: operator does not exist: character varying = integer LINE 1: ... OR ("s"."item_type" = $4)) AND ("s"."share_with" = "m"."cir... ^ HINT: No operator matches the given name and argument type(s). You might need to add explicit type casts.

/var/www/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php - line 128: Doctrine\DBAL\Driver\AbstractPostgreSQLDriver->convertException('An exception oc...', Object(Doctrine\DBAL\Driver\PDOException))
/var/www/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php - line 855: Doctrine\DBAL\DBALException driverExceptionDuringQuery(Object(Doctrine\DBAL\Driver\PDOPgSql\Driver), Object(Doctrine\DBAL\Driver\PDOException), 'SELECT s.*, "f"...', Array)
/var/www/lib/private/DB/Connection.php - line 192: Doctrine\DBAL\Connection->executeQuery('SELECT s.*, "f"...', Array, Array, NULL)
/var/www/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php - line 206: OC\DB\Connection->executeQuery('SELECT s.*, "f"...', Array, Array)
/var/www/lib/private/DB/QueryBuilder/QueryBuilder.php - line 213: Doctrine\DBAL\Query\QueryBuilder->execute()
/var/www/apps/circles/lib/ShareByCircleProvider.php - line 413: OC\DB\QueryBuilder\QueryBuilder->execute()
/var/www/lib/private/Share20/Manager.php - line 1002: OCA\Circles\ShareByCircleProvider->getSharedWith('user', 7, NULL, -1, 0)
/var/www/apps/files_sharing/lib/MountProvider.php - line 74: OC\Share20\Manager->getSharedWith('user', 7, NULL, -1)
/var/www/lib/private/Files/Config/MountProviderCollection.php - line 108: OCA\Files_Sharing\MountProvider->getMountsForUser(Object(OC\User\User), Object(OC\Files\Storage\StorageFactory))
/var/www/lib/private/Files/Filesystem.php - line 445: OC\Files\Config\MountProviderCollection->addMountForUser(Object(OC\User\User), Object(OC\Files\Mount\Manager))
/var/www/lib/private/Files/Filesystem.php - line 374: OC\Files\Filesystem initMountPoints('user')
/var/www/lib/private/legacy/util.php - line 280: OC\Files\Filesystem init('user', '/user/files')
/var/www/lib/base.php - line 999: OC_Util setupFS()
/var/www/index.php - line 40: OC handleRequest()
{main}

Make the app translateable

The app needs to be translatable.

  • Make sure there are no hardcoded messages
  • Add Transifex support

Morris can help with Transifex.

syntax error, unexpected 'new' (T_NEW), expecting identifier (T_STRING)

Immediately after running the application it throws error 500

{"reqId":"0IcRJmNvNsHvoTNAQUcW","level":3,"time":"2017-05-09T23:59:50+00:00","remoteAddr":"80.9xxxx","user":"Laupe","app":"PHP","method":"GET","url":"\/apps\/circles\/","message":"syntax error, unexpected 'new' (T_NEW), expecting identifier (T_STRING) at \/home\/apps\/cloud\/apps\/circles\/lib\/Service\/SharesService.php#65","userAgent":"Mozilla\/5.0 (Windows NT 6.3; WOW64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/57.0.2987.133 Safari\/537.36","version":"12.0.0.18"}

Reshare+Personal Circle

when resharing to a personal circle, Owner of the file can see the name of the circle.

Might be better to hide the name, but still display that a personal circle reshare his file (with the name of the owner

Cron & Orphans

A Background job should check the database and remove orphans:

  • removed user in circles
  • removed circles in shares

Delete a circle

A user should be able to delete a circle. Or if they already can, it should be more obvious :P

User still in circles after deletion from userlist

If you add an user into a circle the admin deletes it from the userlist, the user in the circle is still there.
Then if the User with the same Username is readded, even he might be another person, he will get the shares you did via the circles.

Expectation: if the admin deletes the user, he must be removed from all circles, or the new user with the same username will see shares, which might not his/her business.

Missing field for adding new user after update to 0.11.0

Hi,

thank all of you for such a nice app.

After update to 0.11.0, I can't find the field to add a new user to the circle.

The browser (firefox/chromium) logs show nothing important.

Thanks, the server info is bellow:

Server configuration

Operating system: Linux 4.4.0-42-generic #62-Ubuntu SMP Fri Oct 7 23:11:45 UTC 2016 x86_64

Web server: nginx/1.13.1 (fpm-fcgi)

Database: pgsql PostgreSQL 9.6.3 on x86_64-pc-linux-musl, compiled by gcc (Alpine 6.2.1) 6.2.1 20160822, 64-bit

PHP version: 7.1.6
Modules loaded: Core, date, libxml, openssl, pcre, sqlite3, zlib, ctype, curl, dom, fileinfo, filter, gd, hash, iconv, json, mbstring, SPL, PDO, pdo_sqlite, bz2, posix, readline, Reflection, session, SimpleXML, standard, tokenizer, xml, xmlreader, xmlwriter, mysqlnd, cgi-fcgi, apcu, Phar, exif, ftp, gmp, intl, ldap, mcrypt, mysqli, pcntl, pdo_mysql, pdo_pgsql, pgsql, zip, redis, smbclient, libsmbclient, Zend OPcache

Nextcloud version: 12.0.0 Build:2017-06-14T07:34:13+00:00 426a4c11d6700f011897d17330f2364f1c9b04ee - 12.0.0.29

Where did you install Nextcloud from: Docker image wonderfall/nextcloud:daily

List of activated apps:

App list
Enabled:
 - activity: 2.5.2
 - admin_audit: 1.2.0
 - admin_notifications: 1.0.0
 - announcementcenter: 3.1.0
 - audioplayer: 2.0.2
 - bookmarks: 0.10.0
 - bruteforcesettings: 1.0.2
 - calendar: 1.5.3
 - checksum: 0.3.4
 - circles: 0.11.0
 - comments: 1.2.0
 - contacts: 1.5.3
 - dav: 1.3.0
 - deck: 0.2.0
 - drawio: 0.8.8
 - federatedfilesharing: 1.2.0
 - federation: 1.2.0
 - files: 1.7.2
 - files_accesscontrol: 1.2.4
 - files_downloadactivity: 1.1.1
 - files_external: 1.3.0
 - files_markdown: 1.0.1
 - files_opds: 0.8.2
 - files_pdfviewer: 1.1.1
 - files_reader: 1.0.4
 - files_sharing: 1.4.0
 - files_texteditor: 2.4.1
 - files_trashbin: 1.2.0
 - files_versions: 1.5.0
 - files_videoplayer: 1.1.0
 - firstrunwizard: 2.1
 - gallery: 17.0.0
 - gpxedit: 0.0.6
 - gpxpod: 2.1.2
 - groupfolders: 1.0.2
 - impersonate: 1.0.1
 - issuetemplate: 0.2.1
 - logreader: 2.0.0
 - lookup_server_connector: 1.0.0
 - mail: 0.6.4
 - mood: 0.2.0
 - news: 11.0.5
 - nextant: 1.0.8
 - nextcloud_announcements: 1.1
 - notes: 2.2.0
 - notifications: 2.0.0
 - oauth2: 1.0.5
 - ocsms: 1.12.0
 - ownbackup: 17.5.0
 - passman: 2.1.2
 - password_policy: 1.2.2
 - provisioning_api: 1.2.0
 - qownnotesapi: 17.5.0
 - quota_warning: 1.0.0
 - registration: 0.2.3
 - richdocuments: 1.12.33
 - serverinfo: 1.2.0
 - sharebymail: 1.2.0
 - socialsharing_diaspora: 1.0.1
 - socialsharing_email: 1.0.1
 - socialsharing_facebook: 1.0.1
 - socialsharing_googleplus: 1.0.1
 - socialsharing_twitter: 1.0.1
 - spreed: 2.0.1
 - survey_client: 1.0.0
 - systemtags: 1.2.0
 - tasks: 0.9.5
 - telephoneprovider: 1.0.0
 - theming: 1.3.0
 - twofactor_backupcodes: 1.1.1
 - twofactor_totp: 1.3.0
 - twofactor_u2f: 1.3.2
 - updatenotification: 1.2.0
 - weather: 1.4.2
 - workflowengine: 1.2.0
 - workin2gether: 0.9.6

Disabled:
 - apporder
 - encryption
 - external
 - files_snapshots
 - keeweb
 - ojsxc
 - ownpad
 - previewgenerator
 - rainloop
 - user_external
 - user_ldap

Are you using encryption: no

Client configuration

Browser:

  • Mozilla Firefox: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
  • Chromium: Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Operating system: Fedora Rawhide

Add tests

All methods should be unit tested.
We should also have some integration tests for the most common use-cases.

Results should be sent to Scrutinizer

Send notifications on circle invitation

By now, a user is not notified when she has been invited in a private circle. This is something that I expected because Nextcloud sends mail about many activities.

Missing icons...

I'm missing some icons within the circle app. The icon for adding members to a circle isn't in place (see screenshot) but clicking there opens an input field. I'm having this effect on two different nextcloud installations with two different browsers (Firefox, Chrome).
Any hints?
Regards
Juergen

2017-07-04 08_30_39-nextcloud

Auto-Add Memebers to public circles based on groups

I would love to see an option to automatically add users to public circles if they are member of a specific group.
This option should only be available to admins.
Auto-added users should not be able to leave a circle or be removed from it in any way if this option is used for a specific circle.

e.g. One could add a Circle called "NC Admins" and select "admin" group then every member of "admin" group is automatically member of that circle.

Circles does work correctly with spaces in the name

I created two circles like this:

  • proj mgt
  • proj mgt read only

After the succesful creation and addition of users, I assigned the circles to the same directory.

As one circle should be read only and the other should have all the read only must be modified after sharing directory.

Each time I wanted to change the "proj mgt read only" the other circle "proj mgt" was selected / changed.

I worked around this behavior using underscores for spaces:

  • proj_mgt
  • proj_mgt_read_only

When spaces are allowed (I hope) make it work. When spaces (and perhaps other characters are not allowe d in names), prevent the creation of circle names with unwanter/not working characters.

Syntax error or access violation: 1055 Expression #9 of SELECT list is not in GROUP BY clause

Hi Devs.

Great idea the circles!

Right now i am not able to create a circle. Error messages:

{"reqId":"VSsAmL48M5GNd2wrO0BE","level":3,"time":"2017-05-02T14:27:19+00:00","remoteAddr":"151.","user":"hoppla","app":"index","metho
d":"GET","url":"/index.php/apps/circles/circles?type=all&name=&level=0","message":"Exception: {"Exception":"Doctrine\\DBAL\\Exception\\DriverException","Message":"An exception occurred while executing 'SELECT c.id, c.name, c.description, c.type, c.creation, u.joined, u.level, u.status, o.user_id AS owner FROM oc_circles_circles c LEFT JOIN oc_circles_members u ON (c.id = u.circle_id) AND (u.user_id = ?), oc_circles_members o WHERE (c.id = o.circle_id) AND (o.level = ?) AND (((c.type = ?) AND (o.user_id = ?)) OR ((c.type = ?) AND ((u.level >= ?) OR (c.id = ?) OR (c.name = ?))) OR (c.type = ?) OR (c.type = ?)) GROUP BY c.id ORDER BY c.name ASC' with params [\"hoppla\", 9, 1, \"hoppla\", 2, 1, -1, \"\", 4, 8]:\n\nSQLSTATE[42000]: Syntax error or access violation: 1055 Expression #9 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'nextcloud.o.user_id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by","Code":0,"Trace":"#0 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/3rdparty\/doctrine\/dbal\/lib\/Doctrine\/DBAL\/DBALException.php(128): Doctrine\\DBAL\\Driver\\AbstractMySQLDriver->convertException('An exception oc...', Object(Doctrine\\DBAL\\Driver\\PDOException))\n#1 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/3rdparty\/doctrine\/dbal\/lib\/Doctrine\/DBAL\/Connection.php(855): Doctrine\\DBAL\\DBALException::driverExceptionDuringQuery(Object(Doctrine\\DBAL\\Driver\\PDOMySql\\Driver), Object(Doctrine\\DBAL\\Driver\\PDOException), 'SELECT c.id...', Array)\n#2 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/lib\/private\/DB\/Connection.php(192): Doctrine\\DBAL\\Connection->executeQuery('SELECT c.id...', Array, Array, NULL)\n#3 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/3rdparty\/doctrine\/dbal\/lib\/Doctrine\/DBAL\/Query\/QueryBuilder.php(206): OC\\DB\\Connection->executeQuery('SELECT c.id...', Array, Array)\n#4 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/lib\/private\/DB\/QueryBuilder\/QueryBuilder.php(213): Doctrine\\DBAL\\Query\\QueryBuilder->execute()\n#5 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/apps\/circles\/lib\/Db\/CirclesMapper.php(76): OC\\DB\\QueryBuilder\\QueryBuilder->execute()\n#6 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/apps\/circles\/lib\/Service\/CirclesService.php(142): OCA\\Circles\\Db\\CirclesMapper->findCirclesByUser('hoppla', 15, '', 0)\n#7 \\\/var\\\/www\\\/nextcloud.dev.hoppla.de\\\/htdocs\\\/apps\\\/circles\\\/lib\\\/Controller\\\/CirclesController.php(75): OCA\\Circles\\Service\\CirclesService->listCircles(15, '', '0')\n#8 [internal function]: OCA\\Circles\\Controller\\CirclesController->listing('all', '', '0')\n#9 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/lib\/private\/AppFramework\/Http\/Dispatcher.php(160): call_user_func_array(Array, Array)\n#10 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/lib\/private\/AppFramework\/Http\/Dispatcher.php(90): OC\\AppFramework\\Http\\Dispatcher->executeController(Object(OCA\\Circles\\Controller\\CirclesController), 'listing')\n#11 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/lib\/private\/AppFramework\/App.php(114): OC\\AppFramework\\Http\\Dispatcher->dispatch(Object(OCA\\Circles\\Controller\\CirclesController), 'listing')\n#12 \/var\/www\/nextcloud.dev.hoppla.de\/htdocs\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php(47): OC\\AppFramework\\App::main('CirclesControll...', 'listing', Object(OC\\AppFramework\\Dependency

Types of circles incorrect (0.11.0)

Choosing a type on creation of a circle leads to a combo dialog which let's you choose between 4 entries. The first/second and the third/fourth entry are equal named (see picture). It's just the names which are wrong, I can choose all of the four different types

Regards
Juergen

circletypes

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.