Giter Site home page Giter Site logo

Comments (12)

eibex avatar eibex commented on June 25, 2024 1

Did you just set up the E2EE for the first time? Or did you have it set up, with some encrypted folders already uploaded, and then just updated to 3.12?

I've been using E2EE for 2-3 years now, so the encrypted folders have been created years ago. I will try to upload the logs when I get back home. I can confirm that downgrading back to 3.11.1 does not create an error and allows the program to sync files with the server.

from desktop.

eibex avatar eibex commented on June 25, 2024 1

I have uploaded a censored version of the logs. I removed irrelevant data and folder names.

from desktop.

allexzander avatar allexzander commented on June 25, 2024 1

Client syncing as expected. Tried to upload some new e2ee files in the existing folders and it worked too. Thanks!

How would you recommend to update existing folders? Would the easiest way be to delete and reupload them?

I recommend making a backup of these files somewhere else on your machine, then, add some dummy text file (or any file, or do the rename inside those folders), and wait till the client uploads them to the server. Then, install normal 3.12, then uncheck those folders (that had issues) in the selective sync dialog, apply the changes, and wait for sync. Then recheck them and apply. Make sure errors are not present anymore. You will be able to use 3.12 with your folders from that moment. When we release the fix you tested in 3.12.1, you will just update normally.

You can just keep using 3.11 until we have released an update 3.12.1, and do nothing for now.

Many thanks for spending your time testing it.

from desktop.

allexzander avatar allexzander commented on June 25, 2024

@eibex Could you please reproduce this again and upload client logs to https://cloud.nextcloud.com/s/9FDMAf99KNxZTyy?
Seems not so easy to reproduce. I tried 2 scenarios:

  • setting up E2EE with desktop client 3.12 with VFS on and a server 28.0.2, created a folder, uploaded some files and nested folders, it syncs fine afterwads
  • setting up E2EE with the older desktop client and creating a folder - works too later with 3.12

Did you just set up the E2EE for the first time? Or did you have it set up, with some encrypted folders already uploaded, and then just updated to 3.12?

from desktop.

allexzander avatar allexzander commented on June 25, 2024

@eibex I was able to reproduce. Based on your information and longs, indeed, you have some folders with version 1.1 metadata, that were created a long time ago. The new release 3.12 failed to decrypt those due to a condition. I came up with a solution that should fix the problem. Could you give this build a try https://cloud.nextcloud.com/s/3Z8CZHzxdqTKBRo and let me know if the issue is still present with it? It's a 3.12.50 dev build with my changes on top of 3.12.

from desktop.

eibex avatar eibex commented on June 25, 2024

Hi, thanks for the quick PR.
Sadly the linked build did not fix the issue. I'm uploading nc_log2.txt with the latest logs (they seem very similar to the originals).

I scanned previous logs too and didn't find any lines related to updating metadata to v2? (I don't know C++ but from the linked PR I believe files should be migrated to v2 with a log line Migrating from or Could not migrate. No metadata keys found! - correct me if I'm wrong).

from desktop.

eibex avatar eibex commented on June 25, 2024

Apologies for the additional comment, I just wanted to ask if you'd like me to keep the folders as they are to keep troubleshooting or whether I should recreate them so that I can circumvent the bug.

I have no problems in keeping them as they are to help fixing the bug as I have the decrypted files backed up elsewhere.

from desktop.

allexzander avatar allexzander commented on June 25, 2024

@eibex Kindly keep them. I know a workaround, but the fix is coming in a few hours.

from desktop.

allexzander avatar allexzander commented on June 25, 2024

@eibex I was able to find one more overlook for dealing with version 1.1 (the one you have in your metadata) and added a fix, and also made logs more verbose temporarily, the build to try is here https://cloud.nextcloud.com/s/Y6MEwPYAtXmiNgm, hopefully, this time I managed to catch it. If not, please attach the log, as I said, it is much more verbose, so I will have a better picture than I have now.

Btw, by design, we do not auto-migrate folders that contain nested folders. This will only happen if you change something. So, if the last build does not work, the workaround would be to do the change within the encrypted folder while running version 3.11 and having it upload the change. Then, version 3.12 will work with that folder too as it will be 1.2.

from desktop.

eibex avatar eibex commented on June 25, 2024

Client syncing as expected. Tried to upload some new e2ee files in the existing folders and it worked too. Thanks!

How would you recommend to update existing folders? Would the easiest way be to delete and reupload them?

from desktop.

russtaylor avatar russtaylor commented on June 25, 2024

Thanks so much! I noticed that I was having the same error yesterday, and was happy to find out that the fix was already in progress.

And thanks eibex for reporting the issue & testing the fixed build!

from desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.