Actions menu in sharing sidebar empty for guests

[nextcloud]

Actions menu in sharing sidebar empty for guests

[nickvergessen]

well if the guest account has an email it should allow sending an email (maybe you want to warn them that you are going to unshare the item or something?) and Talk should show up normally if the guest accounts can use Talk.

Just as a note, this is not about "unregistered guest users" it's about "guest users" which can be created by anyone and the guests can login and use a subset of apps.

So no real reason this should not work.

I guess it is due to the check if the user comes from the system address book:
https://github.com/nextcloud/spreed/blob/master/lib/ContactsMenu/Providers/CallProvider.php#L67

this is okay for the contacts menu in the top right, but not for the user context menu everywhere else

[skjnldsv]

There is no action for a guest, so yes.
What do they expect @wiswedel ?

[wiswedel]

sharee's clickable email address and (if installed) a hook to a Talk conversation

why not for guests? @skjnldsv

[skjnldsv]

@wiswedel not supported I guess?, otherwise it would be in the menu.
The menu is based on an api that generate directly based on what actions are available on an entity. :)

[wiswedel]

@skjnldsv When it's available for all other types of users except for guests, it seems more like a lose end than deliberately not supported, wouldn't you agree?

[skjnldsv]

@wiswedel no idea really :)
I'm not really thinking about why it is not implemented, but just stating that your issue is not a bug, but just a missing feature.
The action menu is behaving properly 😉

[skjnldsv]

@icewind1991 any thoughts?
cc @nickvergessen & @danxuliu for the spreed part
Also @ChristophWurst for mail :)

[skjnldsv]

Yes it make sense!

[nickvergessen]

So, I tested this a bit, and if the guest users go to the personal settings and e.g. change their display name, they are stored to the system address book and all apps work as expected.

So the problem is, that initially the guests are not registered to the system address book.
This is also the case for the account manager. The problem is that no hooks are triggered on creation. Fixing this should be enough. (and it would also allow to log it in the admin audit log which is currently missing)

But that is out of my knowledge, maybe @icewind1991 can have a look?

[wiswedel]

CC @blizzz