Giter Site home page Giter Site logo

Password change is disabled about guests HOT 4 CLOSED

nextcloud avatar nextcloud commented on May 26, 2024
Password change is disabled

from guests.

Comments (4)

sushifrick avatar sushifrick commented on May 26, 2024

Same problem here,

we are sending users to a separate webinterface to manage their passwords using the lost_password_link configuration-option. When this option is set the guest will see the mentioned error message when she tries to set up her account.

As guests always use local (DB) accounts, they should circumvent the lost_password_link in my opinion.

Kind regards,
Sascha

from guests.

ChristophWurst avatar ChristophWurst commented on May 26, 2024

The logic is in https://github.com/nextcloud/server/blob/master/core/Controller/LostController.php. We have the user ID there, so it should be possible to somehow determine if password reset should still be possibly. The question is how. We should likely not check for the guests app directly but ask the user back-end if password reset is allowed or not.

from guests.

blizzz avatar blizzz commented on May 26, 2024

In LostController::resetform() and LostController::setPassword() we might move it behind the token verification check. These methods are not the entry point for the password reset mechanism, so it is even considerable to remove them. Otherwise, we "reset is disabled" page can be shown when no token is present. This should be good enough to cater for special cases like these. This has to be done in server though, so not specific to the guests app.

from guests.

blizzz avatar blizzz commented on May 26, 2024

Proposed fix at nextcloud/server#28794

from guests.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.