nextcloud/nextcloud-filelink

:envelope: :outbox_tray: "Nextcloud for Filelink" is a Thunderbird extension which makes it easy to send large attachments with Thunderbird by uploading them first to a Nextcloud server and by then inserting the link into the body of your email.

Nextcloud for Filelink

Description

Nextcloud is the premiere and safest, Enterprise-ready, Open Source File Sync and Share solution

"Nextcloud for Filelink" is a Thunderbird extension which makes it easy to send large attachments with Thunderbird by uploading them first to a Nextcloud server and by then inserting the link into the body of your email.

It is currently possible to upload files as large as 1GB.

Maintainers

• Guillaume Viguier-Just (@guillaumev)
• Olivier Paroz (@oparoz)

Alumni

• Philipp Kewisch
• Mark James

Installation

1. Zip all files located in the src folder such that the install.rdf and chrome.manifest are located in the root folder of the zip file
2. Change the file extension from .zip to .xpi
3. Open your Thunderbird, navigate to Tools -> Add-Ons, choose "Install Add-On From File..." and select the .xpi file
4. After installation restart Thunderbird

Nextcloud configuration

1. Make sure that you have checked "Allow users to share via link" in the "Sharing" section of the admin page of your Nextcloud installation. If you have also checked-in the "Enforce password protection" option, make sure to fill the "Password for uploaded files" field when setting up the add-on in Thunderbird
2. By default your mail attachments will be saved in a folder called Mail-attachments.

Note: It's also possible to use a different folder name. Simply type the name of the folder you want to use when setting up the provider in Thunderbird

Thunderbird configuration

1. Navigate to Edit -> Preferences -> Attachments
2. Choose the Outgoing tab
3. Click the Add button. The "Set up Filelink" panel will open.
4. Select the desired service provider from the drop-down list.
5. Select Nextcloud from the list and type in the URL to your server as well as your login and password

Note: If you want to send your email attachments to a different folder, you will have to modify the path given in "Storage path"

Once setup is complete, Thunderbird will always ask you if you want to upload big attachments to Nextcloud.

Requirements

• Nextcloud: 11.0.2 and newer
• Thunderbird: 17.0 and newer

Known issues

• It's not possible to use the same Filelink provider more than once
• You can only create public links
• Public links will always have the same password
• You cannot edit your Filelink account. You have to delete and re-create it if you need a change (password, folder, link password, port, etc.)

Best ask for help on our forums.

License

Licensed under the GNU AGPL version 3 or any later version

Contribution Guidelines

All contributions to this repository from February, 10 2017 on are considered to be licensed under the AGPLv3 or any later version.

"Nextcloud for Filelink" doesn't require a CLA (Contributor License Agreement). The copyright belongs to all the individual contributors. Therefore we recommend that every contributor adds following line to the header of a file, if they changed it substantially:

@copyright Copyright (c) <year>, <your name> (<your email address>)

Please read the Code of Conduct. This document offers some guidance to ensure Nextcloud participants can cooperate effectively in a positive and inspiring atmosphere, and to explain how together we can strengthen and support each other.

More information how to contribute: https://nextcloud.com/contribute/

nextcloud-filelink's Issues

module update break configuration

Bug report

Steps to reproduce

1. start thunderbird after updating filelink module

Expected behaviour

work

Actual behaviour

don't work, the configuration was deleted, like a new installation

Desktop configuration

Operating system: Ubuntu 14.04

Thunderbird version: 52

Updated from an older installation or fresh install: updated

Directly send the link if already synced with Nextcloud

Feature request

Today, if I want to send a document that is already synced on NC, it copies it in the MailAttachment folder, and then sends the link.

It should recognize if the file is already in a folder synchronized by Nextcloud, and only create and send the link, without copying the file in the MailAttachment folder.

Password should be provided in the email sent

Bug report

Steps to reproduce

1. set up nextcloud filelink with "password for uploaded files" set
2. send an email with an filelink attachement

Expected behaviour

The password to access the file should be provided in the sent email. Otherwise recipients can't see the attachement.

Actual behaviour

The password is not given in the email.

Desktop configuration

Operating system: Debian Jessie

Thunderbird version: Icedove 45.6.0

does not work when nextcloud in subdir

Bug report

Unable to connect to server when the domain includes a subdir path.

I believe the problem is that the script concatenates this._serverUrl + ":" + this._serverPort. (See the Thunderbird log below, it clearly shows the malformed URI.)

Suggestion, either:

1. Remove the field to type in the port number, regex-ing it out or assuming that URI defaults will suffice; this requires the user to manually add non-standard ports (which is a safe default, IMO);
2. Add another field, "nextcloud directory installation", so my config would be: domain https://mydomain.com, port 443, subdir /cloud.

I hacked the code and removed all references to + ":" + _serverPort in src/components/nsNextcloud.js, and I was able to configure the connection. It was a hack and I'm having other issues, but this hack got me past the account setup.

Steps to reproduce

1. Install nextcloud in a subdir, e.g., https://mydomain.com/nc/
2. Configure nextcloud-filelink with domain https://mydomain.com/nc and port 443

Expected behaviour

Network connection made to the server, authentication passes, filelink account created.

Actual behaviour

No connection is made with the server (logs show no attempt).

Server configuration

Operating system: ubuntu-16.04.4

Web server: nginx-1.10.3-0+trusty0

Database: pg

PHP version: php-7.0

Nextcloud version: 11.0.3.2

Updated from an older installation or fresh install: fresh

List of activated apps:

App list

$ sudo -u www-data php occ app:list
Enabled:
  - activity: 2.4.1
  - admin_audit: 1.1.0
  - calendar: 1.5.3
  - comments: 1.1.0
  - contacts: 1.5.3
  - dav: 1.1.1
  - federatedfilesharing: 1.1.1
  - federation: 1.1.1
  - files: 1.6.1
  - files_pdfviewer: 1.0.1
  - files_retention: 1.0.1
  - files_sharing: 1.1.1
  - files_texteditor: 2.2
  - files_trashbin: 1.1.0
  - files_versions: 1.4.0
  - files_videoplayer: 1.0.0
  - firstrunwizard: 2.0
  - gallery: 16.0.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.0.0
  - nextcloud_announcements: 1.0
  - notifications: 1.0.1
  - password_policy: 1.1.0
  - provisioning_api: 1.1.0
  - serverinfo: 1.1.1
  - sharebymail: 1.0.1
  - survey_client: 0.1.5
  - systemtags: 1.1.3
  - templateeditor: 0.2
  - theming: 1.1.1
  - twofactor_backupcodes: 1.0.0
  - updatenotification: 1.1.1
  - user_ldap: 1.1.2
  - workflowengine: 1.1.1
Disabled:
  - encryption
  - external
  - files_accesscontrol
  - files_automatedtagging
  - files_external
  - user_external
  - user_saml

The content of config/config.php:

Config report

# sudo -u www-data php occ config:list system
{
    "system": {
        "redis": {
            "host": "redis",
            "port": 6379
        },
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "mydomain.com"
        ],
        "datadirectory": "\/var\/lib\/nextcloud\/ocdata",
        "overwrite.cli.url": "https:\/\/mydomain.com\/cloud",
        "dbtype": "pgsql",
        "version": "11.0.3.2",
        "dbname": "nextcloud_db",
        "dbhost": "postgresql:5432",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "logtimezone": "UTC",
        "installed": true,
        "instanceid": "...",
        "maintenance": false,
        "mail_smtpmode": "smtp",
        "mail_smtphost": "smtpout.secureserver.net",
        "mail_smtpport": "465",
        "mail_from_address": "admin",
        "mail_domain": "mydomain.com",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_smtpsecure": "ssl",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "ldapIgnoreNamingRules": false,
        "appstore.experimental.enabled": true,
        "loglevel": 1,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory"
    }
}

Are you using external storage, if yes which one: no

Are you using encryption: no

Web server error log

Web server error log

(nothing)

Cloud log

Nextcloud log

(nothing)

Desktop configuration

Operating system: Win10_64

Thunderbird version: 52.2.0

Updated from an older installation or fresh install: updated

Thunderbird Log

Thunderbird log

GET 
XHR 
https://mydomain.com/cloud:443/ocs/v1.php/cloud/user [HTTP/1.1 204 No Content 27ms]
Headers
Params
Response
Call Stack
Connectionkeep-aliveDateThu, 15 Jun 2017 22:13:07 GMTServernginx/1.10.3
Accept*/*Accept-Encodinggzip, deflate, brAccept-Languageen-US,en;q=0.5AuthorizationBasic snip=Connectionkeep-aliveContent-Typeapplication/x-www-form-urlencodedHostmydomain.comOCS-APIREQUESTtrueUser-AgentMozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 Lightning/5.4.2

2017-06-15 15:13:07	Nextcloud	ERROR	SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

nextcloud-filelink does not work properly when attaching network files

Bug report

Bug report

Steps to reproduce

1. write an email and attach a file located on a network path (\node\share...)
2. the link is generated and inserted into the email
3. send the email

network path is a folder shared by windows 10 (from another computer in the local network)

Expected behaviour

The email is sent with a download link and not with an attached large file

Actual behaviour

The email is sent with a download link AND with the attached large file.
Upload to owncloud and sharing works! The attached file is on owncloud and shared.
The link also works properly.
BUT: the large file is sent as an attachment.
There is no indication of an error.

Using a local file as attachment works fine.

Server configuration

Operating system

Web server:

Database:

PHP version:

Nextcloud version: (see admin page or version.php)
owncloud 10.0.6.1
Updated from an older installation or fresh install:
fresh install
List of activated apps:

The content of config/config.php:

Are you using external storage, if yes which one: local folder, smb share, sftp, etc.

Are you using encryption: yes/no
no

Web server error log

Cloud log

Desktop configuration

Operating system:
Windows 10
Thunderbird version:
52.6.0 (32 bit)
Updated from an older installation or fresh install:
updated

Thunderbird Log

Network error while setting up account

Bug report

Yesterday I set up a filelink for Nextcloud just fine and used it once. Today, when using it, it suddenly reported that it was "unauthorized", but clicking "authorize" in the settings did nothing for me.

Then I deleted the account and tried to set it up again, again it did not work, restarted thunderbird and again to no avail.

Verified that my Nextcloud is up and running, also checked whether there are any signs that the extension tries to contact the server, but there is nothing in the webserver log or in the server log.

The Thunderbird console says:

Nextcloud	ERROR	Could not retrieve password
 1 log4moz.js:691
	CApp_append resource:///modules/gloda/log4moz.js:691:7
	Logger_log resource:///modules/gloda/log4moz.js:380:7
	Logger_error resource:///modules/gloda/log4moz.js:388:5
	nsNc_logon jar:file:///C:/Users/heike/AppData/Roaming/Thunderbird/Profiles/p53cogaf.default/extensions/[email protected]!/components/nsNextcloud.js:430:4
	nsNc_createExistingAccount jar:file:///C:/Users/heike/AppData/Roaming/Thunderbird/Profiles/p53cogaf.default/extensions/[email protected]!/components/nsNextcloud.js:310:3
	cloudFileAccounts.createAccount resource:///modules/cloudFileAccounts.js:111:9
	AAD_onOK chrome://messenger/content/cloudfile/addAccountDialog.js:229:20
	anonymous chrome://global/content/bindings/dialog.xml%20line%20380%20%3E%20Function:1:8
	_fireButtonEvent chrome://global/content/bindings/dialog.xml:381:28
	_doButtonCommand chrome://global/content/bindings/dialog.xml:349:28
	_handleButtonCommand chrome://global/content/bindings/dialog.xml:337:18
	CFA_addAccountDialog resource:///modules/cloudFileAccounts.js:193:5
	CFT_addCloudFileAccount chrome://messenger/content/preferences/applications.js:759:22
	gCloudFileController.commands.cmd_addCloudfileAccount.doCommand chrome://messenger/content/preferences/applications.js:445:9
	gCloudFileController.doCommand chrome://messenger/content/preferences/applications.js:489:5
	goDoCommand chrome://global/content/globalOverlay.js:100:7
	oncommand chrome://messenger/content/preferences/preferences.xul:1:1
	openOptionsDialog chrome://messenger/content/mailCore.js:427:7
	onclick chrome://messenger/content/messenger.xul:1:1

I set up the same Nextcloud account again, only this time under a different domain, under which my nextcloud is also available. This time no network error.

So it seems like the actual problem was in the next line where it says
...
Nextcloud ERROR Could not retrieve password
...

Just not understanding why. After all, I entered the password yesterday. And this time, when the addon cannot retrieve the password again, why doen't it prompt for one?

Also, I use the same nextcloud instance for calendar and contacts (TB addons Lightning and CardBook), and they don't have any problems.

Changing server details and/or password

Feature request

User level: Beginners, intermediate or advanced

Description

Editing your server details, changing the password etc... How?

Benefit / value

Currently you have to delete your server in settings and redo them. Maybe an easier way to change the password?

Risk / caveats

Sponsorship

Are you a developer willing to implement this feature?: yes/no

Can you sponsor the development of this feature or do you know someone who can?: yes/no

can't add a link in the mail.

I succeeded in installing the extension, but when I try it can't add a link file in the mail i'm creating.
I create a new mail, add a file bigger than the limit I put in the extension's option (10Mo, my file il 17Mo), it seems to upload it (little green circle moving near the file's name) but at the end, it says "Impossible to upload -my file- to -my server" (in french).
I click on "ok" but nor link is added neither the file on my server.

I tried it with a smaller file with the "join a file" menu, but it does the same.

No error logged in the thunderbird console. Nothing in my nextcloud server too (apparently).

How can i see more ?
(I owne my dedicated server, if it can help)

Does not work with spaces or point in the user name

Many thank for this addon!

Bug report

Steps to reproduce

Working well for me with an easy user name or with user name with special character (like 'at' sign). But I get the error message: 'An error occurred while uploading xxx.pdf to mynextcloud' when the user name contains space or point.

Server configuration

PHP version: 5.6.31

Nextcloud version: 12.0.0

Desktop configuration

Thunderbird version: 52.2.1 (32 Bit)

Updated from an older installation or fresh install: fresh install

Thunderbird plugin v1.6 has wrong compatibility settings

Bug report

The plugin uploaded to Mozilla for version 1.6 has compatibility set for Thunderbird 17-45 while the current Thunderbird version is 52 and the plugin 1.5 has 17+ compatibility settings

Steps to reproduce

1. Try to install Nextcloud-Filelink from Thunderbird 52 Add-on menu and the only available version is 1.5

Expected behavior

1. Nextcloud-Filelink v1.6 available on the add-on repository for Thunderbird 17+

Renaming functionality of thunderbird not applied to uploaded files

Thunderbird offers to option to rename the attached right from the compose window (right click on the attachment -> rename). If I do that and then choose to upload the file to owncloud/nextcloud, the original file is uploaded, i.e. it is not being renamed first and then uploaded.

Set Up Filelink in Icedove not possible

Bug report

Steps to reproduce

1. Install the extension according to the README.md in this repository.
2. Add a filelink service and select nextcloud.

Expected behaviour

The filelink setup window should appear.

Actual behaviour

The filelink setup window contains an error message:
XML-Verarbeitungsfehler: Nicht definierte Entität Adresse: jar:file:///home/xxxx/.icedove/xxxxxxx.default/extensions/[email protected]!/chrome/content/settings.xhtml Zeile Nr. 20, Spalte 27: <label for="displayName">&nextcloudSettings.provider;</label>

License and Acknowledgements

Thank you for working on this add-on. I've noticed that you have mentioned my name under "created by". I appreciate the attribution, but my role in this is not necessarily the creation. In order to avoid confusion maybe you can separate this to a section for authors whose sources you have used.

Also, as far as I am aware, those files that you have re-used from my MPL-licensed extension must be dual licensed MPL/AGPL, or if all files are derivatives of my extension then it must remain MPL.

check file upload threshold against all selected files

Expected behavior

The configured file upload threshold should always be checked against all selected files and not only single files.

Current behavior

If you've set the upload limit to e.g. 2MB and select three files with a total size of 3MB the upload request will not be triggered.

Steps to reproduce

1. Open Thunderbird and create a new message
2. Select multiple files which together exceed the configured limit.
   -> No upload request is triggered.

Environment

Server Configuration

OS: Linux 3.16.47
Web server: Apache2 2.4.26
Database: MariaDB 10.0.32
PHP version: 5.6.30
Nextcloud version: 12.0.3

Client Configuration

Thunderbird version: 52.3.0
Nextcloud for Filelink version: 1.7
Operating system: Windows 7

Change user agent

The user agent should be changed to Mozilla/5.0 (<Operating System>) Nextcloud-Thunderbird v<Version> as per:
nextcloud/files_automatedtagging#48 (comment)

Get rid of "port" field in account setup form

Feature request

User level: Beginners

Description

The port number in the account setup form is superflous in most cases and only complicates the form.

It should be possible to pass the port number in the "Server URL" field as it's done in browers: https://example.org:8081.

Benefit / value

Account setup form is easier to grasp

Risk / caveats

Users that need a special port number might not know how to add it

Sponsorship

Are you a developer willing to implement this feature?: no

Can you sponsor the development of this feature or do you know someone who can?: yes, 20€

Unknown Error while uploading - no insert of text

Bug report

Steps to reproduce

1. Attach a File in Thunderbird
2. Push button for "Upload with filelink"
3. See unknown error

Expected behaviour

File uploaded without error, Text in E-Mail with instructions for Download

Actual behaviour

There is shown an Errormessage "Unknown Error while uploading", but the file is uplaoded to my Nextcloud.

Server configuration

Operating system:
debian
Web server:
apache
Database:
mysql
PHP version:
7.1.3
Nextcloud version: (see admin page or version.php)
13.0.1
Updated from an older installation or fresh install:
Updated from an OwnCloud once up on a time in a galaxy far far away...
Nearly all standard apps. None extravagant.

Are you using external storage, if yes which one: local folder, smb share, sftp, etc.
no
Are you using encryption: yes/no
no

Desktop configuration

Operating system:
Linux Mint 18.3 and Windows 10 latest release both on newset patchlevels
Thunderbird version:
52.7.0 64 Bit
Updated from an older installation or fresh install:
Updated

File type as trigger for filelink

It would be great to have the option to attach all files from certain types. Something like: Send all MS Office Documents as Download link.

Password policy not met? -> Unknown error

Bug report

Steps to reproduce

1. Define password rules in Nextcloud backend (/settings/admin/additional; here 6 chars, upper-/lowercase and number)
2. Use password in plugin which does not match requirements (e.g. foobum)
3. Compose mail, when asked to use Filelink, chosse upload.
4. Error message: "Unknown error": An unknown error occurred on data exchange with ... .

Expected behaviour

Check if chosen password in plugin for uploads meets requirements / Give hint to check for password requirements.

Actual behaviour

After upload an "unknown error" occurs.
File is successful uploaded but link is not inserted into mail due setting of password failed

Feature request

User level: intermediate

Benefit / value

Less user support needed :)

Are you a developer willing to implement this feature?: no

Can you sponsor the development of this feature or do you know someone who can?: no

Unbekannter Fehler

I have a problem with Nextcloud for Filelink.

My system:
Nextcloud: 12.0.0
Nextcloud runs on NAS-Server with Openmediavault 3.0.77
Certificate: Own certificate with LetsEncrypt
Thunderbird: 54.0b2
Operating system Win10
Install & configure nextcloud for filelink 1.5 in Thunderbird

I have little computer skills.

In Nextcloud, I created a separate path /mail before installing the addon.

In the installation mask I have specified as Provider "Nextcloud". I hope this is correct?

When attempting to send an email, Thunderbird correctly places the attachment in the created path on Nextcloud, but then the following error message appears:

An unknown error occurred while exchanging data with Nextcloud.

I've seen in "google" that this error has already occurred, but I have not managed to eliminate the error. I would be happy about a solution.

Django43

More nextcloud

Hi,
I have more nextcloud. How can I configure them?

Best regards

Nextcloud not showing up in the provider dropdown

Bug report

Steps to reproduce

1. Follow installation instructions in README.
2. Restart Thunderbird, go to the Add panel. In the dropdown, I only see existing providers. No Nextcloud.

If I install the extension from AMO, it shows up properly as "ownCloud/nextCloud".

Desktop configuration

Operating system:

Ubuntu 17.04

Thunderbird version:

45.8.0

Updated from an older installation or fresh install:

What software is referred to here? If it's Thunderbird, it's managed by the package manager of Ubuntu. Not a fresh install.

Setup account failed

Bug report

It is not possible to setup the account with my nextcloud instance.
It looks like the problem is that my nextcloud is running in a subfolder: https://mydomain.de/nextcloud

Steps to reproduce

1. Add account in thunderbird preferences
2. Use the following settings:

ServerURL: https://mydomain.de/nextcloud
Port: 443
Storagepath: /Mail-attachments

Result: "An error occurred while setting up the account!"
The error log shows this:
POST https://mydomain.de/nextcloud:443/ocs/v1.php/person/check HTTP/1.1 404 Not Found

As you can see the port number is added to the wrong location.

So I tried these settings:

ServerURL: https://mydomain.de
Port: 443
Storagepath: /nextcloud/Mail-attachments

Result: now I get prompted for a password, but then again the same error message: "An error occurred while setting up the account!"

The error log shows this:
POST: https://gappycloud.goip.de/ocs/v1.php/person/check HTTP/1.1 404 Not Found

Here the nextcloud folder is missing.

Expected Behavior: it should work with having installed nextcloud in a subfolder.

An unknown error is shown although the file upload was successful

Expected behavior

When uploading an attachment with the app the upload process should end without running into an error condition.

Current behavior

As I uploaded files of a size of appr. 5 MB and 10 MB the following message was shown and the upload process aborted:

Surprisingly the attachments have all successfully been uploaded to the attachment folder.
In the Thunderbird error console the following messages were logged. The last entry is showing a
401 Unauthorized result:

GET (XHR) https://<my-nextcloud-server>/ocs/v1.php/cloud/user [HTTP/1.1 200 OK 476ms]
PROPFIND (XHR) https://<username>:<password>@<my-nextcloud-server>/remote.php/webdav [HTTP/1.1 207 Multi-Status 5032ms]
PUT (XHR) https://<my-nextcloud-server>/remote.php/webdav/MailAttachments/1507224757618_IMG_0099.MOV [HTTP/1.1 201 Created 7229ms]
POST (XHR) https://<username>:<password>@<my-nextcloud-server>/ocs/v1.php/apps/files_sharing/api/v1/shares [HTTP/1.1 401 Unauthorized 323ms]

To double-check if access to the server is possible with the given URL (the last one), I copy-pasted it to a private browser window. The following message was displayed which might be the reason for the unknown error condition:

Environment

Server Configuration

OS: Linux 3.16.47
Web server: Apache2 2.4.26
Database: MariaDB 10.0.32
PHP version: 5.6.30
Nextcloud version: 12.0.3

Client Configuration

Thunderbird version: 52.3.0
Nextcloud for Filelink add-on version: 1.7
Operating system: Windows 7

Modify Text on mail

Hello,
sorry for my stupid question.
I need change the Text, where is the file for change Text and color ?
Thank you,
Best regards,

Add link to Mozilla Addon Page

How about adding a link to https://addons.mozilla.org/thunderbird/addon/nextcloud-filelink/ to the Readme.md?

[Feature Request] More options for filename generation

Hello,

currently filename of uploaded file is generated as:

<timestamp>_<original_name>

This can be problem due to different name in e-mail and downloaded file. Also original filename is concatenated as suffix, which made it harder to find due to timestamp etc.

So it would be nice to have few more options to set a way, how filename would be generated:

• use some pattern/tags to define uploaded filename, so I can define position of variable part, add my own identifier, ...
• generate filename on client side, therefore also filename added to email will correspond (I'm not sure on what side name is generated, if it's client, it would be nice to have option to match filenames)
• if no patter option would be added it would be nice to have some static options like
  • don't add timestamp (sure it can cause error, but I don't care, I can rename it on client side after error message) when exact filename is somehow must have
  • add timestamp as suffix
  • when uploading file to Nextcloud force it to generate name by itself (add counter) - I'm not sure how exactly you upload files in code, but standard web application works this way
  • ...

Thank you in advance for considering this.

--
Best regards,
Tomas.

Rename "provider" field and make it optional

Feature request

User level: Beginners

Description

The "Provider" field in the account setup is confusing for users. I first had to read all the other fields until I decided that "provider" is probably just the "title" for the account.

The field should be a) optional and at the end of the field list, and b) auto-filled with the domain sans scheme.

Benefit / value

The account form is not as confusing as it is now.

Risk / caveats

No idea

Sponsorship

Are you a developer willing to implement this feature?: no

Can you sponsor the development of this feature or do you know someone who can?: yes, 20€

Not compatible with instances which use a sub-dir

Hey,

with the Git version of the plugin, adding an account on Thunderbird results in an error.

Server: Nextcloud 11.0.2
URL: https://myserver.org/owncloud

With the Error Console, I can see it's because the plugin is concatenating the URL and the port in a wrong way, resulting a in 404 error (screenshot below)

Server URL requires scheme

Bug report

"Set up Account" button doesn't response if you enter a "plain" url without scheme (http/https).

Steps to reproduce

1. Enter all desired settings (Provider, Server URL, Port number, Username, Storage path). Remove the protocol part of your url.
2. "Set up Account" button gets active
3. Click on button doesn't result in any action

Expected behaviour

Set up should complete or an error message should pop up.

Actual behaviour

Nothing

Server configuration

Nextcloud version: 11

Updated from an older installation or fresh install: update

Are you using encryption: no

Desktop configuration

Operating system: Ubuntu 17.04

Thunderbird version: 52.1.1

Nextcloud Filelink version: 1.0 from addon repo

Thunderbird Log

NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI] nsLoginManagerPrompter.js:527

Can't setup filelink after I deleted account to change passwords

Bug report

I experienced problems since a few month with the filelink plugin since I switched to 2FA. Today I tried to investigate since I always got the error message "can't communicate with nextcloud" (or something like that; can't reproduce it because of the following error).

I found the following in the server logs:

46.59.163.252 - lars [28/Jul/2017:23:43:51 +0200] "PUT /remote.php/webdav/filelink/1501278230995_test.png HTTP/1.1" 201 1425 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Lightning"
46.59.163.252 - - [28/Jul/2017:23:43:53 +0200] "POST /ocs/v1.php/apps/files_sharing/api/v1/shares?format=json HTTP/1.1" 401 1413 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Lightning"

So the file was created (Status 201) but not the link (401).

Since I was unable to solve the problem I deleted the plugin and the stored passwords (which were hard to find since the other plugins for CalDAV and CardDAV) and reset the entries under mail.cloud_files.accounts.account1.*. I reinstalled the plugin and tried to set it up again which fails with the message "Checking authorization" followed by an unspecific "An error occurred while setting up the account!"

Deleting the password from the password manager and resetting the above mentioned entries in the advanced config doesn't help.

Any ideas how to debug this one? I have no experience with the development of Firefox plugins.

Server configuration

Thunderbird: 52.2.1 (64bit; current Archlinux package)
Filelink Plugin: 1.5 (current version from AMO)
Other Add-Ons like Cardbook and Lightning do work as expected.

And while I'm quite sure that the problem is with the plugin here the info about the server :
Operating system: Ubuntu 16.04.2 LTS (Xenial Xerus)
Web server: Apache (2.4.18-2ubuntu3.4)
Database: : MySQL (5.7.19-0ubuntu0.16.04.1)
PHP version: PHP 7 (7.0+35ubuntu6)
Nextcloud version: 12.0.0
Updated from an older installation or fresh install: updated from an older installation (in many steps since 6.0)

Cloud log

Nothing relevant logged; only a few warnings and notices from other apps.

Desktop configuration

Operating system: Archlinux
Updated from an older installation or fresh install: Updated of course... :-D

Thunderbird Log

Nothing interessting in there but hundreds of lighning errors

unknown error on upload

Bug report

Steps to reproduce

1. install & configure nextcloud-filelink 1.5 in thunderbird
2. write a mail, try to attach a big file, say "Use FileLink"
3. i got "unknown error"
4. in the nexcloud folder i see the attached file with an timestamp_prefix

Expected behaviour

no errors

Actual behaviour

it should just work

Server configuration

Operating system: Debian 8.7

Web server: nginx 1.11.13

Database: mariadb 10.1.22

PHP version: 5.6.30+dfsg-0+deb8u1

Nextcloud version: 11.0.2.7

Updated from an older installation or fresh install: updated

List of activated apps:

App list

- activity: 2.4.1 - admin_audit: 1.1.0 - calendar: 1.5.1 - comments: 1.1.0 - contacts: 1.5.3 - dav: 1.1.1 - federatedfilesharing: 1.1.1 - federation: 1.1.1 - files: 1.6.1 - files_external: 1.1.2 - files_pdfviewer: 1.0.1 - files_sharing: 1.1.1 - files_texteditor: 2.2 - files_trashbin: 1.1.0 - files_versions: 1.4.0 - files_videoplayer: 1.0.0 - firstrunwizard: 2.0 - gallery: 16.0.0 - logreader: 2.0.0 - lookup_server_connector: 1.0.0 - nextcloud_announcements: 1.0 - notifications: 1.0.1 - password_policy: 1.1.0 - provisioning_api: 1.1.0 - serverinfo: 1.1.1 - sharebymail: 1.0.1 - survey_client: 0.1.5 - systemtags: 1.1.3 - templateeditor: 0.2 - theming: 1.1.1 - twofactor_backupcodes: 1.0.0 - updatenotification: 1.1.1 - user_ldap: 1.1.2 - workflowengine: 1.1.1

The content of config/config.php:

Config report

'datadirectory' => '/var/www/owncloud', 'dbtype' => 'mysql', 'version' => '11.0.2.7', 'dbname' => 'owncloud', 'dbhost' => '127.0.0.1', 'dbtableprefix' => 'oc_', 'dbuser' => '...', 'dbpassword' => '...', 'installed' => true, 'proxy' => 'my.proxy:3128', 'forcessl' => true, 'mail_from_address' => 'noreply', 'mail_smtpmode' => 'php', 'mail_domain' => 'my.dom', 'ldapIgnoreNamingRules' => false, 'mail_smtppassword' => '', 'loglevel' => 2, 'default_language' => 'en', 'theme' => '', 'filesystem_check_changes' => '1', 'maintenance' => false, 'secret' => '...', 'trashbin_retention_obligation' => 'auto, 14', 'memcache.local' => '\\OC\\Memcache\\APCu', 'ldapProviderFactory' => '\\OCA\\User_LDAP\\LDAPProviderFactory',

Are you using external storage, if yes which one: no

Are you using encryption: no

Web server error log

Web server error log

empty

Cloud log

Nextcloud log

{"reqId":"U7TioQS5+sp6EXekZpeg","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:03:35+00:00","method":"PROPFIND","url":"\/remote.php\/webdav","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"} {"reqId":"\/WSQ0y3Jm9pDI4eOXLSZ","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:03:38+00:00","method":"PUT","url":"\/remote.php\/webdav\/temp\/1495026215819_Screen%20Shot%202016-07-12%20at%2013.33.44.png","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"} {"reqId":"\/WSQ0y3Jm9pDI4eOXLSZ","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:03:38+00:00","method":"PUT","url":"\/remote.php\/webdav\/temp\/1495026215819_Screen%20Shot%202016-07-12%20at%2013.33.44.png","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"} {"reqId":"b8Jbu7vV4YdtJgheoYEF","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:04:00+00:00","method":"GET","url":"\/ocs\/v1.php\/cloud\/user?format=json","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"} {"reqId":"b8Jbu7vV4YdtJgheoYEF","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:04:00+00:00","method":"GET","url":"\/ocs\/v1.php\/cloud\/user?format=json","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"} {"reqId":"DOEfAgRYMRFJrFHItQMx","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:04:02+00:00","method":"PROPFIND","url":"\/remote.php\/webdav","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"} {"reqId":"DOEfAgRYMRFJrFHItQMx","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:04:02+00:00","method":"PROPFIND","url":"\/remote.php\/webdav","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"} {"reqId":"o+TXPtk0PnVe6gP+6zi9","remoteAddr":"192.168.1.42","app":"no app in context","message":"Missing expected parameters in change user hook","level":2,"time":"2017-05-17T13:04:05+00:00","method":"PUT","url":"\/remote.php\/webdav\/temp\/1495026242814_Screen%20Shot%202016-07-12%20at%2013.33.44.png","user":"7F34B8CE-62DF-4E55-BC4B-79AB026440F7","version":"11.0.2.7"}

Desktop configuration

Operating system: Ubuntu 16.04 LTS

Thunderbird version: 52.1.1 (64-Bit)

Updated from an older installation or fresh install: updated

Thunderbird Log

Thunderbird log

i can't find a log

Plan for this module ?

@oparoz Thank you for citing me in this code. I'm guessing this module is meant to be released in the Thunderbird ecosystem at some point. If you would like me to give you ownership of my module in Thunderbird so you can upload your module as a new version of mine, or would like me to mark my module as deprecated let me know, as I don't think it makes sense to have 2 competing "nextcloud for filelink" modules...

Feel free to get in touch with me: https://www.viguierjust.com

Can't login after while

Hello,
first of all I would like to thank you for your work. Nextcloud-filelink is great extension.

I have a issue with login. When i start Thunderbird, everything works fine. But after while, thunderbird say Unable to login: In my nextcloud_access_log:

127.0.0.1 - kb [02/Mar/2018:22:51:33 +0100] "GET /ocs/v1.php/cloud/user?format=json HTTP/1.1" 200 358
127.0.0.1 - kb [02/Mar/2018:22:51:33 +0100] "PROPFIND /remote.php/webdav HTTP/1.1" 401 222
127.0.0.1 - kb [02/Mar/2018:22:51:34 +0100] "GET /ocs/v1.php/cloud/user?format=json HTTP/1.1" 200 358
127.0.0.1 - kb [02/Mar/2018:22:51:34 +0100] "PROPFIND /remote.php/webdav HTTP/1.1" 401 222
127.0.0.1 - kb [02/Mar/2018:22:51:36 +0100] "GET /ocs/v1.php/cloud/user?format=json HTTP/1.1" 200 358
127.0.0.1 - kb [02/Mar/2018:22:51:36 +0100] "PROPFIND /remote.php/webdav HTTP/1.1" 401 222
127.0.0.1 - kb [02/Mar/2018:22:51:37 +0100] "GET /ocs/v1.php/cloud/user?format=json HTTP/1.1" 200 358
127.0.0.1 - kb [02/Mar/2018:22:51:37 +0100] "PROPFIND /remote.php/webdav HTTP/1.1" 401 222
127.0.0.1 - kb [02/Mar/2018:22:51:37 +0100] "GET /ocs/v1.php/cloud/user?format=json HTTP/1.1" 200 358

After restarting Thunderbird, login is working again.
I'm using caddy as a proxy (with Let's encrypt SSL), apache2 and nextCloud 13.0.0.14.

Thanks for help.

KB

Feature Request: New Password each time a File is sent / uploaded

Hi,
it would be great if EVERY TIME I send a File via FileLink, the Sender is asked to provide type a password for the Recipient.
Even better: The Password is asked for the Recipient once and then connected to the Recipient. Next time I send a File to the same Recipient, the once used Password is suggested OR can be changed.

So I hope, this is a possible Feature. It would push security to a higher level.
Thanks
JamFX

free disc space = 0

Hi there,

unfortunately, I have an issue which I could not solve. FREE SPACE = 0 GB

For this reason, I cannot upload any file :-(

Unfortunately, all the suggestions I found so far did not solve the issue. Any ideas? Thanks a lot!

Customisation filelink view

Hi!
How to change filelink attachment view in messase?
https://support.cdn.mozilla.net/media/uploads/gallery/images/2014-05-05-01-21-28-8e37a8.png
I want leave only generated link and file size.
THX!

Change logo to white on blue

The current logo with small icon and big text, as well as blue on white, is outdated. Please use these instead:
Logo ith text: https://github.com/nextcloud/promo/blob/master/nextcloud-logo.png
Icon: https://github.com/nextcloud/server/blob/master/core/img/favicon-touch.png

@guillaumev thanks! :)

Space recognition: user: unlimited shows 0 bytes free

Bug report

Steps to reproduce

1. Set the configured user in nextcloud to unlimited space
2. Restart thunderbird, open the option tab and view the Free space.

Expected behaviour

Should show unlimited or even disk space left on device or something else, but not 0 Bytes

Actual behaviour

0 Bytes free space is displayed

Server configuration

Operating system:
ubuntu

Web server:
nginx

Database:
mysql

PHP version:

Nextcloud version: (see admin page or version.php)
12.01

Updated from an older installation or fresh install:
updated

** removed **
holy this is a long list of questions / information requested, i have removed the ones i think that don't help here.
i think its a minor bug, but wanted to help on testing, and reported this.

Feature request force upload to nextcloud - not show you can use it ... only use it!

Feature request

force upload to nextcloud - not show you can use it ... only use it!

Steps to reproduce

1. set max Filesize to zero
2. thunderbird forces the upload to nextcloud and did not ask for upload
3. click send, the mail with the link is sending ..without asking about upload

Compatibility with Thunderbird 60.0

It's more a feature request than an issue at this moment because the tested version of Thunderbird is in beta state, 60.0 but I can see this will become a problem in the future. Thunderbird just refuses to use this add-on. Unless there is any other reason, can someone have a look at this?

for each mail create a subfolder and share a link to the subfolder instead of to every single file

Instead of uploading the files for every mail in the same folder, it would be nice, if the plugin could create for each mail a subfolder, upload all the files into that subfolder, share that subfolder and then in the mail only send the link to that subfolder. so if it are pictures or similar files, the user can look at them all together. Or decide to download a zip archive with all the files together. or whatever, but if you send a lot of files it would make it easier for the receiver, than getting a dozen different links.

Give the option to not directly download files, but show them in the browser

It would be great, if for example for pictures not a download link, but just a normal link to the picture would be inserted in the mail, so that the receiver can look at the pictures directly in the browser, instead of downloading them all.
I can imagine severall solutions to achieve that:

• ask when uploading the files to nextcloud if a download or normal link should be send
• have a setting where you can specify what should happen with different filetypes
• the lazy way, just have a setting, which is true, false. and always adds download links, or always adds direct links
• or implement #46

App Passwords not working?

I really love this extension. Makes complicated stuff so easy to handle.

My problem is though that I cannot get app passwords to work. I can login to my account with the normal password with no problem but not with the app password. I checked it with several accounts and the app password always gets me an error " Wrong password" .

I am using Nextcloud 11.0.2 hosted on Debian 8 with apache and php7.0.14. The app passwords normally work fine even withhin thunderbird. My caldav used in the same thunderbird instance is using an app password and works perfectly.
What am I doing wrong?

Setting up new account, crash (I think), no more providers in drop-down menu

Hello,

I was setting up my account when I entered my password in the password field under username (without realizing it's for future uploaded files, not the account - account login comes later...) and when prompted on the next page to enter my password I realized my mistake.

I think I hit cancel, and I think it crashed. I wasn't paying much attention, sorry.

Now it did create the folder /mail-attachment, but there is no sign of a connected account.

And if I try to add a new account, the drop -down list is empty.

I have found an old link suggesting it might be an error in prefs.js
here

origin of the code

sorry for posting this as an issue... but i don't know where else to get easily in touch with the right recipient(s).

i saw you modified the code from the old ownCloud-addon (https://addons.mozilla.org/thunderbird/addon/owncloud-for-filelink/), but why you didn't take the still working addon (https://addons.mozilla.org/thunderbird/addon/smart-owncloud-filelink/)?

thanks for enlightenment and if you don't noticed it, maybe i gave a useful hint...

Preference screen is disordered

Bug report

Steps to reproduce

1. Open Settings > Attachments

Expected behaviour

Should look like the screenshot in the readme.

Server configuration

Nextcloud version: 11

Updated from an older installation or fresh install: update

Are you using encryption: no

Desktop configuration

Operating system: Ubuntu 17.04

Thunderbird version: 52.1.1

Nextcloud Filelink version: 1.0 from addon repo

Error while creating the account

Bug report

Steps to reproduce

1. Try to create the account in Thunderbird (options -> attached files -> add
2. When I press OK, after a first "error message", now it won't say anything and do anything else (without error message)

Expected behaviour

The goal was to creat an account to work with my personnal nextcloud server.

Actual behaviour

An error occured and now, nothing happens when i try to submit the form.

Thunderbird version : Thunderbird 45.8.0
Nextcloud version: Nextcloud 11.0.2
Updated from an older installation or fresh install: fresh install

Thunderbird Log :

Horodatage : 18/04/2017 18:51:19
Erreur : NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]
Fichier source : resource://gre/components/nsLoginManagerPrompter.js
Ligne : 493

Create initial folder

Feature request

Steps to reproduce

1. Create a fresh Nextcloud account
2. Set up the add-on using that account

Expected behaviour

The add-on should be ready to use in Thunderbird

Actual behaviour

Erreur : NS_ERROR_MALFORMED_URI: Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService2.newURI]
Fichier source : resource://gre/components/nsLoginManagerPrompter.js
Ligne : 493

Solution

1. Test if the folder exists
2. If not, create it

No ask for Big file attachment

When adding a file using join file thunderburd no ask for using nextcloud, and send directly the file.

For adding file using next cloud I must add file using "file space" .

Thunderbird Version 45.8.0

Regards