Discussion: Style 'add note' as button

[Henni]

Discussion: Style 'add note' as button

[skjnldsv]

Yes, we should aim to uniform designs :)

[Henni]

Looks like we currently don't have a .primary-button style in core.
I think we should change that so that we can reuse it in contacts, mail and here in notes.

[MariusBluem]

👍

[jancborchardt]

I agree with this, yes. It makes the primary action clearer and we do this in Contacts & Mail as well. (And to some extent in Files and Calendar)

[skjnldsv]

I completely agree.
Should be in apps.scss. A #app-navigation > .primary-button-container > button.primary-button?

• Mail has its button inside a div
• Contacts has it inside a custom element (which a class can be easily applied)
• Calendar has 3 buttons (previous, month and next) maybe we should uniform the .primary-button-container with some flexbox to be compatible with that too?

[Henni]

I would ignore calendar and just define a simple primary button.

A wrapper element like .primary-button-container shouldn't be necessary. And maybe we should even remove #app-navigation to allow primary buttons in the app-content.

Also: Do we only want button or also input[type=button]?

[skjnldsv]

Since every app is using a wrapper, it could be useful to think twice about it.
I agree with you, this isn't necessary, but I like the idea of a unified buttonS wrapper wich include calendar.

[jancborchardt]

We do have .primary though, as used by the log in button and the main button of the file picker, and in the Calendar app for event saving, and in Mail for send and reply button. :) So that should be used.

[jancborchardt]

This is fixed, we now have a nice button there. :)

[jancborchardt]

Thanks to @andreasjacobsen93 who fixed it in #108 ;)