nf1s/go-covid

Go package for gathering data regarding the novel corona virus from John Hopkins University

Hi there 👋

I am an IT veteran with focus on software development for web applications, Java was my old friend but Python and I became best friends several years ago. I recently started hanging out with Go, and Go is AWESOME. My favorite stack is Python/FastAPI and if I have to, i'd use React for the frontend. I enjoy working with event driven microservices, specially with DDD and CQRS. Specially when these microservices are swimming in k8s and the infra is managed by terraform.

go-covid's Issues

Might be a good idea to add context to enable cancellation

Go has this idea of "context" which can be used to cancel requests before they complete.
I want to suggest that context be implemented into the package. This will allow people using this package to
programmatically cancel any request they make using this package.

Example:
If for any reason a request made through this package is taking too long, with a context the client of this package can set
a timeout of let's say 5s and automatically the request will be cancelled if that 5s timeout is reached.

I've started trying it out locally on my repo and it's going well. I want to know how you feel about this. If it sounds good to you,
then I can continue working on it and send in a pull request

Make variable names idomatic

In go, it is valid to use underscores to begin variable names but this is rarely done. I think it will be more idiomatic to remove the use of underscores at the beginning of some of the variables.

Is there any special reason for using the underscores?

Here is an example of such a variable:
https://github.com/ahmednafies/go-covid/blob/aa91f503ed4f6541a983c99af54d5a0526c3d2e9/covid/covid.go#L56

Switch to Go modules instead of dep?

Hi, first of all, I want to appreciate you for putting this together. I have myself built a website that serves data on the current coronavirus pandemic. So I'm glad there is a native package built in go.

I noticed you are using dep to manage your dependencies. I have not used dep before I only used the built in go modules which solves the same problem.

I was thinking that it might be good to use go modules instead of dep since its built directly into go and it is more like the "official" way to handle dependencies now.

dep was really useful when go modules were not around. But now go modules have come to solve the exact problem natively

Change repo name

Good work for this. But I think it will be better if you change the naming. I know it's go project so naming like that. But for this issue I think people will be misunderstand. Thanks.

codecov is not getting the report

probably because the coverage report is in HTML
probable fix: generate .xml instead