ng2-ui/utils

Utility functions used in ng2-ui directives

utils's Issues

ERROR in NguiUtilsModule is not an NgModule

I'm trying to import NguiUtils to my app but got this error.

ERROR in NguiUtilsModule is not an NgModule

In app,module.ts
import { NguiUtilsModule } from '@ngui/utils';

@NgModule({
imports: [
....
NguiUtilsModule
....

Installed version is
"@ngui/utils": "^0.8.1",

Using computedStyle does not work with an element

Because https://github.com/ng2-ui/ng2-utils/blob/master/src/dom-functions/computed-style.ts#L9

 (typeof element === 'string') ? (el = <HTMLElement>document.querySelector(<string>element)) : element;

should be

el =  (typeof element === 'string') ? (<HTMLElement>document.querySelector(<string>element)) : element;

bug: element-visible.ts 17

code: (typeof innerElement === 'string') ? (innerEl = <HTMLElement>document.querySelector(<string>innerElement)) : innerElement;

the code i think should be:
(typeof innerElement === 'string') ? (innerEl = <HTMLElement>document.querySelector(<string>innerElement)) : (innerEl = innerElement);

Request documentation examples

Request:
Examples in Typescript for Angular2 release

Components

• scrollTo **
• elementVisible
• computedStyle
• outerHeight
• outerWidth

** i tried to implement component. can any help me pls?

scrollTo() accuracy

Since 'step' is calculated with Math.ceil, it sometimes has rounded value, which results incorrect final position after scroll.

Would the line 61 in scroll-to.ts should be changed from:

i > 1 && loop(i - 1, prop);

to something like this?:

i > 1 ? loop(i - 1, prop) :
horizontal ?
scrollContainerEl[prop] = targetOffsetLeft
: scrollContainerEl[prop] = targetOffsetTop;

which will force set the last position to target offset.

I am pretty new to angular/javascript world, so please let me know if I am thinking wrong.