ngneat/overview

🤖 A collection of tools to make your Angular views more modular, scalable, and maintainable

overview's Issues

Outlet disappear on navigation when multiple outlets are in use

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Currently, when using multiple outlets, only the last one will update on router navigation

Expected behavior

All the outlet should update. Proposed fix here main...MichaelLhommeTransdev:ngneat-overview:main

Minimal reproduction of the problem with instructions

Create two outlets, and use them on child components when navigating

What is the motivation / use case for changing the behavior?

I'm using teleport to control the AppBar title and also AppBar actions from the child pages.

Environment

Angular version: 15


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: 18
- Platform: Windows

Others:

Injector option support for TemplateViewOptions config

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Currently there is no way of passing custom injector as a part of TemplateViewOptions when calling ViewService.createTemplate.

Expected behavior

I would expect optional injector to be a part of the TemplateViewOptions.

What is the motivation / use case for changing the behavior?

Motivation is the same as for injector to be a part of the CompViewOptions

Unable to build project after 4.0.0 version release

My issue below:

Before this update my package.json look like this:

{
  "name": "myapp-lib",
  "version": "0.0.20",
  "peerDependencies": {
    [...]
    "@angular/core": "^13.1.0",
    "@angular/forms": "^13.1.0",
    [..]
    "@ngneat/helipopper": "^5.1.4",
    "@ngneat/overview": "^3.0.4",
  },
  "dependencies": {
    [...]
  },
 [..]
}

with dependant app:

{
  "name": "myapp",
  "version": "0.0.20",
  "scripts": {
   [...]
  },
  "engines": {
    "node": ">=16.13.2",
    "npm": ">=8.1.2"
  },
  "private": true,
  "dependencies": {
   [...]
    "myapp-lib" : "0.0.20",
    [..]
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^13.1.3",
    "@angular/cli": "^13.1.3",
    "@angular/compiler-cli": "^13.1.0",
    [..],
    "typescript": "~4.5.2"
  }
}

After this update @ngneat/overview is resolved as version 4.x.x, no matter do I set here:

  "@ngneat/overview": "<4.0.0",

or:

  "@ngneat/overview": "3.x.x",

Given error occurs. Do you know how could I fix this issue?

Originally posted by @InYourHead in #14 (comment)

@ngneat/overview usage causes execution error

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[x ] Support request
[ ] Other... Please describe:

Current behavior

Expected behavior

No error to be generated when @ngneat/overview is installed with pnpm

Minimal reproduction of the problem with instructions

Install the library and run the application

What is the motivation / use case for changing the behavior? The following error in app execution

[ERROR] No matching export in "node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@ngneat/overview/fesm2022/ngneat-overview.mjs" for import "DynamicViewModule"

    node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]/node_modules/@ngneat/hot-toast/fesm2022/ngneat-hot-toast.mjs:6:37:
      6 │ import { isTemplateRef, isComponent, DynamicViewModule } from '@ngneat/overview';
        ╵                                      ~~~~~~~~~~~~~~~~~

/home/stclair/workspace/nx/mf/new/med-soft/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1649
  let error = new Error(`${text}${summary}`);
              ^

Error: Build failed with 1 error:
node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]/node_modules/@ngneat/hot-toast/fesm2022/ngneat-hot-toast.mjs:6:37: ERROR: No matching export in "node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@ngneat/overview/fesm2022/ngneat-overview.mjs" for import "DynamicViewModule"
    at failureErrorWithLog (/home/stclair/workspace/nx/mf/new/med-soft/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1649:15)
    at /home/stclair/workspace/nx/mf/new/med-soft/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1058:25
    at /home/stclair/workspace/nx/mf/new/med-soft/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1525:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errors: [
    {
      detail: undefined,
      id: '',
      location: {
        column: 37,
        file: 'node_modules/.pnpm/@[email protected]_@[email protected]_@[email protected]/node_modules/@ngneat/hot-toast/fesm2022/ngneat-hot-toast.mjs',
        length: 17,
        line: 6,
        lineText: "import { isTemplateRef, isComponent, DynamicViewModule } from '@ngneat/overview';",
        namespace: '',
        suggestion: ''
      },
      notes: [],
      pluginName: '',
      text: 'No matching export in "node_modules/.pnpm/@[email protected]_@[email protected]/node_modules/@ngneat/overview/fesm2022/ngneat-overview.mjs" for import "DynamicViewModule"'
    }
  ],
  warnings: []
}

Node.js v20.9.0

Environment

Angular version: X.Y.Z


Browser:
- [x ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [x ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX v20.9.0

- Platform:  Linux

Others:

IDE: Webstorm and Visual studio

@ngneat/overview crashes app when updated to version 3.0.0

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

upgrading from @ngneat/overview 2.1 - 3.x.x results in the following error

Uncaught Error: Type HotToastModule does not have 'ɵmod' property.
at getNgModuleDef (core.mjs:1130)
at recurse (core.mjs:22110)
at recurse (core.mjs:22121)
at registerNgModuleType (core.mjs:22106)
at new NgModuleFactory (core.mjs:22232)
at compileNgModuleFactory__POST_R3__ (core.mjs:26275)
at PlatformRef.bootstrapModule (core.mjs:26528)
at Module.14720 (main.ts:51)
at webpack_require (bootstrap:19)
at webpack_exec (request.model.ts:135)
getNgModuleDef @ core.mjs:1130
recurse @ core.mjs:22110
recurse @ core.mjs:22121
registerNgModuleType @ core.mjs:22106
NgModuleFactory @ core.mjs:22232
compileNgModuleFactory__POST_R3__ @ core.mjs:26275
bootstrapModule @ core.mjs:26528
14720 @ main.ts:51
webpack_require @ bootstrap:19
webpack_exec @ request.model.ts:135
(anonymous) @ request.model.ts:135
webpack_require.O @ chunk loaded:23
(anonymous) @ request.model.ts:135
webpackJsonpCallback @ jsonp chunk loading:71
(anonymous) @ main.js:2

The application does not run.

Expected behavior

The program should run without such an error.

Error related package.json modules:
"@ngneat/hot-toast": "^3.4.3"
"@ngneat/overview": "^3.0.0",

Modules that run without errors:
"@ngneat/hot-toast": "^3.4.3"
"@ngneat/overview": "^2.1.0",

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: 	"@angular/cli": "^13.0.2",



Browser:
- [ x] Chrome (desktop) version 95.0.4638.54 (Official Build) (64-bit)
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ x] Firefox version 94
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX   
  Node v16.13.0
- Platform:  
Kernel Name| Linux
Kernel Release| 5.4.0-90-generic
Kernel Version| #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021
Host Name| scscwrk
Machine Hardware Name| x86_64
OS| GNU/Linux
Code Name| Linux
Processor| x86_64
Platform| x86_64

Others:

Build Failed with current Version

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report 
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

I have try to build, i get this error:

No matching export in "node_modules/@ngneat/overview/fesm2022/ngneat-overview.mjs" for import "DynamicViewModule"

    node_modules/@ngneat/hot-toast/fesm2022/ngneat-hot-toast.mjs:6:37:
      6 │ ...mplateRef, isComponent, DynamicViewModule } from '@ngneat/overvi...

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: 17.0.5
 
For Tooling issues:
- Node version: v18
- Platform:  Mac

Packages:
"@angular/animations": "^17.0.5",
"@angular/common": "^17.0.5",
"@angular/compiler": "^17.0.5",
"@angular/core": "^17.0.5",
"@angular/forms": "^17.0.5",
"@angular/platform-browser": "^17.0.5",
"@angular/platform-browser-dynamic": "^17.0.5",
"@angular/router": "^17.0.5",
"@ngneat/dialog": "^5.0.0",
"@ngneat/hot-toast": "^6.0.1",
"@ngneat/overview": "^6.0.0",
"rxjs": "~7.8.1",
"tslib": "^2.6.2",
"zone.js": "~0.14.2"

Docs

Nested FormGroup in *teleportTo causes Expression changed error

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

When I use TeleportModule and a formGroup binding inside teleportTo template, there's an ExpressionChangedAfterItHasBeenCheckedError.

Expected behavior

No error

Minimal reproduction of the problem with instructions

https://stackblitz.com/edit/angular-ivy-8wndsv?devtoolsheight=33&file=src/app/route-1/route-1.component.html

Error appears every time you navigate to Route 1. If you comment out ng-cotnainer with formGroup, error is gone.

Environment

Angular version: 12.2.4

App initialization error

main.ts:47 Error: NG0200: Circular dependency in DI detected for ApplicationRef. Find more at https://angular.io/errors/NG0200
at throwCyclicDependencyError (core.mjs:240:11)
at R3Injector.hydrate (core.mjs:6883:13)
at R3Injector.get (core.mjs:6775:33)
at injectInjectorOnly (core.mjs:4782:33)
at Module.ɵɵinject (core.mjs:4786:60)
at Object.ViewService_Factory [as factory] (ngneat-overview.mjs:19:101)
at R3Injector.hydrate (core.mjs:6887:35)
at R3Injector.get (core.mjs:6775:33)
at injectInjectorOnly (core.mjs:4782:33)
at Module.ɵɵinject (core.mjs:4786:60)

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z


Browser:
- [X] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

Specs