nhatuan84/esp32-sh1106-oled

visit IOTSHARING.COM for more

esp32-sh1106-oled

This is for Arduino I just modified it for esp32 Demo 6: How to use Arduino ESP32 to display information on OLED http://www.iotsharing.com/2017/05/how-to-use-arduino-esp32-to-display-oled.html

esp32-sh1106-oled's Issues

Hard coded SPI instance

As the ESP32 has a pin multiplexer, can you possibly modify the library so a reference to an SPIClass instance can be passed in the constructor, and that reference is used thereafter?

The ESP32 Arduino libraries (lamely) declare SPIClass SPI(VSPI); at the end of SPI.cpp.
If you want to use another SPI peripheral or pin location, you are hamstrung into using VSPI on the associated pins, whether you like it or not :-( (another issue for that library really!).

Hardware SPI: unintialised "sid" member variable

If an instance is created using the Adafruit_SH1106(int8_t DC, int8_t RST, int8_t CS) constructor, sid is not explicitly set to anything other than -1.

This means in begin() the code to setup the SPI pins may be skipped over if "sid" just happens to be -1!

Suggested fix:
// constructor for hardware SPI - we indicate DataCommand, ChipSelect, Reset
Adafruit_SH1106::Adafruit_SH1106(int8_t DC, int8_t RST, int8_t CS) : Adafruit_GFX(SH1106_LCDWIDTH, SH1106_LCDHEIGHT) {
dc = DC;
rst = RST;
cs = CS;
sid = 0; // BUG FIX - WAS MISSING!
hwSPI = true;
}