nhsuk/eslint-config-nhsuk

Eslint config

NHSUK's ESLint config

This repo provides NHSUK's .eslintrc as a shareable config.

The config is an extension of eslint-config-airbnb-base. Details of the changes can be seen in the exported config defined in index.js. The main changes are the addition of node and mocha environments along with a few small tweaks to the rules. The rule changes better meet the personal preferences of the repo maintainers.

Installation

To install the package run:

• npm - npm install eslint-config-nhsuk --save-dev
• yarn - yarn add eslint-config-nhsuk --dev

The config relies upon several other packages. These are the Peer Dependencies. To get a list of the peerDependencies run the following command:

npm info eslint-config-nhsuk peerDependencies

All peerDependencies need to be installed.

Usage

Once the eslint-config-nhsuk package has been installed it is ready to be used. This is achieved by specifying nhsuk in the extends section of your eslint config file. If there is no existing eslint config file it could be as simple as creating a file named .eslintrc with the following content:

{
  "extends": "nhsuk"
}

eslint-config-nhsuk's Issues

An in-range update of eslint-plugin-mocha is breaking the build 🚨

The dependency eslint-plugin-mocha was updated from 6.2.2 to 6.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-mocha is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ Run tests: There are 1 failures, 4 warnings, and 0 notices.

---

Release Notes for 6.3.0

Bug Fixes

• no-hooks-for-single-case: fix false postive in nested suites (#238)
• Fix max-top-level-suites to ignore generated suites (#239)
• Check static template strings in valid-test-description and valid-suite-description (#237)

Enhancements

• no-hooks: add option to allow certain kind of hooks (#236)
• Add schemas for options (and remove for files which are using settings) (#234)
• Add u flag in RegExp for valid-test-description and valid-suite-description (#232)
• Add fixable property to fixable rules (and mention in docs) (#228)
• add plugin to recommended config (#226)

Documentation

• Indicate whether rule is recommended (#229)
• "Options" heading in doc files (and consistent level 2 heading) (#233)
• Doc syntax issue (#231)

Code Refactoring

• Nondeprecated rule format (#235)
• Alphabetize rule lists (#227)

Build-Related

• • npm: Add package-lock.json (#230)
• ✉️ Send a webhook to Coveralls when the build completes (#222)

Commits

The new version differs by 36 commits.

• b2d8c9e 6.3.0
• b91a2f8 Update dependencies
• c470a3d Merge pull request #238 from lo1tuma/fix-nested
• a18680d Merge pull request #239 from lo1tuma/fix-top-level
• 2633908 Fix max-top-level-suites to ignore generated suites
• 46f716d no-hooks-for-single-case: fix false postive in nested suites
• 1c3a545 Merge pull request #237 from lo1tuma/template-strings
• 6255546 Check static template strings in valid-test-description and valid-suite-description
• 7eea93d Merge pull request #236 from lo1tuma/no-hooks-option
• 8778d96 no-hooks: add option to allow certain kind of hooks
• 36c9e67 Merge pull request #235 from brettz9/nondeprecated-rule-format
• 471e354 Switch to nondeprecated eslint rule format
• 8cf8640 Merge pull request #234 from brettz9/schemas-for-options
• c1f8049 Merge pull request #229 from brettz9/recommended-rules
• fdb3843 - Remove regex literal argument; simplify

There are 36 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of eslint-config-airbnb-base is breaking the build 🚨

---

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

---

The dependency eslint-config-airbnb-base was updated from 14.0.0 to 14.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-config-airbnb-base is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ Run tests: There are 1 failures, 4 warnings, and 0 notices.

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of mocha-junit-reporter is breaking the build 🚨

The devDependency mocha-junit-reporter was updated from 1.23.1 to 1.23.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

mocha-junit-reporter is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ Run tests: There are 1 failures, 4 warnings, and 0 notices.

---

Commits

The new version differs by 9 commits.

• 9787677 1.23.2
• c612b17 Bump js-yaml from 3.13.0 to 3.13.1
• b30afd0 add default values in option table
• bcfc7a4 Ensure that test time attribute is capped at 4 digits after the decimal
• 19eee3e Update options parsing for mocha 6+
• 3b310cc Bump lodash from 4.17.11 to 4.17.15
• 1993678 Un-IDE the path
• ed7a698 Do workflows work?
• 9168d01 Fixed unhandled promise rejection

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Ensure lint fails when rules change

There should be files that can be (and are) linted so that any rule changes, at least from pass to fail will be picked up.

An in-range update of eslint-plugin-import is breaking the build 🚨

The dependency eslint-plugin-import was updated from 2.18.2 to 2.19.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ Run tests: There are 1 failures, 4 warnings, and 0 notices.

---

Commits

The new version differs by 46 commits.

• 9b76635 Bump to v2.19.0
• 47a232e [resolvers/webpack] v0.12.0
• 26ad476 [resolvers/webpack] [deps] update debug, enhanced-resolve, has, interpret, lodash, resolve, semver
• 3f0e8f3 [resolvers/node] [Deps] update resolve
• 7190c3e bump utils to v2.5.0
• a60e5c6 [New] no-commonjs: add allowConditionalRequire option
• 414c923 [New] enable passing cwd as an option to eslint-import-resolver-webpack
• 8224e51 [New] order/no-extraneous-dependencies: Alphabetize imports within groups
• f12ae59 [New] no-duplicates: add a considerQueryString option to handle false positives when using some webpack loaders.
• 2d3d045 [fix] importType: Accept '@example' as internal
• 0426f16 [New] order: add pathGroups option to add support to order by paths
• 99b3fbf [Fix] no-extraneous-dependencies: Add support for export from
• 21bf8c6 [Fix] no-cycle: should not warn for Flow imports
• 0cd5e43 [Fix] no-unused-modules: fix crash due to export *
• 05085bb [flow] no-unused-modules: add flow type support

There are 46 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Change use of console from warning to error

A logger should be used in preference to console.log.
Adding this rule will ensure information is written to the appropriate log.

eslint-plugin-mocha versions cause warning

The peer dependencies specify eslint-plugin-mocha as >=4.0.0 but the dev dependencies specify ^5.0.0.

This causes warnings for unmet peer dependencies in consuming applications.

An in-range update of eslint is breaking the build 🚨

The dependency eslint was updated from 6.7.2 to 6.8.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ Run tests: There are 1 failures, 4 warnings, and 0 notices.

---

Release Notes for v6.8.0

• c5c7086 Fix: ignore aligning single line in key-spacing (fixes #11414) (#12652) (YeonJuan)
• 9986d9e Chore: add object option test cases in yield-star-spacing (#12679) (YeonJuan)
• 1713d07 New: Add no-error-on-unmatched-pattern flag (fixes #10587) (#12377) (ncraley)
• 5c25a26 Update: autofix bug in lines-between-class-members (fixes #12391) (#12632) (YeonJuan)
• 4b3cc5c Chore: enable prefer-regex-literals in eslint codebase (#12268) (薛定谔的猫)
• 05faebb Update: improve suggestion testing experience (#12602) (Brad Zacher)
• 05f7dd5 Update: Add suggestions for no-unsafe-negation (fixes #12591) (#12609) (Milos Djermanovic)
• d3e43f1 Docs: Update no-multi-assign explanation (#12615) (Yuping Zuo)
• 272e4db Fix: no-multiple-empty-lines: Adjust reported loc (#12594) (Tobias Bieniek)
• a258039 Fix: no-restricted-imports schema allows multiple paths/patterns objects (#12639) (Milos Djermanovic)
• 51f9620 Fix: improve report location for array-bracket-spacing (#12653) (Milos Djermanovic)
• 45364af Fix: prefer-numeric-literals doesn't check types of literal arguments (#12655) (Milos Djermanovic)
• e3c570e Docs: Add example for expression option (#12694) (Arnaud Barré)
• 6b774ef Docs: Add spacing in comments for no-console rule (#12696) (Nikki Nikkhoui)
• 7171fca Chore: refactor regex in config comment parser (#12662) (Milos Djermanovic)
• 1600648 Update: Allow $schema in config (#12612) (Yordis Prieto)
• acc0e47 Update: support .eslintrc.cjs (refs eslint/rfcs#43) (#12321) (Evan Plaice)
• 49c1658 Chore: remove bundling of ESLint during release (#12676) (Kai Cataldo)
• 257f3d6 Chore: complete to move to GitHub Actions (#12625) (Toru Nagashima)
• ab912f0 Docs: 1tbs with allowSingleLine edge cases (refs #12284) (#12314) (Ari Kardasis)
• dd1c30e Sponsors: Sync README with website (ESLint Jenkins)
• a230f84 Update: include node version in cache (#12582) (Eric Wang)
• 8b65f17 Chore: remove references to parser demo (#12644) (Kai Cataldo)
• e9cef99 Docs: wrap {{}} in raw liquid tags to prevent interpolation (#12643) (Kai Cataldo)
• e707453 Docs: Fix configuration example in no-restricted-imports (fixes #11717) (#12638) (Milos Djermanovic)
• 19194ce Chore: Add tests to cover default object options in comma-dangle (#12627) (YeonJuan)
• 6e36d12 Update: do not recommend require-atomic-updates (refs #11899) (#12599) (Kai Cataldo)

Commits

The new version differs by 29 commits.

• 9738f8c 6.8.0
• ba59cbf Build: changelog update for 6.8.0
• c5c7086 Fix: ignore aligning single line in key-spacing (fixes #11414) (#12652)
• 9986d9e Chore: add object option test cases in yield-star-spacing (#12679)
• 1713d07 New: Add no-error-on-unmatched-pattern flag (fixes #10587) (#12377)
• 5c25a26 Update: autofix bug in lines-between-class-members (fixes #12391) (#12632)
• 4b3cc5c Chore: enable prefer-regex-literals in eslint codebase (#12268)
• 05faebb Update: improve suggestion testing experience (#12602)
• 05f7dd5 Update: Add suggestions for no-unsafe-negation (fixes #12591) (#12609)
• d3e43f1 Docs: Update no-multi-assign explanation (#12615)
• 272e4db Fix: no-multiple-empty-lines: Adjust reported loc (#12594)
• a258039 Fix: no-restricted-imports schema allows multiple paths/patterns objects (#12639)
• 51f9620 Fix: improve report location for array-bracket-spacing (#12653)
• 45364af Fix: prefer-numeric-literals doesn't check types of literal arguments (#12655)
• e3c570e Docs: Add example for expression option (#12694)

There are 29 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴