nhsuk/nearby-services-api

DEPRECATED - no longer actively maintained

nearby-services-api's Issues

An in-range update of nhsuk-bunyan-logger is breaking the build 🚨

The dependency nhsuk-bunyan-logger was updated from 1.11.0 to 1.12.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nhsuk-bunyan-logger is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Release Notes for Release 1.12.0

See CHANGELOG for additional information.

Commits

The new version differs by 25 commits.

• c178711 Merge pull request #62 from nhsuk/feature/replace-istanbul
• d6231f7 :dog: Move Husky hooks into root level
• 2915db8 :up: Update to latest eslint-config-nhsuk version
• fa2087e :page_with_curl: Link to Actions interface from README
• 56f214e :left_right_arrow: Replace istanbul with nyc
• 5ccc070 :up: Update npm dependencies
• ec59598 Merge pull request #61 from nhsuk/feature/update-deps
• b354952 :loudspeaker: Publish to npm via GitHub Actions
• fdf67a7 :put_litter_in_its_place: Remove Travis config
• 1ea3586 :name_badge: Add GitHub Action badge
• 8474da3 :question: Add GitHub Actions for CI workflow
• f2d8ea4 Merge pull request #59 from nhsuk/feature/update-deps
• d47194e :ok: Use node version 10 on CI agent
• a03e7ff :up: Update npm dependencies
• 21bc033 :cop: Add snyk badge with integration

There are 25 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Remove double validation

See #15 for a bit more information. The app should just be validating the input once. Ideally in the middleware - this issue is here to fix that.

Return metric distances rather than imperial

Rather than sending back distances in miles do it in meters or kilometres (probably the former)

Use `bunyan` logger rather than `nhsuk-bunyan-logger`

Add API documentation

What is the interface of the API?
Get the API documented in something other than the tests and get it integrated into the README

An in-range update of helmet is breaking the build 🚨

The dependency helmet was updated from 3.15.0 to 3.15.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

helmet is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 4 commits.

• f545a94 3.15.1
• ca50146 Deprecate hpkp
• 6458cd5 Update license year for 2019
• 2dba625 Update devDependencies to latest versions and fix warnings

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of prom-client is breaking the build 🚨

The dependency prom-client was updated from 11.3.0 to 11.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

prom-client is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 3 commits.

• 6d1f37e 11.4.0
• 58336d4 chore: prepare for release
• da970a3 Split process request and process handles by type (#260)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of nodemon is breaking the build 🚨

The devDependency nodemon was updated from 1.19.1 to 1.19.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nodemon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Release Notes for v1.19.2

1.19.2 (2019-09-03)

Bug Fixes

• langauge around "watching" (#1591) (12b66cd)

Commits

The new version differs by 2 commits.

• 12b66cd fix: langauge around "watching" (#1591)
• 2e6e2c4 docs: README Grammar (#1601)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Remove identifier from docDB request and API response

When this issue nhsuk/connecting-to-services#221 has been actioned the query to docDB no longer needs to include services.identifier,. Removing that will reduce the payload returned from docDB, which also gets returned via to the API.

Stash un-staged files before test run and remove post-rewrite git hook

See here for rational and changes required.

An in-range update of eslint-plugin-import is breaking the build 🚨

The devDependency eslint-plugin-import was updated from 2.14.0 to 2.15.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 34 commits.

• 767f01a bump to v2.15.0
• 038d668 bump webpack resolver to v0.11.0
• 20a8f3b bump utils to v2.3.0
• 1e4100d changelog note for #1261
• 548ea02 added support for argv parameter of webpack`s config-as-a-function (#1261)
• fcf2ce7 Merge pull request #1254 from ljharb/travis
• 64d9be7 allow_failures for dicey Node/ESLint intersection
• 73080d0 dep-time-travel: use older versions of dependencies
• 05c3935 repair no-deprecated for ESLint* 5
• 10c9811 node 4 fix for test util
• f165237 ah geez, bumping babel-eslint breaks no-amd/no-cjs
• acfb6e9 jk, test against eslint 2/3 but skip Typescript tests.
• b686f9d drop ESLint 2/3 from Travis/Appveyor
• cf1f6f4 [Deps] update debug, eslint-import-resolver-node, has, lodash, minimatch, resolve
• d290a87 [Dev Deps] update babylon, coveralls, eslint-import-resolver-typescript, gulp, linklocal, nyc, redux, rimraf, sinon, typescript-eslint-parser

There are 34 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of helmet is breaking the build 🚨

The dependency helmet was updated from 3.18.0 to 3.19.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

helmet is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Commits

The new version differs by 8 commits.

• 17707ae 3.19.0
• ca34982 Update changelog for 3.19.0 release
• 06d5bde Update all remaining outdated dependencies
• 91e071c Update helmet-crossdomain from 0.3.0 to 0.4.0
• 1a27ebb Update Standard from 12.0.1 to 13.0.2
• eff00ef Bump lodash from 4.17.11 to 4.17.14
• d70b5cc Update Connect dev dependency to latest version
• debb3f8 Remove useless npmignore (see "files" in package.json)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of elasticsearch is breaking the build 🚨

The dependency elasticsearch was updated from 16.1.1 to 16.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

elasticsearch is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 3 commits.

• f69840c version 16.2.0
• 34b7c55 [apis] regenerate
• 1eac969 update branches for recent versions

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Snyk protect fails for splunk-logging when run on Docker container

Patching, which works OK when run on a local machine, fails when run on docker.

Steps to reproduce:

• Change command in docker-compose-test.yml to be sh -c 'npm run git-hook && npm run watch-testto prevent docker container from exiting when npm snyk test fails
• docker-compose -f docker-compose-tests.yml up --build --force-recreate
• docker ps to get nearbyservicesapi_api-test container id
• docker exec -it {container-id} sh
• npm run snyk-test (command exits with ✗ Medium severity vulnerability found on [email protected])
• npm run snyk-protect (completes without error)
• npm run snyk-test (command still exits with same vulnerability)
• npm run snyk -- wizard
  • ? Do you want to revisit your existing policy [y] or only update it [N]? Yes
  • ? Add snyk test to package.json file to fail test on newly disclosed vulnerabilities? No
  • Applying patches...
  • The patch against "node_modules/splunk-logging/node_modules/request" (npm:request:20160119) failed.

An in-range update of nodemon is breaking the build 🚨

The devDependency nodemon was updated from 1.18.5 to 1.18.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nodemon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Release Notes for v1.18.6

1.18.6 (2018-11-05)

Bug Fixes

• restart on change for non-default signals (#1409) (#1430) (521eb1e)

Commits

The new version differs by 1 commits.

• 521eb1e fix: restart on change for non-default signals (#1409) (#1430)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-import is breaking the build 🚨

The devDependency eslint-plugin-import was updated from 2.18.0 to 2.18.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Commits

The new version differs by 14 commits.

• b51aa2f Bump to v2.18.1
• 32704da fix: Improve parse perf when using @typescript-eslint/parser
• 3b21de6 [Tests] extract common "get parser" logic into test helpers
• f4e3f1b prefer-default-export: don't warn on TypeAlias & TSTypeAliasDeclaration
• 1caa402 [Fix] no-unused-modules: Exclude package "main"/"bin"/"browser" entry points
• 22d5440 [fix] export: false positive for typescript overloads
• 5abd5ed [Tests] temporarily disable these failing tests in eslint < 4
• 752dcd5 [Tests] add missing --no-save to time travel script
• d3a3fa5 [Refactor] no-extraneous-dependencies: remove the last bit of lodash
• 8a38fd4 [Refactor] no-extraneous-dependencies: use Array.isArray instead of lodash
• c5078ad [Refactor] importType: remove use of cond
• 118afd4 no-deprecated: don't run tests for typescript-eslint-parser against ESLint <4
• 6512110 fix tests for node 4 + fixed lint issues
• bb9ba24 no-deprecated TS tests (#1315)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of coveralls is breaking the build 🚨

The devDependency coveralls was updated from 3.0.4 to 3.0.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

coveralls is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Commits

The new version differs by 6 commits.

• 55fc4d8 Merge branch 'master' of https://github.com/nickmerwin/node-coveralls
• b94fd9a version bump
• 0c147a8 fix: vulnerabilities (#227)
• 2c73fc8 Bump lodash from 4.17.11 to 4.17.14 (#229)
• cf1921d Update configuration logic for Jenkins (#217)
• f0ddec5 Add support for Azure Pipelines (#221)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Up the coverage on coveralls

Based on https://coveralls.io/builds/10036613 we have not been testing the non-happy path/error callbacks as thoroughly
Suggestions:

• use sinon-choi for mocking (https://www.npmjs.com/package/sinon-chai)
• raise errors - http://stackoverflow.com/questions/33998896/how-to-test-error-callback-in-node-js
• improve coverage

Remove mocha v3 exit behaviour

test

An in-range update of mocha is breaking the build 🚨

The devDependency mocha was updated from 6.1.4 to 6.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

---

Release Notes for v6.2.0

6.2.0 / 2019-07-18

🎉 Enhancements

• #3827: Do not fork child-process if no Node flags are present (@boneskull)
• #3725: Base reporter store ref to console.log, see mocha/wiki (@craigtaub)

🐛 Fixes

• #3942: Fix "No test files found" Error when file is passed via --file (@gabegorelick)
• #3914: Modify Mocha constructor to accept options global or globals (@pascalpp)
• #3894: Fix parsing of config files with _mocha binary (@juergba)
• #3834: Fix CLI parsing with default values (@boneskull, @juergba)
• #3831: Fix --timeout/--slow string values and duplicate arguments (@boneskull, @juergba)

📖 Documentation

• #3906: Document option to define custom report name for XUnit reporter (@pkuczynski)
• #3889: Adds doc links for mocha-examples (@craigtaub)
• #3887: Fix broken links (@toyjhlee)
• #3841: Fix anchors to configuration section (@trescube)

🔍 Coverage

• #3915, #3929: Increase tests coverage for --watch options (@geigerzaehler)

🔩 Other

• #3953: Collect test files later, prepares improvements to the --watch mode behavior (@geigerzaehler)
• #3939: Upgrade for npm audit (@boneskull)
• #3930: Extract runWatch into separate module (@geigerzaehler)
• #3922: Add mocha.min.js file to stacktrace filter (@brian-lagerman)
• #3919: Update CI config files to use Node-12.x (@plroebuck)
• #3892: Rework reporter tests (@plroebuck)
• #3872: Rename --exclude to --ignore and create alias (@boneskull)
• #3963: Hide stacktrace when cli args are missing (@outsideris)
• #3956: Do not redeclare variable in docs array example (@DanielRuf)
• #3957: Remove duplicate line-height property in mocha.css (@DanielRuf)
• #3960: Don't re-initialize grep option on watch re-run (@geigerzaehler)

Commits

The new version differs by 39 commits.

• bd47776 Release v6.2.0
• cc595af update CHANGELOG.md for v6.2.0 [ci skip]
• 59d70ee fix: remove duplicate line-height property (#3957)
• f77cac4 fix: do not redeclare variable (#3956)
• 6201e42 Hide stacktrace when cli args are missing (#3963)
• 88f45d5 Don't re-initialize grep option on watch re-run (#3960)
• 5d4dd98 Fix No Files error when file is passed via --files (#3942)
• 15b96af Collect test files later (#3953)
• ccee5f1 Base reporter store ref to console.log (#3725)
• 47318a7 update @mocha/contributors to v1.0.4 (#3944)
• c903147 More, improved integration tests for watching (#3929)
• e341ea4 Update CI config files to use Node-12.x (#3919)
• 3064d25 update @mocha/docdash to v2.1.1 (#3945)
• 9ea45e7 do not fork if no node flags present (#3827)
• d02a096 modify Mocha constructor to accept options.global or options.globals (#3914)

There are 39 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of newrelic is breaking the build 🚨

The dependency newrelic was updated from 4.8.1 to 4.9.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

newrelic is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 66 commits.

• 6a979ce release 4.9.0
• fdb9796 Updated changelog for v4.9.0.
• b25cfb1 Merge pull request #1578 from NodeJS-agent/NODE-1893-DT-UsePrimaryAccountId
• e1a0d0e Updates DT payload creation to use primary_application_id from connect response.
• a0587c8 Merge pull request #1577 from NodeJS-agent/nwolfe/apply-fn
• 47e3df5 Added protection again apply-less functions
• cd3c8a7 Merge pull request #1576 from NodeJS-agent/bclement/perf-plz
• 61bc00f review comments
• 818180c dedupe
• ebcd169 only wrap if unwrapped
• f277086 stopped process timers from being double wrapped
• b150742 Merge pull request #1573 from NodeJS-agent/NODE-1892-FixTimersInstrumentation
• c15bde1 Updates clearTimout instrumentation to only check for an onTimeout segment existing.
• 1fe5aa5 Merge pull request #1572 from NodeJS-agent/mgoin/NODE-1894-SlowSqlId-StopUsingMD5
• 3929a46 Increases hex digits leveraged for sql id. Fixes callback exception bug in codec.decode

There are 66 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴