nhsuk/profiles

DEPRECATED - no longer actively maintained

DEPRECATED - no longer actively maintained

---

Profiles

A collection of health service provider profiles. Initially containing GP practices and Pharmacies.

Test environments

As the application is being developed, every Pull Request has its own test environment automatically built and deployed to.

Every environment apart from the one we want the public to access requires basic authentication to access. The username and password are not secret, in fact they are included within environment variable table below. The intention with the authentication challenge is to prevent people whom may stumble across the site and not realise it is for testing, it also prevents access by search engines and other bots.

Environment variables

Environment variables are expected to be managed by the environment in which the application is being run. This is best practice as described by twelve-factor.

Variable	Description	Default
NODE_ENV	node environment	development
LOG_LEVEL	numeric log level	Depends on NODE_ENV
PORT	server port	3000
GOOGLE_ANALYTICS_TRACKING_ID	Google Analytics property id
WEBTRENDS_ANALYTICS_TRACKING_ID	Webtrends tracking id
HOTJAR_ANALYTICS_TRACKING_ID	Hotjar tracking id
BASIC_AUTH	An MD5 encrypted htpasswd	test:test

Working on the application

Start by cloning the repo and all submodules i.e. git clone https://github.com/nhsuk/profiles.git && cd profiles/ && git submodule update --init --recursive

Next, check out the set of scripts for getting the application running scripts

Architecture Decision Records

This repo uses Architecture Decision Records to record architectural decisions for this project. They are stored in doc/adr.

profiles's Issues

Do specific content / UI testing

Currently there are a number of assertions within the integration tests that are checking for content. These should really be moved out of the integration tests and done specifically for the testing the UI.

Refactor custom JS analytics files

There is an awful lot of very nearly duplicated code in:

• https://github.com/nhsuk/profiles/blob/master/public/js/custom-hj.js
• https://github.com/nhsuk/profiles/blob/master/public/js/custom-wt.js

Both files need refactoring into something where the underlying function changing will only require a single change rather than one for every function call.

Use docker-compose for testing on Travis

Remove contents of /public/css

The contents are generated during image creation, therefore the .css files aren't being used and should be removed to avoid any confusion

Fix styling of 404 page

The main content is left aligned rather than centered

Create sensible nunjucks linter rules

e.g.
The code between if or other statements being indented

Extend the integration test for the valid GP

It would be worth including as much data as possible in the test. As part of this the image of the db being used should be locked down to a test specific version i.e. one that doesn't or isn't going to change. This allows the tests to be written in the knowledge the data will not change and the tests will not fail because of the data.

Update ci-deployment scripts

Re-work logic for last child border on multiple exceptional opening times on desktop a/ similar to mobile

Override current date/time to allow the review of date/time dependant functionality.

The readme does not describe how to override the current date and time in order to view behaviour which is date/time dependant. At the time of writing this would be the display of exceptional opening times.

Increase min coverage back to 90 when enough tests available

Due to the small amount of code in the app the minimum code coverage needed to be reduced below 90%. This should be increased at the earliest opportunity.

Check for availability of `ga` in script

In customga.js it is assumed ga is available as a global function. This is only the case when Google Analytics has been loaded. Currently there is a check in the view that includes the JS. Ideally the JS would do the check itself to prevent it being run in an environment where ga should be available but for whatever reason isn't.

This would also allow all of the customXX.js files to be combined into a single one which could then be minified and hashed.

Use bunyan logger rather than `nhsuk-bunyan-logger`

Remove mocha v3 exit behaviour

Add Snyk

Re-work test for exceptional opening times

Currently the tests fail if no exceptional opening times data is returned. A pre test should be implemented, before we test the data itself.

Stop node-sass error when app starts up in the container

This isn't causing any issue as the css resources are generated during image creation

Move joining of contiguous times into gp-data-etl

The logic that joins contiguous times, i.e. a surgery open from 9am-1pm, then 1pm - 6pm is treated as a surgery open from 9-6pm should be moved to the ETL

The code in question is found at https://github.com/nhsuk/profiles/blob/e845dc638c60a909a5e2e2357c9b3ff177381990/app/lib/openingTimesUtils.js

The pharmacy-data-etl already has the logic implemented at https://github.com/nhsuk/pharmacy-data-etl/blob/master/app/lib/joinContiguousTimes.js

Split opening times into open and closed for JSON-LD

The JSON-LD is included in the page by the partial view schema.nunjucks has a property for opens and closes. Currently, both properties are the same value and contain both opening and closing time. The data needs to be split so these fields can be set correctly.
What to return when the surgery is closed needs to be considered.

Remove booking appointment page

Remove protocol addition logic

The code in this file https://github.com/nhsuk/profiles/blob/master/app/lib/contactsMapper.js to add the protocol to the website should be done in the source data. PR has been created to do that nhsuk/gp-data-etl#19
When that has been merged a new dataset has been generated of the new code this issue can be actions and the logic removed from this app.

Update query to use _id rather than choicesId for query

Remove 'profiles' segment from routing

No need for /profiles in the routing